EnforceNativeReturnTypehintRule: fix property hook false positive (#309)

Author: janedbal

src/Rule/EnforceNativeReturnTypehintRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Expr\Throw_;
 use PhpParser\Node\Stmt\Expression;
 use PHPStan\Analyser\Scope;
+use PHPStan\Node\PropertyHookReturnStatementsNode;
 use PHPStan\Node\ReturnStatementsNode;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\IdentifierRuleError;
@@ -80,6 +81,10 @@ public function processNode(
             return [];
         }
 
+        if ($node instanceof PropertyHookReturnStatementsNode) {
+            return []; // hooks cannot have native return typehints
+        }
+
         if (!$scope->isInAnonymousFunction() && in_array($scope->getFunctionName(), ['__construct', '__destruct', '__clone'], true)) {
             return [];
         }

tests/Rule/EnforceNativeReturnTypehintRuleTest.php

@@ -37,6 +37,16 @@ public function testEnum(): void
         $this->analyseFile(__DIR__ . '/data/EnforceNativeReturnTypehintRule/code-enum.php');
     }
 
+    public function testHooks(): void
+    {
+        if (PHP_VERSION_ID < 80_400) {
+            self::markTestSkipped('Requires PHP 8.4');
+        }
+
+        $this->phpVersion = self::getContainer()->getByType(PhpVersion::class);
+        $this->analyseFile(__DIR__ . '/data/EnforceNativeReturnTypehintRule/code-hook.php');
+    }
+
     public function testPhp82(): void
     {
         $this->phpVersion = $this->createPhpVersion(80_200);

tests/Rule/data/EnforceNativeReturnTypehintRule/code-hook.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace EnforceNativeReturnTypehintRuleHooks;
+
+class Person
+{
+    public int $age = 0 {
+        set => $value >= 0 ? $value : throw new InvalidArgumentException;
+    }
+
+}