Skip to content

Commit 730d024

Browse files
spike-rabbittimowolf
authored andcommitted
refactor: provide services where actually needed
1 parent 78ebef3 commit 730d024

File tree

5 files changed

+4
-22
lines changed

5 files changed

+4
-22
lines changed

projects/ngx-datatable/src/lib/components/datatable.component.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import { DataTableBodyComponent } from './body/body.component';
4141
import { DataTableHeaderComponent } from './header/header.component';
4242
import { ScrollbarHelper } from '../services/scrollbar-helper.service';
4343
import { ColumnChangesService } from '../services/column-changes.service';
44-
import { DimensionsHelper } from '../services/dimensions-helper.service';
4544
import { throttleable } from '../utils/throttle';
4645
import { adjustColumnWidths, forceFillColumnWidths } from '../utils/math';
4746
import { sortGroupedRows, sortRows } from '../utils/sort';
@@ -84,7 +83,8 @@ import { ProgressBarComponent } from './body/progress-bar.component';
8483
{
8584
provide: DatatableComponentToken,
8685
useExisting: DatatableComponent
87-
}
86+
},
87+
ColumnChangesService
8888
],
8989
standalone: true,
9090
imports: [
@@ -100,7 +100,6 @@ export class DatatableComponent<TRow = any>
100100
implements OnInit, DoCheck, AfterViewInit, AfterContentInit, OnDestroy
101101
{
102102
private scrollbarHelper = inject(ScrollbarHelper);
103-
private dimensionsHelper = inject(DimensionsHelper);
104103
private cd = inject(ChangeDetectorRef);
105104
private columnChangesService = inject(ColumnChangesService);
106105
private configuration = inject<INgxDatatableConfig>('configuration' as any, { optional: true });
@@ -961,7 +960,7 @@ export class DatatableComponent<TRow = any>
961960
*
962961
*/
963962
recalculateDims(): void {
964-
const dims = this.dimensionsHelper.getDimensions(this.element);
963+
const dims = this.element.getBoundingClientRect();
965964
this._innerWidth = Math.floor(dims.width);
966965

967966
if (this.scrollbarV) {

projects/ngx-datatable/src/lib/ngx-datatable.module.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
import { ModuleWithProviders, NgModule } from '@angular/core';
2-
import { ScrollbarHelper } from './services/scrollbar-helper.service';
3-
import { DimensionsHelper } from './services/dimensions-helper.service';
4-
import { ColumnChangesService } from './services/column-changes.service';
52
import { DataTableFooterTemplateDirective } from './components/footer/footer-template.directive';
63
import { DatatableComponent } from './components/datatable.component';
74
import { DataTableColumnDirective } from './components/columns/column.directive';
@@ -40,7 +37,6 @@ import {
4037
DatatableRowDefComponent,
4138
DatatableRowDefDirective
4239
],
43-
providers: [ScrollbarHelper, DimensionsHelper, ColumnChangesService],
4440
exports: [
4541
DatatableComponent,
4642
DatatableRowDetailDirective,

projects/ngx-datatable/src/lib/services/dimensions-helper.service.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

projects/ngx-datatable/src/lib/services/scrollbar-helper.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { DOCUMENT } from '@angular/common';
55
* Gets the width of the scrollbar. Nesc for windows
66
* http://stackoverflow.com/a/13382873/888165
77
*/
8-
@Injectable()
8+
@Injectable({ providedIn: 'root' })
99
export class ScrollbarHelper {
1010
private document = inject(DOCUMENT);
1111

projects/ngx-datatable/src/public-api.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export * from './lib/directives/disable-row.directive';
4040

4141
// services
4242
export * from './lib/services/scrollbar-helper.service';
43-
export * from './lib/services/dimensions-helper.service';
4443
export * from './lib/services/column-changes.service';
4544

4645
// types

0 commit comments

Comments
 (0)