Skip to content

Commit 71f13a3

Browse files
author
itERRatOR
committed
Replace java core assert with junit assert
1 parent d9611b7 commit 71f13a3

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/test/java/com/simplesteph/kafka/GitHubSourceTaskTest.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@
1313
import java.util.Set;
1414

1515
import static com.simplesteph.kafka.GitHubSourceConnectorConfig.*;
16+
import static org.junit.Assert.*;
1617

1718
public class GitHubSourceTaskTest {
1819

19-
GitHubSourceTask gitHubSourceTask = new GitHubSourceTask();
20+
private GitHubSourceTask gitHubSourceTask = new GitHubSourceTask();
2021
private Integer batchSize = 10;
2122

2223
private Map<String, String> initialConfig() {
@@ -40,17 +41,18 @@ public void test() throws UnirestException {
4041
System.out.println(url);
4142
HttpResponse<JsonNode> httpResponse = gitHubSourceTask.gitHubHttpAPIClient.getNextIssuesAPI(gitHubSourceTask.nextPageToVisit, gitHubSourceTask.nextQuerySince);
4243
if (httpResponse.getStatus() != 403) {
43-
assert (httpResponse.getStatus() == 200);
44+
assertEquals(200, httpResponse.getStatus());
4445
Set<String> headers = httpResponse.getHeaders().keySet();
45-
assert (headers.contains("ETag"));
46-
assert (headers.contains("X-RateLimit-Limit"));
47-
assert (headers.contains("X-RateLimit-Remaining"));
48-
assert (headers.contains("X-RateLimit-Reset"));
49-
assert (httpResponse.getBody().getArray().length() == 10);
46+
assertTrue(headers.contains("ETag"));
47+
assertTrue(headers.contains("X-RateLimit-Limit"));
48+
assertTrue(headers.contains("X-RateLimit-Remaining"));
49+
assertTrue(headers.contains("X-RateLimit-Reset"));
50+
assertEquals(batchSize.intValue(), httpResponse.getBody().getArray().length());
5051
JSONObject jsonObject = (JSONObject) httpResponse.getBody().getArray().get(0);
5152
Issue issue = Issue.fromJson(jsonObject);
52-
assert (issue != null);
53-
assert (issue.getNumber() == 2072);
53+
assertNotNull(issue);
54+
assertNotNull(issue.getNumber());
55+
assertEquals(2072, issue.getNumber().intValue());
5456
}
5557
}
5658
}

0 commit comments

Comments
 (0)