Skip to content

Commit f51ecea

Browse files
committed
fixed a few bugs
added more log in case of 404 bumped version to 1.1
1 parent 9de09cc commit f51ecea

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>com.simplesteph.kafka</groupId>
66
<artifactId>kafka-connect-github-source</artifactId>
7-
<version>1.0</version>
7+
<version>1.1</version>
88
<packaging>jar</packaging>
99

1010
<name>kafka-connect-github-source</name>

src/main/java/com/simplesteph/kafka/GitHubAPIHttpClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ protected JSONArray getNextIssues(Integer page, Instant since) throws Interrupte
5959
Thread.sleep(1000 * sleepTime);
6060
return getNextIssues(page, since);
6161
default:
62+
log.error(constructUrl(page, since));
6263
log.error(String.valueOf(jsonResponse.getStatus()));
6364
log.error(jsonResponse.getBody().toString());
6465
log.error(jsonResponse.getHeaders().toString());

src/main/java/com/simplesteph/kafka/GitHubSchemas.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ public class GitHubSchemas {
88
public static String NEXT_PAGE_FIELD = "next_page";
99

1010
// Issue fields
11-
public static String FULL_REPO_FIELD = "owner/repository";
1211
public static String OWNER_FIELD = "owner";
1312
public static String REPOSITORY_FIELD = "repository";
1413
public static String CREATED_AT_FIELD = "created_at";
@@ -32,10 +31,10 @@ public class GitHubSchemas {
3231
public static String PR_HTML_URL_FIELD = "html_url";
3332

3433
// Schema names
35-
public static String SCHEMA_KEY = "GitHub Issue Key";
36-
public static String SCHEMA_VALUE_ISSUE = "Issue";
37-
public static String SCHEMA_VALUE_USER = "User";
38-
public static String SCHEMA_VALUE_PR = "PR";
34+
public static String SCHEMA_KEY = "issue_key";
35+
public static String SCHEMA_VALUE_ISSUE = "issue";
36+
public static String SCHEMA_VALUE_USER = "user";
37+
public static String SCHEMA_VALUE_PR = "pr";
3938

4039
// Key Schema
4140
public static Schema KEY_SCHEMA = SchemaBuilder.struct().name(SCHEMA_KEY)

0 commit comments

Comments
 (0)