ESLint の定義を更新する #32

Author: sinproject-iwasaki

.eslintrc.cjs

@@ -6,15 +6,82 @@ module.exports = {
 	ignorePatterns: ['*.cjs'],
 	overrides: [{ files: ['*.svelte'], processor: 'svelte3/svelte3' }],
 	settings: {
-		'svelte3/typescript': () => require('typescript')
+		'svelte3/typescript': () => require('typescript'),
 	},
 	parserOptions: {
 		sourceType: 'module',
-		ecmaVersion: 2020
+		ecmaVersion: 2020,
 	},
 	env: {
 		browser: true,
 		es2017: true,
-		node: true
-	}
-};
+		node: true,
+	},
+	rules: {
+		'@typescript-eslint/explicit-member-accessibility': ['error'],
+		'@typescript-eslint/explicit-function-return-type': ['warn'],
+		'@typescript-eslint/naming-convention': [
+			'error',
+			{
+				selector: 'typeParameter',
+				format: ['UPPER_CASE'],
+			},
+			{
+				selector: ['class', 'interface', 'typeAlias'],
+				format: ['PascalCase'],
+			},
+			{
+				selector: ['method', 'function'],
+				modifiers: ['private'],
+				format: ['camelCase'],
+				leadingUnderscore: 'require',
+			},
+			{
+				selector: ['method', 'function'],
+				modifiers: ['protected'],
+				format: ['camelCase'],
+				leadingUnderscore: 'require',
+			},
+			{
+				selector: ['method', 'function'],
+				format: ['camelCase', 'UPPER_CASE'],
+			},
+			{
+				selector: [
+					'property',
+					'accessor',
+					'parameter',
+					'parameterProperty',
+					'variable',
+					'enumMember',
+				],
+				modifiers: ['private'],
+				format: ['snake_case'],
+				leadingUnderscore: 'require',
+			},
+			{
+				selector: [
+					'property',
+					'accessor',
+					'parameter',
+					'parameterProperty',
+					'variable',
+					'enumMember',
+				],
+				modifiers: ['protected'],
+				format: ['snake_case'],
+				leadingUnderscore: 'require',
+			},
+			{
+				selector: ['accessor', 'parameter', 'parameterProperty', 'enumMember'],
+				format: ['snake_case'],
+			},
+			{
+				selector: ['property', 'variable'],
+				format: ['snake_case', 'UPPER_CASE', 'camelCase'],
+			},
+			// TODO: 引数、関数、クラス、インターフェイス、enumのメンバー名のルール
+		],
+	},
+}
+

src/lib/cookies_manager.ts

@@ -1,9 +1,9 @@
 import type { Cookies } from "@sveltejs/kit";
 
 export class CookiesManager {
-	constructor(private readonly _cookies: Cookies) {}
+	public constructor(private readonly _cookies: Cookies) {}
 
-	setSessionId(session_id: string) {
+	public setSessionId(session_id: string): void {
 		this._cookies.set('session_id', session_id, {
 			path: '/',
 			maxAge: 60 * 60 * 24 * 30,

src/lib/nodemailer_manager.ts

@@ -3,7 +3,7 @@ import * as nodemailer from 'nodemailer';
 export class NodemailerManager {
 	private readonly _transporter: nodemailer.Transporter
 
-	constructor() {
+	public constructor() {
 		this._transporter = nodemailer.createTransport({
 			service: 'gmail',
 			port: 465,
@@ -15,7 +15,7 @@ export class NodemailerManager {
 		})
 	}
 
-	async sendMail(to: string, subject: string, text: string) {
+	public async sendMail(to: string, subject: string, text: string): Promise<unknown> {
 		const from = process.env.GMAIL_USER
 
 		return await this._transporter.sendMail({ from, to, subject, text })

src/routes/pin_code/+page.server.ts

@@ -3,7 +3,7 @@ import { db } from '$lib/database'
 import { NodemailerManager as NodeMailerManager } from '$lib/nodemailer_manager'
 import type { PageServerLoad } from '.svelte-kit/types/src/routes/$types'
 import type { User } from '@prisma/client'
-import { invalid, redirect, type Actions } from '@sveltejs/kit'
+import { invalid, redirect, type Action, type Actions } from '@sveltejs/kit'
 
 enum Roles {
 	admin = 'admin',
@@ -19,7 +19,7 @@ export const load: PageServerLoad = async ({ locals, url, request }) => {
 	if (request.method != 'POST') redirect(302, '/')
 }
 
-function createPinCode(length = 6) {
+function createPinCode(length = 6): string {
 	const pin_code_chars = '0123456789'
 
 	let pin_code = ''
@@ -31,7 +31,7 @@ function createPinCode(length = 6) {
 	return pin_code
 }
 
-async function sendMail(user: User, pin_code: string) {
+async function sendMail(user: User, pin_code: string): Promise<void> {
 	const nodeMailerManager = new NodeMailerManager()
 
 	try {
@@ -45,11 +45,11 @@ async function sendMail(user: User, pin_code: string) {
 	}
 }
 
-async function findUser(email: string, canRegister = true) {
+async function findUser(email: string, can_register = true): Promise<User | undefined> {
 	const user = await db.user.findUnique({ where: { email } })
 
 	if (user) return user;
-	if (!canRegister) return undefined;
+	if (!can_register) return undefined;
 
 	try {
 		return await db.user.create({
@@ -64,13 +64,13 @@ async function findUser(email: string, canRegister = true) {
 	}
 }
 
-async function login(request: Request, canRegister = true) {
+async function login(request: Request, can_register = true): Promise<Action> {
 	const data = await request.formData()
 	const email = data.get('email')?.toString() ?? ''
 
 	if (!email) throw redirect(302, '/')
 
-	const user = await findUser(email, canRegister)
+	const user = await findUser(email, can_register)
 
 	if (!user) return { success: true, email, missing: false, credentials: false }
 
@@ -80,7 +80,7 @@ async function login(request: Request, canRegister = true) {
 
 	const user_id = user.id
 
-	await db.authPin.upsert({
+	const a = await db.authPin.upsert({
 		where: { user_id },
 		update: { pin_code },
 		create: { user_id, pin_code },