[Hacker Rank]: Warmup: Plus Minus. Solved ✅.

Author: Gonzalo Diaz

src/lib/exercises/include/exercises/hackerrank/warmup/plus_minus.h

@@ -4,8 +4,8 @@
 extern "C" {
 #endif
 
-char **HACKERRANK_WARMUP_plusMinusCalculate(int arr_count, int *arr);
-void HACKERRANK_WARMUP_plusMinus(int arr_count, int *arr);
+char **HACKERRANK_WARMUP_plusMinusCalculate(int arr_count, const int *arr);
+void HACKERRANK_WARMUP_plusMinus(int arr_count, const int *arr);
 
 #ifdef __cplusplus
 } // extern "C"

src/lib/exercises/src/hackerrank/warmup/plus_minus.c

@@ -16,7 +16,7 @@ char *format_result(double number) {
   return buffer;
 }
 
-char **HACKERRANK_WARMUP_plusMinusCalculate(int arr_count, int *arr) {
+char **HACKERRANK_WARMUP_plusMinusCalculate(int arr_count, const int *arr) {
   int positives = 0;
   int negatives = 0;
   int zeros = 0;
@@ -54,11 +54,13 @@ char **HACKERRANK_WARMUP_plusMinusCalculate(int arr_count, int *arr) {
   return answer;
 }
 
-void HACKERRANK_WARMUP_plusMinus(int arr_count, int *arr) {
+void HACKERRANK_WARMUP_plusMinus(int arr_count, const int *arr) {
   char **output = HACKERRANK_WARMUP_plusMinusCalculate(arr_count, arr);
 
-  for (int i = 0; i < arr_count; i++) {
+  int LIMIT = 3;
+  for (int i = 0; i < LIMIT; i++) {
     printf("%s", output[i]);
+    free(output[i]);
   }
 
   free(output);

src/tests/unit/lib/hackerrank/warmup/plus_minus.test.cpp

@@ -23,15 +23,23 @@ TEST_CASE("plusMinus JSON Test Cases", "[hackerrank] [jsontestcase] [warmup]") {
   for (auto testcase : data) {
     auto input_size = static_cast<int>(testcase["input"].size());
     std::vector<int> input_vector = testcase["input"];
-    int *input_array = input_vector.data();
-
-    HACKERRANK_WARMUP_plusMinus(input_size, input_array);
+    const int *input_array = input_vector.data();
 
     char **result =
         HACKERRANK_WARMUP_plusMinusCalculate(input_size, input_array);
 
-    std::vector<std::string> result_as_vector(result, result + input_size);
+    std::vector<std::string> result_as_vector;
+
+    int LIMIT = 3;
+    for (int i = 0; i < LIMIT; i++) {
+      result_as_vector.emplace_back(result[i]);
+      free(result[i]);
+    }
+    free(result);
 
     CHECK(result_as_vector == testcase["expected"]);
+
+    // Just call void function, to collect coverage
+    HACKERRANK_WARMUP_plusMinus(input_size, input_array);
   }
 }