fix: list indentation inside raw HTML blocks #2337 #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kermanx
changed the title
This reverts commit 97ff43a.
This adds a transformer that ensures lists inside HTML blocks maintain proper indentation to prevent Vue parse errors when prettier-plugin-slidev removes the required indentation. Note: This is a workaround. The proper fix should be in prettier-plugin-slidev to preserve indentation during formatting. This transformer ensures compatibility even when Prettier removes the required indentation. Fixes slidevjs#2337
Skip processing lists inside Vue components (v-*, PascalCase, template) to prevent breaking v-clicks and other Vue component functionality. Fixes Cypress test failure for deep nested lists.
The pkg-pr-new GitHub app is only installed on the upstream repository, not on forks. This causes CI to fail on forks. Skip this step unless running on the upstream repository.
Bitshifter-9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added transformHtmlListIndent to preserve list indentation inside raw HTML blocks in slide Markdown, preventing Vue compile errors caused by Prettier removing spaces.
Integrated the transformer early in the Markdown pipeline.
Added regression tests and a snapshot for the
this closes issue #2337