Skip to content

Commit 1190bce

Browse files
committed
Activate the Stacktrace on navigation.
1 parent 1850e30 commit 1190bce

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

lib/stacktrace-view.coffee

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class StacktraceView extends View
2020
@span class: 'inline-block', 'to close the stacktrace navigation panel.'
2121
@div class: 'frames', =>
2222
for frame in trace.frames
23-
@subview 'frame', new FrameView(frame)
23+
@subview 'frame', new FrameView frame, => trace.activate()
2424

2525
initialize: (@trace) ->
2626
@subscribe Stacktrace, 'active-changed', (e) =>
@@ -53,7 +53,7 @@ class StacktraceView extends View
5353

5454
class FrameView extends View
5555

56-
@content: (frame) ->
56+
@content: (frame, navCallback) ->
5757
@div class: 'frame inset-panel', =>
5858
@div class: 'panel-heading', =>
5959
@span class: 'icon icon-fold inline-block', click: 'minimize'
@@ -64,14 +64,16 @@ class FrameView extends View
6464
@div class: 'panel-body padded', outlet: 'body', click: 'navigate', =>
6565
@subview 'source', new EditorView(mini: true)
6666

67-
initialize: (@frame) ->
67+
initialize: (@frame, @navCallback) ->
6868
@frame.getContext 3, (err, lines) =>
6969
if err?
7070
console.error err
7171
else
7272
@source.getEditor().setText lines.join("\n")
7373

74-
navigate: -> @frame.navigateTo()
74+
navigate: ->
75+
@navCallback()
76+
@frame.navigateTo()
7577

7678
minimize: ->
7779
@addClass 'minimized'

spec/stacktrace-view-spec.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ describe 'FrameView', ->
4747
[view] = []
4848

4949
beforeEach ->
50-
view = new FrameView(frames[1])
50+
view = new FrameView frames[1], ->
5151

5252
it 'shows the filename and line number', ->
5353
text = view.find('.source-location').text()

0 commit comments

Comments
 (0)