Merge pull request #3 from smashwilson/from-selection

Detect stack traces in the current selection

Author: smashwilson

lib/main.coffee

@@ -5,9 +5,14 @@ EnterDialog = require './enter-dialog'
 module.exports =
 
   activate: (state) ->
-    atom.workspaceView.command 'stacktrace:enter', ->
+    atom.workspaceView.command 'stacktrace:paste', ->
       atom.workspaceView.appendToTop new EnterDialog()
 
+    atom.workspaceView.command 'stacktrace:from-selection', ->
+      selections = atom.workspace.getActiveEditor()?.getSelections()
+      text = (s.getText() for s in (selections or [])).join ''
+      atom.emit 'stacktrace:accept-trace', trace: text
+
     StacktraceView.registerIn(atom.workspace)
 
     atom.on 'stacktrace:accept-trace', ({trace}) =>

lib/stacktrace-view.coffee

@@ -9,7 +9,7 @@ class StacktraceView extends View
 
   @content: (trace) ->
     tclass = if trace.isActive() then 'activated' else ''
-    @div class: "stacktrace tool-panel padded #{tclass}", =>
+    @div class: "stacktrace traceview tool-panel padded #{tclass}", =>
       @div class: 'panel padded', =>
         @h2 class: 'error-message', trace.message
         @p class: 'activate-control', =>

package.json

@@ -4,7 +4,8 @@
   "version": "0.0.0",
   "description": "Navigate stacktraces within Atom.",
   "activationEvents": [
-    "stacktrace:enter"
+    "stacktrace:paste",
+    "stacktrace:from-selection"
   ],
   "repository": "https://github.com/smashwilson/stacktrace",
   "license": "MIT",

spec/fixtures/withtrace.txt

@@ -0,0 +1,9 @@
+this is a file with a stacktrace in it
+
+/home/smash/samples/tracer/otherdir/file2.rb:6:in `block in outerfunction': whoops (RuntimeError)
+  from /home/smash/samples/tracer/dir/file1.rb:3:in `innerfunction'
+  from /home/smash/samples/tracer/otherdir/file2.rb:5:in `outerfunction'
+  from /home/smash/samples/tracer/entry.rb:7:in `toplevel'
+  from /home/smash/samples/tracer/entry.rb:10:in `<main>'
+
+so i can test from-selection stuff

spec/main-spec.coffee

@@ -1,3 +1,5 @@
+path = require 'path'
+
 {WorkspaceView} = require 'atom'
 Stacktrace = require '../lib/main'
 
@@ -8,14 +10,35 @@ describe "Main", ->
     atom.workspaceView = new WorkspaceView
     activationPromise = atom.packages.activatePackage('stacktrace')
 
-  describe "when the stacktrace:enter event is triggered", ->
+  describe 'when the stacktrace:paste event is triggered', ->
 
     beforeEach ->
-      atom.workspaceView.trigger 'stacktrace:enter'
+      atom.workspaceView.trigger 'stacktrace:paste'
       waitsForPromise -> activationPromise
 
     it 'activates the package', ->
       expect(atom.packages.isPackageActive 'stacktrace').toBe(true)
 
     it 'displays the EnterDialog', ->
       expect(atom.workspaceView.find '.enter-dialog').toExist()
+
+  describe 'when the stacktrace:from-selection event is triggered', ->
+
+    beforeEach ->
+      p = path.join __dirname, 'fixtures', 'withtrace.txt'
+      editorPromise = atom.workspace.open(p)
+
+      waitsForPromise -> editorPromise
+
+      runs ->
+        editorPromise.then (editor) ->
+          editor.setSelectedBufferRange [[1, 0], [7, 0]]
+          atom.workspaceView.trigger 'stacktrace:from-selection'
+
+      waitsForPromise -> activationPromise
+
+    it 'activates the package', ->
+      expect(atom.packages.isPackageActive 'stacktrace').toBe(true)
+
+    it 'displays a StacktraceView', ->
+      expect(atom.workspaceView.find '.traceview').toExist()