refactor: fromStringOrNull

Author: BFergerson

src/main/kotlin/spp/protocol/platform/auth/RolePermission.kt

@@ -95,7 +95,11 @@ enum class RolePermission(val manager: Boolean, val commandType: CommandType) {
     SHOW_QUICK_STATS(false, LIVE_VIEW);
 
     companion object {
-        fun fromString(s: String): RolePermission? {
+        fun fromString(s: String): RolePermission {
+            return fromStringOrNull(s) ?: RolePermission.valueOf(s)
+        }
+
+        fun fromStringOrNull(s: String): RolePermission? {
             //todo: remove v0.8.0+
             if (s == "ADD_LIVE_VIEW_SUBSCRIPTION") {
                 return ADD_LIVE_VIEW

src/main/kotlin/spp/protocol/platform/developer/SelfInfo.kt

@@ -33,8 +33,7 @@ data class SelfInfo(
     constructor(json: JsonObject) : this(
         developer = Developer(json.getJsonObject("developer")),
         roles = json.getJsonArray("roles").map { DeveloperRole.fromString(it.toString()) },
-        permissions = json.getJsonArray("permissions")
-            .map { RolePermission.fromString(it.toString()) ?: error("Invalid permission: $it") },
+        permissions = json.getJsonArray("permissions").map { RolePermission.fromString(it.toString()) },
         access = json.getJsonArray("access").map { AccessPermission(JsonObject.mapFrom(it)) }
     )