[minor-fix, google genai] use lazy load for unknown embedding dimensions and cache results #4803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viacheslav-dobrynin
force-pushed
the
lazy_load_dims
branch
from
337a621 to
74d3ee6
Compare
Signed-off-by: Viacheslav Dobrynin <w.v.dobr@gmail.com>
viacheslav-dobrynin
force-pushed
the
lazy_load_dims
branch
from
74d3ee6 to
44ce786
Compare
viacheslav-dobrynin
changed the title
viacheslav-dobrynin
changed the title
...ng/src/main/java/org/springframework/ai/google/genai/text/GoogleGenAiTextEmbeddingModel.java
Show resolved
Hide resolved
Member
|
LGTM, rebased and merged as a8b3982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
super.dimensions()calls the embedding model API to know actual dimensions number even if model exists in KNOWN_EMBEDDING_DIMENSIONS map.This leads to unnecessary expenses and problems during testing.
Solutions
if res != null res else compute())