Skip to content

Commit c7c0d33

Browse files
committed
Revert "Merge branch '3.4.x' into 3.5.x"
This reverts commit 4089156, reversing changes made to 049c6d5. See gh-48058
2 parents 4089156 + 8249929 commit c7c0d33

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void start() throws WebServerException {
117117
catch (Exception ex) {
118118
PortInUseException.ifCausedBy(ex, ChannelBindException.class, (bindException) -> {
119119
if (bindException.localPort() > 0 && !isPermissionDenied(bindException.getCause())) {
120-
PortInUseException.throwIfPortBindingException(bindException, bindException::localPort);
120+
throw new PortInUseException(bindException.localPort(), ex);
121121
}
122122
});
123123
throw new WebServerException("Unable to start Netty", ex);

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/netty/NettyReactiveWebServerFactoryTests.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
package org.springframework.boot.web.embedded.netty;
1818

1919
import java.net.ConnectException;
20-
import java.net.InetAddress;
2120
import java.net.SocketAddress;
22-
import java.net.UnknownHostException;
2321
import java.time.Duration;
2422
import java.util.Arrays;
2523

@@ -47,7 +45,6 @@
4745
import org.springframework.boot.web.server.PortInUseException;
4846
import org.springframework.boot.web.server.Shutdown;
4947
import org.springframework.boot.web.server.Ssl;
50-
import org.springframework.boot.web.server.WebServerException;
5148
import org.springframework.http.MediaType;
5249
import org.springframework.http.client.ReactorResourceFactory;
5350
import org.springframework.http.client.reactive.ReactorClientHttpConnector;
@@ -73,7 +70,7 @@
7370
class NettyReactiveWebServerFactoryTests extends AbstractReactiveWebServerFactoryTests {
7471

7572
@Test
76-
void portInUseExceptionIsThrownWhenPortIsAlreadyInUse() {
73+
void exceptionIsThrownWhenPortIsAlreadyInUse() {
7774
AbstractReactiveWebServerFactory factory = getFactory();
7875
factory.setPort(0);
7976
this.webServer = factory.getWebServer(new EchoHandler());
@@ -84,14 +81,6 @@ void portInUseExceptionIsThrownWhenPortIsAlreadyInUse() {
8481
.withCauseInstanceOf(Throwable.class);
8582
}
8683

87-
@Test
88-
void webServerExceptionIsThrownWhenAddressCannotBeAssigned() throws UnknownHostException {
89-
AbstractReactiveWebServerFactory factory = getFactory();
90-
factory.setPort(8080);
91-
factory.setAddress(InetAddress.getByName("1.2.3.4"));
92-
assertThatExceptionOfType(WebServerException.class).isThrownBy(factory.getWebServer(new EchoHandler())::start);
93-
}
94-
9584
@Test
9685
void getPortWhenDisposableServerPortOperationIsUnsupportedReturnsMinusOne() {
9786
NettyReactiveWebServerFactory factory = new NoPortNettyReactiveWebServerFactory(0);

0 commit comments

Comments
 (0)