Relax query parameter validation.

This change allows to use collection/array arguments with scalar operators when targeting a collection like property.

Closes #3356
Original pull request: #3359

Author: christophstrobl

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/PartTreeJpaQuery.java

@@ -166,10 +166,14 @@ private static void throwExceptionOnArgumentMismatch(String methodName, Part par
 
 		JpaParameter parameter = parameters.getBindableParameter(index);
 
-		if (expectsCollection(type) && !parameterIsCollectionLike(parameter)) {
-			throw new IllegalStateException(wrongParameterTypeMessage(methodName, property, type, "Collection", parameter));
-		} else if (!expectsCollection(type) && !parameterIsScalarLike(parameter)) {
-			throw new IllegalStateException(wrongParameterTypeMessage(methodName, property, type, "scalar", parameter));
+		if (expectsCollection(type)) {
+			if (!parameterIsCollectionLike(parameter)) {
+				throw new IllegalStateException(wrongParameterTypeMessage(methodName, property, type, "Collection", parameter));
+			}
+		} else {
+			if (!part.getProperty().isCollection() && !parameterIsScalarLike(parameter)) {
+				throw new IllegalStateException(wrongParameterTypeMessage(methodName, property, type, "scalar", parameter));
+			}
 		}
 	}
 
@@ -319,7 +323,7 @@ protected JpaQueryCreator createCreator(@Nullable JpaParametersParameterAccessor
 				returnedType = processor.getReturnedType();
 			}
 
-			if (accessor != null && accessor.getScrollPosition()instanceof KeysetScrollPosition keyset) {
+			if (accessor != null && accessor.getScrollPosition() instanceof KeysetScrollPosition keyset) {
 				return new JpaKeysetScrollQueryCreator(tree, returnedType, builder, provider, entityInformation, keyset);
 			}
 

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java

@@ -39,7 +39,16 @@
 import java.lang.annotation.Annotation;
 import java.lang.reflect.AnnotatedElement;
 import java.lang.reflect.Member;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
@@ -568,7 +577,7 @@ public static <T> Query applyAndBind(String queryString, Iterable<T> entities, E
 	 *
 	 * @param originalQuery must not be {@literal null} or empty.
 	 * @return Guaranteed to be not {@literal null}.
-	 * @deprecated use {@link DeclaredQuery#deriveCountQuery(String, String)} instead.
+	 * @deprecated use {@link DeclaredQuery#deriveCountQuery(String)} instead.
 	 */
 	@Deprecated
 	public static String createCountQueryFor(String originalQuery) {
@@ -582,7 +591,7 @@ public static String createCountQueryFor(String originalQuery) {
 	 * @param countProjection may be {@literal null}.
 	 * @return a query String to be used a count query for pagination. Guaranteed to be not {@literal null}.
 	 * @since 1.6
-	 * @deprecated use {@link DeclaredQuery#deriveCountQuery(String, String)} instead.
+	 * @deprecated use {@link DeclaredQuery#deriveCountQuery(String)} instead.
 	 */
 	@Deprecated
 	public static String createCountQueryFor(String originalQuery, @Nullable String countProjection) {

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/PartTreeJpaQueryIntegrationTests.java

@@ -30,6 +30,7 @@
 import java.util.Collection;
 import java.util.Date;
 import java.util.List;
+import java.util.Set;
 
 import org.hibernate.Version;
 import org.junit.jupiter.api.BeforeEach;
@@ -228,6 +229,13 @@ void errorsDueToMissingPropertyContainNameOfMethodAndInterface() throws Exceptio
 				.withMessageContaining("UserRepository"); // the repository
 	}
 
+	@Test // GH-3356
+	void allowsCollectionArgForCollectionProperty() throws Exception {
+
+		new PartTreeJpaQuery(getQueryMethod("findByAttributes", Set.class), entityManager);
+		new PartTreeJpaQuery(getQueryMethod("findByAttributes", String[].class), entityManager);
+	}
+
 	private void testIgnoreCase(String methodName, Object... values) throws Exception {
 
 		Class<?>[] parameterTypes = new Class[values.length];
@@ -297,6 +305,10 @@ interface UserRepository extends Repository<User, Integer> {
 
 		// Wrong property name
 		User findByNoSuchProperty(String x);
+
+		List<User> findByAttributes(Set<String> attributes);
+
+		List<User> findByAttributes(String... attributes);
 	}
 
 }