Replace jQAssistant with ArchUnit.

Author: meistermeier

etc/adr/general-discussion.adoc

@@ -238,16 +238,8 @@ core-[hidden]--->repository
 |===
 
 === Architecture validation
-The structure of this project can be explored as a Graph.
-We use https://jqassistant.org[jQAssistant] to verify our architecture during the build.
-Run the following two commands
-
-```
-./mvnw clean compile jqassistant:scan
-./mvnw jqassistant:server
-```
-
-and point your browser to http://localhost:7474.
+In favour of lightweight builds and JDK restriction of Neo4j, we moved away from https://jqassistant.org[jQAssistant] (still a great tool) and
+have now https://www.archunit.org[ArchUnit] in place.
 
 === `SimpleNeo4jRepository` initialization
 . `@EnableNeo4jRepositories` defines

etc/jqassistant/api.adoc

@@ -69,9 +69,9 @@
 
 	<properties>
 		<apiguardian.version>1.1.1</apiguardian.version>
+		<archunit.version>0.23.1</archunit.version>
 		<asciidoctor-maven-plugin.version>2.1.0</asciidoctor-maven-plugin.version>
 		<asciidoctorj-diagram.version>2.1.0</asciidoctorj-diagram.version>
-
 		<byte-buddy.version>1.11.0</byte-buddy.version>
 		<cdi>3.0.1</cdi>
 		<checkstyle.skip>${skipTests}</checkstyle.skip>
@@ -86,10 +86,6 @@
 		<java-module-name>spring.data.neo4j</java-module-name>
 		<java.version>17</java.version>
 		<jaxb.version>2.3.1</jaxb.version>
-		<jqassistant-dashboard-plugin.version>1.10.0</jqassistant-dashboard-plugin.version>
-		<jqassistant.plugin.git.version>1.8.0</jqassistant.plugin.git.version>
-		<jqassistant.plugin.version>1.10.1</jqassistant.plugin.version>
-		<jqassistant.version>1.10.1</jqassistant.version>
 		<junit-cc-testcontainer>2021.0.1</junit-cc-testcontainer>
 		<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
 		<maven-deploy-plugin.version>3.0.0-M1</maven-deploy-plugin.version>
@@ -230,6 +226,11 @@
 				<type>pom</type>
 				<scope>import</scope>
 			</dependency>
+			<dependency>
+				<groupId>com.tngtech.archunit</groupId>
+				<artifactId>archunit</artifactId>
+				<version>${archunit.version}</version>
+			</dependency>
 		</dependencies>
 	</dependencyManagement>
 
@@ -437,6 +438,11 @@
 				</exclusion>
 			</exclusions>
 		</dependency>
+		<dependency>
+			<groupId>com.tngtech.archunit</groupId>
+			<artifactId>archunit</artifactId>
+			<scope>test</scope>
+		</dependency>
 	</dependencies>
 
 	<repositories>
@@ -482,27 +488,6 @@
 						<expandEmptyElements>false</expandEmptyElements>
 					</configuration>
 				</plugin>
-				<plugin>
-					<groupId>com.buschmais.jqassistant</groupId>
-					<artifactId>jqassistant-maven-plugin</artifactId>
-					<version>${jqassistant.version}</version>
-					<dependencies>
-						<dependency>
-							<groupId>de.kontext-e.jqassistant.plugin</groupId>
-							<artifactId>jqassistant.plugin.git</artifactId>
-							<version>${jqassistant.plugin.git.version}</version>
-						</dependency>
-						<dependency>
-							<groupId>org.jqassistant.contrib.plugin</groupId>
-							<artifactId>jqassistant-dashboard-plugin</artifactId>
-							<version>${jqassistant-dashboard-plugin.version}</version>
-						</dependency>
-					</dependencies>
-					<configuration>
-						<rulesDirectory>etc/jqassistant</rulesDirectory>
-						<skip>${skipArchitectureTests}</skip>
-					</configuration>
-				</plugin>
 				<plugin>
 					<groupId>org.jacoco</groupId>
 					<artifactId>jacoco-maven-plugin</artifactId>
@@ -712,45 +697,6 @@
 					</archive>
 				</configuration>
 			</plugin>
-			<plugin>
-				<groupId>com.buschmais.jqassistant</groupId>
-				<artifactId>jqassistant-maven-plugin</artifactId>
-				<executions>
-					<execution>
-						<id>jqassistant-scan</id>
-						<phase>verify</phase>
-						<goals>
-							<goal>scan</goal>
-						</goals>
-						<configuration>
-							<scanProperties>
-								<jqassistant.plugin.jacoco.filename>jacoco.xml</jqassistant.plugin.jacoco.filename>
-							</scanProperties>
-							<scanIncludes>
-								<scanInclude>
-									<path>${project.basedir}/.git</path>
-								</scanInclude>
-								<scanInclude>
-									<path>${project.reporting.outputDirectory}/jacoco</path>
-								</scanInclude>
-							</scanIncludes>
-						</configuration>
-					</execution>
-					<execution>
-						<id>jqassistant-analyze</id>
-						<goals>
-							<goal>analyze</goal>
-						</goals>
-						<configuration>
-							<failOnSeverity>MINOR</failOnSeverity>
-							<groups>
-								<group>default</group>
-								<group>jqassistant-dashboard:Default</group>
-							</groups>
-						</configuration>
-					</execution>
-				</executions>
-			</plugin>
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-compiler-plugin</artifactId>

etc/jqassistant/index.adoc

@@ -152,46 +152,3 @@ There is no quality gate in place at the moment to ensure that the code/test rat
 We have some rather mild checkstyle rules in place, enforcing more or less default Java formatting rules.
 Your build will break on formatting errors or something like unused imports.
 
-[[building-SDN.jqassistant]]
-=== jQAssistant
-
-WARNING: Verification of those rules is off by default since Spring Data Neo4j 7, as the it requires JDK 17 to build.
-         The currently available version of jQAssistant does not run without several `--add-opens` arguments to the Java
-         module system and we won't apply this to the whole build as we must ensure that SDN itself does *not* need them.
-         +
-         To execute the rules during a build run the build like this:
-         +
-         +
-         `MAVEN_OPTS="--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED" ./mvnw -DskipArchitectureTests=false -DskipTests=true verify`
-
-
-We also use https://jqassistant.org[jQAssistant], a Neo4j-based tool, to verify some aspects of our architecture.
-The rules are described with Cypher and your build will break when they are violated:
-
-include::../../../../etc/jqassistant/index.adoc[leveloffset=4]
-
-[[building-SDN.jqassistant.database]]
-==== Accessing the jQAssistant database
-
-jQAssistant uses Neo4j to store information about a project.
-To access the database, please build the project as described above.
-When the build finishes, execute the following command:
-
-[source,console,subs="verbatim,attributes"]
-[[start-jqassistant]]
-.Start jQAssistant
-----
-$ MAVEN_OPTS="--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED" ./mvnw -DskipArchitectureTests=false jqassistant:server
-----
-
-Access the standard Neo4j browser at http://localhost:7474 and a dedicated jQA-Dashboard at http://localhost:7474/jqassistant/dashboard/.
-
-The scanning and analyzing can be triggered individually, without going through the full verify again:
-
-[source,console,subs="verbatim,attributes"]
-[[scan-with-jqassistant]]
-.Manually scan and analyze the main project
-----
-$ MAVEN_OPTS="--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED" ./mvnw -DskipArchitectureTests=false jqassistant:scan@jqassistant-scan
-$ MAVEN_OPTS="--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED" ./mvnw -DskipArchitectureTests=false jqassistant:analyze@jqassistant-analyze
-----