GH-1040 - NamedInterfaces.Builder now does not exclude all packages by default.

Polished NamedInterfaces.toString() for easier debugability.

Author: odrotbohm

spring-modulith-core/src/main/java/org/springframework/modulith/core/NamedInterfaces.java

@@ -267,6 +267,18 @@ boolean containsInExplicitInterface(Class<?> type) {
 				.anyMatch(NamedInterface::isNamed);
 	}
 
+	/*
+	 * (non-Javadoc)
+	 * @see java.lang.Object#toString()
+	 */
+	@Override
+	public String toString() {
+
+		return namedInterfaces.stream()
+				.map(NamedInterface::toString)
+				.collect(Collectors.joining(System.lineSeparator()));
+	}
+
 	private static NamedInterfaces of(NamedInterface interfaces) {
 		return new NamedInterfaces(List.of(interfaces));
 	}
@@ -315,7 +327,7 @@ public static class Builder {
 		 * @param basePackage must not be {@literal null}.
 		 */
 		private Builder(JavaPackage basePackage) {
-			this(basePackage, false, __ -> false, __ -> false);
+			this(basePackage, false, __ -> false, __ -> true);
 		}
 
 		private Builder(JavaPackage basePackage, boolean recursive,

spring-modulith-core/src/test/java/org/springframework/modulith/core/NamedInterfacesUnitTests.java

@@ -130,6 +130,18 @@ void createsNamedInterfacesFromRecursiveBuilder() {
 						"nested.b.second");
 	}
 
+	@Test // GH-1040
+	void doesNotExcludeAnyPackagesByDefault() {
+
+		var pkg = TestUtils.getPackage(RootType.class);
+
+		var interfaces = NamedInterfaces.builder(pkg)
+				.including(__ -> true)
+				.build();
+
+		assertThat(interfaces).hasSizeGreaterThan(1);
+	}
+
 	private static void assertInterfaceContains(NamedInterfaces interfaces, String name, Class<?>... types) {
 
 		var classNames = Arrays.stream(types).map(Class::getName).toArray(String[]::new);