GH-866 - Polishing.

Switch Oracle schema definition to make the serialized event column non null. Adapt test cases to always contain some content for the serialized event.

Original pull request: GH-868.

Author: odrotbohm

spring-modulith-events/spring-modulith-events-jdbc/src/main/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepository.java

@@ -400,7 +400,7 @@ private TargetEventPublication resultSetToPublication(ResultSet rs) throws SQLEx
 		var completionDate = rs.getTimestamp("COMPLETION_DATE");
 		var publicationDate = rs.getTimestamp("PUBLICATION_DATE").toInstant();
 		var listenerId = rs.getString("LISTENER_ID");
-		var serializedEvent = Optional.ofNullable(rs.getString("SERIALIZED_EVENT")).orElse("");
+		var serializedEvent = rs.getString("SERIALIZED_EVENT");
 
 		return new JdbcEventPublication(id, publicationDate, listenerId,
 				() -> serializer.deserialize(serializedEvent, eventClass),

spring-modulith-events/spring-modulith-events-jdbc/src/main/resources/schema-oracle.sql

@@ -3,7 +3,7 @@ CREATE TABLE IF NOT EXISTS EVENT_PUBLICATION (
   ID               VARCHAR2(36) NOT NULL,
   LISTENER_ID      VARCHAR2(512) NOT NULL,
   EVENT_TYPE       VARCHAR2(512) NOT NULL,
-  SERIALIZED_EVENT VARCHAR2(4000),
+  SERIALIZED_EVENT VARCHAR2(4000) NOT NULL,
   PUBLICATION_DATE TIMESTAMP(6) NOT NULL,
   COMPLETION_DATE  TIMESTAMP(6),
   CONSTRAINT EVENT_PUBLICATION_PK PRIMARY KEY(ID)

spring-modulith-events/spring-modulith-events-jdbc/src/test/java/org/springframework/modulith/events/jdbc/JdbcEventPublicationRepositoryIntegrationTests.java

@@ -353,10 +353,10 @@ void returnsSameEventInstanceFromPublication() {
 			var event = new Sample();
 
 			// Serialize to whatever
-			doReturn("").when(serializer).serialize(event);
+			doReturn("sample").when(serializer).serialize(event);
 
 			// Return fresh instances for every deserialization attempt
-			doAnswer(__ -> new Sample()).when(serializer).deserialize("", Sample.class);
+			doAnswer(__ -> new Sample()).when(serializer).deserialize("sample", Sample.class);
 
 			repository.create(TargetEventPublication.of(event, TARGET_IDENTIFIER));
 
@@ -476,7 +476,7 @@ class MariaDBWithNoDefinedSchemaName extends WithNoDefinedSchemaName {}
 
 	@WithMariaDB
 	class MariaDBWithDeleteCompletion extends WithDeleteCompletion {}
-	
+
 	// Oracle
 
 	@WithOracle
@@ -523,7 +523,7 @@ private static final class Sample {}
 	@ActiveProfiles("mssql")
 	@Retention(RetentionPolicy.RUNTIME)
 	@interface WithMssql {}
-	
+
 	@Nested
 	@ActiveProfiles("oracle")
 	@Retention(RetentionPolicy.RUNTIME)