PHP 8.2 | Generic/UnnecessaryFinalModifier: allow for readonly classes

Includes unit test.

Ref:
* https://wiki.php.net/rfc/readonly_classes

Author: jrfnl

src/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php

@@ -24,7 +24,6 @@
 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
-use PHP_CodeSniffer\Util\Tokens;
 
 class UnnecessaryFinalModifierSniff implements Sniff
 {
@@ -56,16 +55,13 @@ public function process(File $phpcsFile, $stackPtr)
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 
-        // Skip for-statements without body.
+        // Skip for statements without body.
         if (isset($token['scope_opener']) === false) {
             return;
         }
 
-        // Fetch previous token.
-        $prev = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($stackPtr - 1), null, true);
-
-        // Skip for non final class.
-        if ($prev === false || $tokens[$prev]['code'] !== T_FINAL) {
+        if ($phpcsFile->getClassProperties($stackPtr)['is_final'] === false) {
+            // This class is not final so we don't need to check it.
             return;
         }
 

src/Standards/Generic/Tests/CodeAnalysis/UnnecessaryFinalModifierUnitTest.inc

@@ -27,3 +27,8 @@ final class Bar_Foo {
     protected function foo() {}
     private function Bar() {}
 }
+
+final readonly class Foo_Bar {
+    public final function fooBar() {}
+    final protected function fool() {}
+}

src/Standards/Generic/Tests/CodeAnalysis/UnnecessaryFinalModifierUnitTest.php

@@ -45,6 +45,8 @@ public function getWarningList()
             12 => 1,
             15 => 1,
             18 => 1,
+            32 => 1,
+            33 => 1,
         ];
 
     }//end getWarningList()