phpstan 1.9 fixes (#445)

Author: staabm

src/Rules/QueryPlanAnalyzerRule.php

@@ -13,6 +13,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
@@ -65,24 +66,24 @@ public function processNode(Node $callLike, Scope $scope): array
             return [];
         }
 
-        $unsupportedMethod = true;
         $queryArgPosition = null;
         foreach ($this->classMethods as $classMethod) {
-            sscanf($classMethod, '%[^::]::%[^#]#%s', $className, $methodName, $queryArgPosition);
+            sscanf($classMethod, '%[^::]::%[^#]#%i', $className, $methodName, $queryArgPosition);
+            if (!is_string($className) || !is_string($methodName) || !is_int($queryArgPosition)) {
+                throw new ShouldNotHappenException('Invalid classMethod definition');
+            }
 
             if ($methodName === $methodReflection->getName() &&
                 ($methodReflection->getDeclaringClass()->getName() === $className || $methodReflection->getDeclaringClass()->isSubclassOf($className))) {
-                $unsupportedMethod = false;
                 break;
             }
         }
 
-        if ($unsupportedMethod) {
+        if ($queryArgPosition === null) {
             return [];
         }
 
         $args = $callLike->getArgs();
-
         if (!\array_key_exists($queryArgPosition, $args)) {
             return [];
         }

src/Rules/SyntaxErrorInPreparedStatementMethodRule.php

@@ -13,6 +13,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use staabm\PHPStanDba\QueryReflection\PlaceholderValidation;
@@ -68,6 +69,9 @@ public function processNode(Node $callLike, Scope $scope): array
         $unsupportedMethod = true;
         foreach ($this->classMethods as $classMethod) {
             sscanf($classMethod, '%[^::]::%s', $className, $methodName);
+            if (!is_string($className) || !is_string($methodName)) {
+                throw new ShouldNotHappenException('Invalid classMethod definition');
+            }
 
             if ($methodName === $methodReflection->getName() &&
                 ($methodReflection->getDeclaringClass()->getName() === $className || $methodReflection->getDeclaringClass()->isSubclassOf($className))) {

src/Rules/SyntaxErrorInQueryFunctionRule.php

@@ -10,6 +10,7 @@
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\MixedType;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
 use staabm\PHPStanDba\Tests\SyntaxErrorInQueryFunctionRuleTest;
@@ -57,18 +58,19 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $unsupportedFunction = true;
         $queryArgPosition = null;
         foreach ($this->functionNames as $functionName) {
-            sscanf($functionName, '%[^#]#%s', $functionName, $queryArgPosition);
+            sscanf($functionName, '%[^#]#%i', $functionName, $queryArgPosition);
+            if (!is_string($functionName) || !is_int($queryArgPosition)) {
+                throw new ShouldNotHappenException('Invalid functionName definition');
+            }
 
             if (strtolower($functionName) === strtolower($calledFunctionName)) {
-                $unsupportedFunction = false;
                 break;
             }
         }
 
-        if ($unsupportedFunction) {
+        if ($queryArgPosition === null) {
             return [];
         }
 

src/Rules/SyntaxErrorInQueryMethodRule.php

@@ -9,6 +9,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\MixedType;
 use staabm\PHPStanDba\QueryReflection\QueryReflection;
 use staabm\PHPStanDba\UnresolvableQueryException;
@@ -49,19 +50,20 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $unsupportedMethod = true;
         $queryArgPosition = null;
         foreach ($this->classMethods as $classMethod) {
-            sscanf($classMethod, '%[^::]::%[^#]#%s', $className, $methodName, $queryArgPosition);
+            sscanf($classMethod, '%[^::]::%[^#]#%i', $className, $methodName, $queryArgPosition);
+            if (!is_string($className) || !is_string($methodName) || !is_int($queryArgPosition)) {
+                throw new ShouldNotHappenException('Invalid classMethod definition');
+            }
 
             if ($methodName === $methodReflection->getName() &&
                 ($methodReflection->getDeclaringClass()->getName() === $className || $methodReflection->getDeclaringClass()->isSubclassOf($className))) {
-                $unsupportedMethod = false;
                 break;
             }
         }
 
-        if ($unsupportedMethod) {
+        if ($queryArgPosition === null) {
             return [];
         }