edits from review

Author: Ubuntu

etc/kayobe/ansible/get-cloud-facts.yml

@@ -1,5 +1,5 @@
 ---
-- name: Get facts for control host
+- name: Set facts for control host
   hosts: localhost
   gather_facts: true
   tasks:
@@ -9,15 +9,15 @@
           {{ 'genericswitch' in kolla_neutron_ml2_mechanism_drivers | default(false) }}
       when: kolla_neutron_ml2_mechanism_drivers
 
-- name: Get facts for seed node
+- name: Set facts for seed node
   hosts: seed
   gather_facts: true
   tasks:
     - name: Is there a dedicated seed node?
       ansible.builtin.set_fact:
         seed_node_is_vm: "{{ ansible_facts.virtualization_role == 'guest' }}"
 
-- name: Get facts
+- name: Set facts for all hosts
   hosts: all
   gather_facts: true
   tasks:
@@ -27,24 +27,11 @@
       timeout: 5
       ignore_errors: true
 
-    - name: Set internet connectivity fact
-      ansible.builtin.set_fact:
-        internet_connectivity: "{{ not successful_ping.failed }}"
-    - name: Get OS distribution
-      ansible.builtin.set_fact:
-        distribution: "{{ ansible_facts.distribution }}"
-
-
-    - name: Get OS distribution release
-      ansible.builtin.set_fact:
-        distribution_release: "{{ ansible_facts.distribution_release }}"
-
-
     - name: Get kernel version
       ansible.builtin.command: "uname -r"
       register: kernel_version
 
-    - name: Check if docker is installed
+    - name: Check if Docker is installed
       ansible.builtin.command: "which docker"
       register: docker_check
       failed_when: docker_check.rc not in [0]
@@ -56,11 +43,14 @@
       register: containers_list
       when: not docker_check.failed
 
-    - name: Check if hugepages enabled
+    - name: Set facts
       ansible.builtin.set_fact:
+        internet_connectivity: "{{ not successful_ping.failed }}"
+        distribution: "{{ ansible_facts.distribution }}"
+        distribution_release: "{{ ansible_facts.distribution_release }}"
         hugepages_enabled: "{{ 'hugepages' in ansible_facts.cmdline }}"
 
-- name: Gather Cloud Facts
+- name: Write cloud facts file
   hosts: localhost
   gather_facts: true
   tasks:
@@ -117,7 +107,7 @@
           pulp_tls_enabled: "{{ pulp_enable_tls }}"
           kolla_image_tags: "{{ kolla_image_tags }}"
           gpu_passthrough_enabled: "{{ gpu_group_map | length > 0 | bool }}"
-          vGPU_enabled: "{{ groups['vgpu'] | length > 0 | bool }}"
+          vgpu_enabled: "{{ groups['vgpu'] | length > 0 | bool }}"
           hugepages_enabled: "{{ hostvars | group_hostvars_by_var('hugepages_enabled') }}"
       ansible.builtin.copy:
         content: "{{ cloud_facts | to_nice_json(sort_keys=false) }}"