hide password in JSON output by default (#287)

Author: DiogoFerrao

internal/cmd/logme/credentials/create/create.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/logme/client"
 	logmeUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/logme/utils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/logme"
@@ -124,6 +125,9 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *logme.APICl
 func outputResult(p *print.Printer, model *inputModel, instanceLabel string, resp *logme.CredentialsResponse) error {
 	switch model.OutputFormat {
 	case print.JSONOutputFormat:
+		if !model.ShowPassword {
+			resp.Raw.Credentials.Password = utils.Ptr("hidden")
+		}
 		details, err := json.MarshalIndent(resp, "", "  ")
 		if err != nil {
 			return fmt.Errorf("marshal LogMe credentials: %w", err)

internal/cmd/mariadb/credentials/create/create.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/client"
 	mariadbUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/utils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/mariadb"
@@ -124,6 +125,9 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *mariadb.API
 func outputResult(p *print.Printer, model *inputModel, instanceLabel string, resp *mariadb.CredentialsResponse) error {
 	switch model.OutputFormat {
 	case print.JSONOutputFormat:
+		if !model.ShowPassword {
+			resp.Raw.Credentials.Password = utils.Ptr("hidden")
+		}
 		details, err := json.MarshalIndent(resp, "", "  ")
 		if err != nil {
 			return fmt.Errorf("marshal MariaDB credentials: %w", err)

internal/cmd/opensearch/credentials/create/create.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/opensearch/client"
 	opensearchUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/opensearch/utils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/opensearch"
@@ -124,6 +125,9 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *opensearch.
 func outputResult(p *print.Printer, model *inputModel, instanceLabel string, resp *opensearch.CredentialsResponse) error {
 	switch model.OutputFormat {
 	case print.JSONOutputFormat:
+		if !model.ShowPassword {
+			resp.Raw.Credentials.Password = utils.Ptr("hidden")
+		}
 		details, err := json.MarshalIndent(resp, "", "  ")
 		if err != nil {
 			return fmt.Errorf("marshal OpenSearch credentials: %w", err)

internal/cmd/rabbitmq/credentials/create/create.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client"
 	rabbitmqUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/rabbitmq"
@@ -124,6 +125,9 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *rabbitmq.AP
 func outputResult(p *print.Printer, model *inputModel, instanceLabel string, resp *rabbitmq.CredentialsResponse) error {
 	switch model.OutputFormat {
 	case print.JSONOutputFormat:
+		if !model.ShowPassword {
+			resp.Raw.Credentials.Password = utils.Ptr("hidden")
+		}
 		details, err := json.MarshalIndent(resp, "", "  ")
 		if err != nil {
 			return fmt.Errorf("marshal RabbitMQ credentials: %w", err)

internal/cmd/redis/credentials/create/create.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/redis/client"
 	redisUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/redis/utils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/redis"
@@ -124,6 +125,9 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *redis.APICl
 func outputResult(p *print.Printer, model *inputModel, instanceLabel string, resp *redis.CredentialsResponse) error {
 	switch model.OutputFormat {
 	case print.JSONOutputFormat:
+		if !model.ShowPassword {
+			resp.Raw.Credentials.Password = utils.Ptr("hidden")
+		}
 		details, err := json.MarshalIndent(resp, "", "  ")
 		if err != nil {
 			return fmt.Errorf("marshal Redis credentials: %w", err)