Skip to content

Conversation

@opbot-xd
Copy link
Contributor

@opbot-xd opbot-xd commented Dec 4, 2025

Progresses #8755 (partial).

Description

What is the purpose of this pull request?

This pull request:

  • Migrates @stdlib/utils/move-property to @stdlib/object/move-property as the first package migration in RFC [RFC]: migrate utils packages to object (tracking issue) #8755
  • Adds the new @stdlib/object/move-property package with updated namespace references
  • Removes moveProperty from the @stdlib/utils namespace
  • Removes the original @stdlib/utils/move-property package

Note: This PR addresses only the utils/move-property => object/move-property migration. The remaining 10 packages listed in RFC #8755 will be handled in separate PRs as per the stdlib contributing guidelines for package migrations.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This PR follows the same approach as #8736 which was used as a reference for the migration process.

Breaking Changes:

  • moveProperty is no longer accessible via require('@stdlib/utils').moveProperty
  • @stdlib/utils/move-property package is removed

Migration: Users should update their require/import paths from @stdlib/utils/move-property to @stdlib/object/move-property.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used AI assistance for researching the stdlib codebase structure and understanding the package migration guidelines. The actual code changes were authored following the stdlib moving packages documentation and #8736 as reference.


@stdlib-js/reviewers

Ref: stdlib-js#8755

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
This commit removes the `moveProperty` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `moveProperty`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: stdlib-js#8755
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 4, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 4, 2025

Coverage Report

Package Statements Branches Functions Lines
object/move-property $\color{green}120/120$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}120/120$
$\color{green}+0.00%$
utils $\color{red}45456/61696$
$\color{green}+0.00%$
$\color{red}759/803$
$\color{green}+0.00%$
$\color{red}23/509$
$\color{green}+0.00%$
$\color{red}45456/61696$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@opbot-xd
Copy link
Contributor Author

opbot-xd commented Dec 4, 2025

The lint check failure appears to be related to pre-existing OOM issues when linting
the large utils/docs/types/index.d.ts file, not caused by these changes.

Examples run successfully locally.

This commit removes `@stdlib/utils/move-property` in favor of
`@stdlib/object/move-property`.

BREAKING CHANGE: remove `utils/move-property`

To migrate, users should update their require/import paths to use
`@stdlib/object/move-property` which provides the same API and implementation.

Ref: stdlib-js#8755
@opbot-xd opbot-xd force-pushed the migrate-move-property branch from 86e5546 to f7d128e Compare December 4, 2025 12:29
@stdlib-bot
Copy link
Contributor

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@kgryte kgryte added release: Major Breaking change requiring a new major release. and removed Needs Review A pull request which needs code review. labels Dec 5, 2025
import writablePropertySymbols = require( '@stdlib/utils/writable-property-symbols' );
import writablePropertySymbolsIn = require( '@stdlib/utils/writable-property-symbols-in' );
import zip = require( '@stdlib/utils/zip' );
import any = require('@stdlib/utils/any');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these style changes should not have been made.

* @see {@link module:@stdlib/utils/any}
*/
setReadOnly( utils, 'any', require( '@stdlib/utils/any' ) );
setReadOnly(utils, 'any', require( '@stdlib/utils/any' ));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment. None of these style changes should have been made.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not have been made in this commit.

@kgryte
Copy link
Member

kgryte commented Dec 5, 2025

@opbot-xd Thank you for looking into this. However, I am going to go ahead and close this PR, as your changes include several style changes which are not desired. Feel free to submit another PR which avoids such changes.

@kgryte kgryte closed this Dec 5, 2025
@kgryte kgryte changed the title feat: migrate utils/move-property to object/move-property feat!: migrate utils/move-property to object/move-property Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants