fixes

Author: psteinroe

.github/workflows/pull_request.yml

@@ -50,7 +50,7 @@ jobs:
         run: |
           cargo fmt --all --check
           taplo format --check
-          biome ci
+          biome format
 
   actionlint:
     name: Lint GitHub Actions
@@ -91,10 +91,15 @@ jobs:
           cache-base: main
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Setup Biome
+        uses: biomejs/setup-biome@v2
+        with:
+          version: latest
       - name: Run Lints
         run: |
           cargo clippy
           cargo run -p rules_check
+          biome lint
 
   test:
     name: Test

crates/pglt_workspace/src/configuration.rs

@@ -241,7 +241,7 @@ pub fn strip_jsonc_comments(jsonc_input: &str) -> String {
                         json_output.push(last_char);
                     }
                 } else {
-                    json_output.push_str(" ");
+                    json_output.push(' ');
                 }
                 last_char = Some(cur_char);
             }

crates/pglt_workspace/src/workspace_types.rs

@@ -262,7 +262,7 @@ fn schema_object_type<'a>(
     let has_defaults = schema
         .metadata
         .as_ref()
-        .map_or(false, |metadata| metadata.default.is_some());
+        .is_some_and(|metadata| metadata.default.is_some());
 
     (ts_type, is_nullable || has_defaults, description)
 }
@@ -375,7 +375,7 @@ pub fn generate_type<'a>(
             let current_module = AnyJsDeclaration::from(
                 make::ts_interface_declaration(
                     make::token(T![interface]),
-                    make::ts_identifier_binding(make::ident(name)).into(),
+                    make::ts_identifier_binding(make::ident(name)),
                     make::token(T!['{']),
                     make::ts_type_member_list(members),
                     make::token(T!['}']),
@@ -392,7 +392,7 @@ pub fn generate_type<'a>(
             let current_module = AnyJsDeclaration::from(
                 make::ts_type_alias_declaration(
                     make::token(T![type]),
-                    make::ts_identifier_binding(make::ident(name)).into(),
+                    make::ts_identifier_binding(make::ident(name)),
                     make::token(T![=]),
                     ts_type,
                 )

packages/@pglt/backend-jsonrpc/src/transport.ts

@@ -126,6 +126,7 @@ export class Transport {
 	 * @param params Parameters object the remote method should be called with
 	 * @return Promise resolving with the value returned by the remote method, or rejecting with an RPC error if the remote call failed
 	 */
+	// biome-ignore lint/suspicious/noExplicitAny: if i change it to Promise<unknown> typescript breaks
 	request(method: string, params: unknown): Promise<any> {
 		return new Promise((resolve, reject) => {
 			const id = this.nextRequestId++;

packages/@pglt/pglt/scripts/generate-packages.mjs

@@ -22,7 +22,7 @@ async function downloadSchema(releaseTag, githubToken) {
 	const response = await fetch(assetUrl.trim(), {
 		headers: {
 			Authorization: `token ${githubToken}`,
-			Accept: `application/octet-stream`,
+			Accept: "application/octet-stream",
 		},
 	});
 
@@ -46,7 +46,7 @@ async function downloadBinary(platform, arch, os, releaseTag, githubToken) {
 	const response = await fetch(assetUrl.trim(), {
 		headers: {
 			Authorization: `token ${githubToken}`,
-			Accept: `application/octet-stream`,
+			Accept: "application/octet-stream",
 		},
 	});
 
@@ -179,15 +179,15 @@ function copySchemaToNativePackage(platform, arch) {
 	const buildName = getBuildName(platform, arch);
 	const packageRoot = resolve(PACKAGES_PGLT_ROOT, buildName);
 
-	const schemaSrc = resolve(PGLT_ROOT, `schema.json`);
-	const schemaTarget = resolve(packageRoot, `schema.json`);
+	const schemaSrc = resolve(PGLT_ROOT, "schema.json");
+	const schemaTarget = resolve(packageRoot, "schema.json");
 
 	if (!fs.existsSync(schemaSrc)) {
 		console.error(`schema.json not found at: ${schemaSrc}`);
 		process.exit(1);
 	}
 
-	console.info(`Copying schema.json`);
+	console.info("Copying schema.json");
 	fs.copyFileSync(schemaSrc, schemaTarget);
 	fs.chmodSync(schemaTarget, 0o666);
 }
@@ -224,7 +224,7 @@ function getVersion(releaseTag, isPrerelease) {
 
 (async function main() {
 	const githubToken = process.env.GITHUB_TOKEN;
-	let releaseTag = process.env.RELEASE_TAG;
+	const releaseTag = process.env.RELEASE_TAG;
 	assert(githubToken, "GITHUB_TOKEN not defined!");
 	assert(releaseTag, "RELEASE_TAG not defined!");
 

xtask/codegen/src/generate_bindings.rs

@@ -183,7 +183,7 @@ pub fn generate_bindings(mode: Mode) -> Result<()> {
                         make::token(T!['}']),
                     ),
                     make::token(T![from]),
-                    make::js_module_source(make::js_string_literal("./transport")).into(),
+                    make::js_module_source(make::js_string_literal("./transport")),
                 )
                 .with_type_token(make::token(T![type]))
                 .build(),
@@ -316,7 +316,7 @@ pub fn generate_bindings(mode: Mode) -> Result<()> {
         AnyJsExportClause::AnyJsDeclarationClause(AnyJsDeclarationClause::TsTypeAliasDeclaration(
             make::ts_type_alias_declaration(
                 make::token(T![type]),
-                make::ts_identifier_binding(make::ident("Configuration")).into(),
+                make::ts_identifier_binding(make::ident("Configuration")),
                 make::token(T![=]),
                 AnyTsType::TsReferenceType(
                     make::ts_reference_type(AnyTsName::JsReferenceIdentifier(
@@ -335,7 +335,7 @@ pub fn generate_bindings(mode: Mode) -> Result<()> {
         AnyJsExportClause::AnyJsDeclarationClause(AnyJsDeclarationClause::TsInterfaceDeclaration(
             make::ts_interface_declaration(
                 make::token(T![interface]),
-                make::ts_identifier_binding(make::ident("Workspace")).into(),
+                make::ts_identifier_binding(make::ident("Workspace")),
                 make::token(T!['{']),
                 make::ts_type_member_list(member_definitions),
                 make::token(T!['}']),