Merge pull request #742 from superannotateai/FRIDAY_3530

Fix annotation name validation

Author: VaghinakDev

src/superannotate/lib/core/entities/items.py

@@ -1,3 +1,4 @@
+from typing import List
 from typing import Optional
 
 from lib.core.entities.base import BaseItemEntity
@@ -26,7 +27,7 @@ class Config:
 
 
 class MultiModalItemEntity(BaseItemEntity):
-    categories: Optional[list[MultiModalItemCategoryEntity]]
+    categories: Optional[List[MultiModalItemCategoryEntity]]
 
     class Config:
         extra = Extra.ignore

src/superannotate/lib/core/usecases/annotations.py

@@ -1861,7 +1861,7 @@ def validate_project_type(self):
 
     @staticmethod
     def _validate_json(json_data: dict) -> bool:
-        return "metadata" in json_data and "name" in json_data["metadata"]
+        return isinstance(json_data.get("metadata", {}).get("name"), str)
 
     def list_items(
         self, folder: FolderEntity, item_names: List[str]
@@ -2021,7 +2021,6 @@ def categorization_enabled(self):
 
     def execute(self):
         if self.is_valid():
-            # TODO check categories status in the project
             categorization_enabled = self.categorization_enabled
             serialized_original_folder_map = {}
             failed, skipped, uploaded = [], [], []
@@ -2033,7 +2032,7 @@ def execute(self):
                     folder_name = annotation["metadata"].get("folder_name", "").strip()
                     serialized_folder_name = self.serialize_folder_name(folder_name)
                     distributed_items[serialized_folder_name][
-                        annotation["metadata"]["name"]
+                        str(annotation["metadata"]["name"])
                     ] = annotation
                     valid_items_count += 1
                     if serialized_folder_name not in serialized_original_folder_map:

tests/data_set/multimodal/annotations/jsonl/form1_with_categories.jsonl

@@ -1,3 +1,3 @@
-{"metadata":  {"folder_name": "test_folder", "name":  "0123456789101112", "item_category":  "category1"}, ",data": {"component_id_0":  {"value":  ["Partially complete, needs review"]}, "component_id_1": {"value":  "I am a text input 001"}, "component_id_2": {"value": 11}}}
+{"metadata":  {"folder_name": "test_folder", "name":  "0123456789101112", "item_category":  "category1"}, "data": {"component_id_0":  {"value":  ["Partially complete, needs review"]}, "component_id_1": {"value":  "I am a text input 001"}, "component_id_2": {"value": 11}}}
 {"metadata":  {"folder_name":  " test_Folder", "name": "item_002", "item_category":  "category2"}, "data": {"component_id_0":  {"value":  ["Partially complete, needs review", "Incomplete"]}, "component_id_1": {"value":  "I am a text input 002"}, "component_id_2": {"value":  33}}}
 {"metadata":  {"folder_name":  "Test_Folder ", "name": "item_003", "item_category":  "category3"}, "data": {"component_id_0":  {"value": ["Partially complete, needs review", "Incomplete"]}, "component_id_1": {"value":  "I am a text input 003"}, "component_id_2": {"value":  33}}}

tests/integration/annotations/test_upload_annotations.py

@@ -228,3 +228,19 @@ def test_upload_with_categories(self):
                 f"{self.PROJECT_NAME}/test_folder", data_spec="multimodal"
             )
             assert len(annotations) == 3
+
+    def test_upload_with_integer_names(self):
+        data = []
+        with open(self.JSONL_ANNOTATIONS_WITH_CATEGORIES_PATH) as f:
+            for i, line in enumerate(f):
+                _data = json.loads(line)
+                _data["metadata"]["name"] = i
+                data.append(_data)
+            res = sa.upload_annotations(
+                f"{self.PROJECT_NAME}", annotations=data, data_spec="multimodal"
+            )
+            assert len(res["failed"]) == 3
+            annotations = sa.get_annotations(
+                f"{self.PROJECT_NAME}/test_folder", data_spec="multimodal"
+            )
+            assert len(annotations) == 0