fix(no-unused-props): resolve false positives on props with default values or $bindable usage (#1146)

Author: baseballyama

.changeset/few-singers-marry.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix(no-unused-props): resolve false positives on props with default values or $bindable usage

packages/eslint-plugin-svelte/src/rules/no-unused-props.ts

@@ -369,10 +369,17 @@ export default createRule('no-unused-props', {
 				if (node.id.type === 'ObjectPattern') {
 					usedProps = getUsedPropertiesFromPattern(node.id);
 					if (usedProps.size === 0) return;
-					const identifiers = node.id.properties
-						.filter((p): p is TSESTree.Property => p.type === 'Property')
-						.map((p) => p.value)
-						.filter((v): v is TSESTree.Identifier => v.type === 'Identifier');
+					const identifiers: TSESTree.Identifier[] = [];
+					for (const p of node.id.properties) {
+						if (p.type !== 'Property') {
+							continue;
+						}
+						if (p.value.type === 'Identifier') {
+							identifiers.push(p.value);
+						} else if (p.value.type === 'AssignmentPattern' && p.value.left.type === 'Identifier') {
+							identifiers.push(p.value.left);
+						}
+					}
 					for (const identifier of identifiers) {
 						const paths = getUsedNestedPropertyNames(identifier);
 						usedPaths.push(...paths.map((path) => [identifier.name, ...path]));

packages/eslint-plugin-svelte/tests/fixtures/rules/no-unused-props/valid/bindable-input.svelte

@@ -0,0 +1,9 @@
+<script lang="ts">
+	interface Props {
+		selected: { value: string };
+	}
+
+	let { selected = $bindable() }: Props = $props();
+</script>
+
+<input type="text" bind:value={selected.value} />

packages/eslint-plugin-svelte/tests/fixtures/rules/no-unused-props/valid/default-value-input.svelte

@@ -0,0 +1,14 @@
+<script lang="ts">
+	interface Props {
+		newTaskAttributes: { attribute: number; attribute2: string };
+	}
+
+	const { newTaskAttributes = { attribute: 0, attribute2: '' } }: Props = $props();
+</script>
+
+<div class="col-span-full">
+	<div>
+		{newTaskAttributes.attribute}
+		{newTaskAttributes.attribute2}
+	</div>
+</div>