fix: Not reporting mailto: and other unusual schema addresses in no-nmavigation-without-resolve (and its deprecated versions) (#1313)

Author: marekdedic

.changeset/six-pugs-camp.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix: Not reporting mailto: and other unusual schema addresses in no-nmavigation-without-resolve (and its deprecated versions)

packages/eslint-plugin-svelte/src/rules/no-goto-without-base.ts

@@ -71,8 +71,7 @@ function checkTemplateLiteral(
 }
 
 function checkLiteral(context: RuleContext, path: TSESTree.Literal): void {
-	const absolutePathRegex = /^(?:[+a-z]+:)?\/\//i;
-	if (!absolutePathRegex.test(path.value?.toString() ?? '')) {
+	if (!/^[+a-z]*:/i.test(path.value?.toString() ?? '')) {
 		context.report({ loc: path.loc, messageId: 'isNotPrefixedWithBasePath' });
 	}
 }

packages/eslint-plugin-svelte/src/rules/no-navigation-without-base.ts

@@ -268,7 +268,7 @@ function templateLiteralIsAbsolute(url: TSESTree.TemplateLiteral): boolean {
 }
 
 function urlValueIsAbsolute(url: string): boolean {
-	return url.includes('://');
+	return /^[+a-z]*:/i.test(url);
 }
 
 function expressionIsFragment(url: AST.SvelteLiteral | TSESTree.Expression): boolean {

packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts

@@ -282,7 +282,7 @@ function templateLiteralIsAbsolute(url: TSESTree.TemplateLiteral): boolean {
 }
 
 function urlValueIsAbsolute(url: string): boolean {
-	return url.includes('://');
+	return /^[+a-z]*:/i.test(url);
 }
 
 function expressionIsFragment(url: AST.SvelteLiteral | TSESTree.Expression): boolean {

packages/eslint-plugin-svelte/tests/fixtures/rules/no-goto-without-base/invalid/no-base01-errors.yaml

@@ -2,3 +2,7 @@
   line: 4
   column: 7
   suggestions: null
+- message: Found a goto() call with a url that isn't prefixed with the base path.
+  line: 5
+  column: 7
+  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-goto-without-base/invalid/no-base01-input.svelte

@@ -2,4 +2,5 @@
 	import { goto } from '$app/navigation';
 
 	goto('/foo');
+	goto('/user:42');
 </script>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-goto-without-base/valid/absolute-uri01-input.svelte

@@ -3,4 +3,6 @@
 
 	goto('http://localhost/foo/');
 	goto('https://localhost/foo/');
+	goto('mailto:user@example.com');
+	goto('tel:+123456789');
 </script>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-base/invalid/link-no-base01-errors.yaml

@@ -14,3 +14,7 @@
   line: 7
   column: 9
   suggestions: null
+- message: Found a link with a url that isn't prefixed with the base path.
+  line: 8
+  column: 9
+  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-base/invalid/link-no-base01-input.svelte

@@ -5,3 +5,4 @@
 <a href={'/foo'}>Click me!</a>
 <a href={'/' + 'foo'}>Click me!</a>
 <a href={value}>Click me!</a>
+<a href={'/user:42'}>Click me!</a>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-base/invalid/link-with-fragment01-errors.yaml

@@ -14,3 +14,7 @@
   line: 7
   column: 9
   suggestions: null
+- message: Found a link with a url that isn't prefixed with the base path.
+  line: 8
+  column: 9
+  suggestions: null