Skip to content

Commit 27cf677

Browse files
baseballyamabaseballyama
authored
fix(no-navigation-without-resolve): improve error messages (#1377)
1 parent 57ccf95 commit 27cf677

18 files changed

+41
-36
lines changed

‎.changeset/tame-walls-sleep.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'eslint-plugin-svelte': patch
3+
---
4+
5+
fix(no-navigation-without-resolve): improve error messages

‎packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ export default createRule('no-navigation-without-resolve', {
3535
}
3636
],
3737
messages: {
38-
gotoWithoutResolve: "Found a goto() call with a url that isn't resolved.",
39-
linkWithoutResolve: "Found a link with a url that isn't resolved.",
40-
pushStateWithoutResolve: "Found a pushState() call with a url that isn't resolved.",
41-
replaceStateWithoutResolve: "Found a replaceState() call with a url that isn't resolved."
38+
gotoWithoutResolve: 'Unexpected goto() call without resolve().',
39+
linkWithoutResolve: 'Unexpected href link without resolve().',
40+
pushStateWithoutResolve: 'Unexpected pushState() call without resolve().',
41+
replaceStateWithoutResolve: 'Unexpected replaceState() call without resolve().'
4242
},
4343
type: 'suggestion',
4444
conditions: [

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-aliased01-errors.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
- message: Found a goto() call with a url that isn't resolved.
1+
- message: Unexpected goto() call without resolve().
22
line: 4
33
column: 8
44
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-namespace-import01-errors.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
- message: Found a goto() call with a url that isn't resolved.
1+
- message: Unexpected goto() call without resolve().
22
line: 4
33
column: 18
44
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-partial-resolve01-errors.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
- message: Found a goto() call with a url that isn't resolved.
1+
- message: Unexpected goto() call without resolve().
22
line: 5
33
column: 7
44
suggestions: null
5-
- message: Found a goto() call with a url that isn't resolved.
5+
- message: Unexpected goto() call without resolve().
66
line: 6
77
column: 7
88
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-without-resolve01-errors.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
- message: Found a goto() call with a url that isn't resolved.
1+
- message: Unexpected goto() call without resolve().
22
line: 6
33
column: 7
44
suggestions: null
5-
- message: Found a goto() call with a url that isn't resolved.
5+
- message: Unexpected goto() call without resolve().
66
line: 7
77
column: 7
88
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-partial-resolve01-errors.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
- message: Found a link with a url that isn't resolved.
1+
- message: Unexpected href link without resolve().
22
line: 7
33
column: 9
44
suggestions: null
5-
- message: Found a link with a url that isn't resolved.
5+
- message: Unexpected href link without resolve().
66
line: 8
77
column: 9
88
suggestions: null
9-
- message: Found a link with a url that isn't resolved.
9+
- message: Unexpected href link without resolve().
1010
line: 9
1111
column: 9
1212
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-with-fragment01-errors.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
- message: Found a link with a url that isn't resolved.
1+
- message: Unexpected href link without resolve().
22
line: 5
33
column: 10
44
suggestions: null
5-
- message: Found a link with a url that isn't resolved.
5+
- message: Unexpected href link without resolve().
66
line: 6
77
column: 9
88
suggestions: null
9-
- message: Found a link with a url that isn't resolved.
9+
- message: Unexpected href link without resolve().
1010
line: 7
1111
column: 9
1212
suggestions: null
13-
- message: Found a link with a url that isn't resolved.
13+
- message: Unexpected href link without resolve().
1414
line: 8
1515
column: 9
1616
suggestions: null
17-
- message: Found a link with a url that isn't resolved.
17+
- message: Unexpected href link without resolve().
1818
line: 9
1919
column: 9
2020
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-without-resolve01-errors.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
- message: Found a link with a url that isn't resolved.
1+
- message: Unexpected href link without resolve().
22
line: 5
33
column: 10
44
suggestions: null
5-
- message: Found a link with a url that isn't resolved.
5+
- message: Unexpected href link without resolve().
66
line: 6
77
column: 9
88
suggestions: null
9-
- message: Found a link with a url that isn't resolved.
9+
- message: Unexpected href link without resolve().
1010
line: 7
1111
column: 9
1212
suggestions: null
13-
- message: Found a link with a url that isn't resolved.
13+
- message: Unexpected href link without resolve().
1414
line: 8
1515
column: 9
1616
suggestions: null
17-
- message: Found a link with a url that isn't resolved.
17+
- message: Unexpected href link without resolve().
1818
line: 9
1919
column: 9
2020
suggestions: null

‎packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/pushState-aliased01-errors.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
- message: Found a pushState() call with a url that isn't resolved.
1+
- message: Unexpected pushState() call without resolve().
22
line: 4
33
column: 8
44
suggestions: null

0 commit comments

Comments
 (0)