fix(prefer-const): corrections

- Removed unnecessary if branches
- Updated tests cases
- Since we are now using the default implementation of the rule, there's
  no need to keep the original tests, since the default rule is already
  tested.
- Removed unnecessary test cases

Author: mikededo

packages/eslint-plugin-svelte/package.json

@@ -30,7 +30,7 @@
     "cover": "nyc --reporter=lcov pnpm run test",
     "debug": "pnpm run mocha \"tests/src/**/*.ts\" --reporter dot --timeout 60000",
     "lint": "run-p lint:*",
-    "lint:fix": "pnpm run lint:es --fix",
+    "lint-fix": "pnpm run lint:es --fix",
     "lint:es": "eslint --cache .",
     "mocha": "pnpm run ts ./node_modules/mocha/bin/mocha.js",
     "new": "pnpm run ts ./tools/new-rule.ts",

packages/eslint-plugin-svelte/src/rules/prefer-const.ts

@@ -5,35 +5,24 @@ import { defineWrapperListener, getCoreRule } from '../utils/eslint-core';
 
 const coreRule = getCoreRule('prefer-const');
 
-type Declaration = TSESTree.Expression;
-
 /**
  * Finds and returns the callee of a declaration node within variable declarations or object patterns.
  */
-function findDeclarationCallee(node: Declaration) {
+function findDeclarationCallee(node: TSESTree.Expression) {
 	const { parent } = node;
 	if (parent.type === 'VariableDeclarator' && parent.init?.type === 'CallExpression') {
 		return parent.init.callee;
 	}
 
-	if (
-		parent.type === 'Property' &&
-		parent.parent.type === 'ObjectPattern' &&
-		parent.parent.parent.type === 'VariableDeclarator' &&
-		parent.parent.parent.init?.type === 'CallExpression'
-	) {
-		return parent.parent.parent.init.callee;
-	}
-
 	return null;
 }
 
 /**
  * Determines if a declaration should be skipped in the const preference analysis.
  * Specifically checks for Svelte's state management utilities ($state, $props, $derived).
  */
-function shouldSkipDeclaration(declaration: Declaration | null) {
-	if (!declaration || !declaration.parent) {
+function shouldSkipDeclaration(declaration: TSESTree.Expression | null) {
+	if (!declaration) {
 		return false;
 	}
 
@@ -60,7 +49,7 @@ function shouldSkipDeclaration(declaration: Declaration | null) {
 	if (
 		callee.object.name === '$state' &&
 		callee.property.type === 'Identifier' &&
-		callee.property.name === 'frozen'
+		callee.property.name === 'raw'
 	) {
 		return true;
 	}

packages/eslint-plugin-svelte/tests/fixtures/rules/prefer-const/invalid/test01-input.svelte

@@ -2,9 +2,10 @@
 	let { prop1, prop2 } = $props();
 	let zero = 0;
 	let state = $state(0);
-	let frozen = $state.frozen(0);
+	let raw = $state.raw(0);
 	let doubled = state * 2;
 	let derived = $derived(state * 2);
 	let calculated = calc();
 	let derivedBy = $derived.by(calc());
+	let noInit;
 </script>

packages/eslint-plugin-svelte/tests/fixtures/rules/prefer-const/invalid/test01-output.svelte

@@ -2,9 +2,10 @@
 	let { prop1, prop2 } = $props();
 	const zero = 0;
 	let state = $state(0);
-	let frozen = $state.frozen(0);
+	let raw = $state.raw(0);
 	const doubled = state * 2;
 	let derived = $derived(state * 2);
 	const calculated = calc();
 	let derivedBy = $derived.by(calc());
+	let noInit;
 </script>