Exclude test libraries from clang-tidy

Author: woodfell

cc/defs2.bzl

@@ -298,7 +298,7 @@ def swift_add_library(**kwargs):
 
     is_test_library = level == "test"
 
-    kwargs["tags"] = [LIBRARY, "internal" if level == "test" else level] + (["portable"] if portable else []) + kwargs.get("tags", [])
+    kwargs["tags"] = [LIBRARY, "internal" if level == "test" else level] + (["portable"] if portable else []) + kwargs.get("tags", []) + (["test_library"] if is_test_library else [])
     if level == "test":
       kwargs["target_compatible_with"] = kwargs.get("target_compatible_with", []) + _test_compatible_with()
     else:

clang_tidy/clang_tidy.bzl

@@ -1,6 +1,6 @@
 load("@bazel_tools//tools/build_defs/cc:action_names.bzl", "ACTION_NAMES")
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")
-load("//cc:defs.bzl", "BINARY", "LIBRARY")
+load("//cc:defs.bzl", "BINARY", "LIBRARY", "TEST_LIBRARY")
 load("//cc_files:get_cc_files.bzl", "get_cc_srcs")
 
 def _flatten(input_list):
@@ -150,6 +150,9 @@ def _clang_tidy_aspect_impl(target, ctx):
     if not LIBRARY in tags and not BINARY in tags:
         return []
 
+    if TEST_LIBRARY in tags:
+      return []
+
     srcs = get_cc_srcs(ctx)
 
     wrapper = ctx.attr._clang_tidy_wrapper.files_to_run