Fix API Collection icon rendering for external references

Implements detection of API Collections in external references by checking for task groups in LinkDestinationSummary. Articles with task groups are treated as API Collections and get collectionGroup role for correct icon display. Removes test skip to enable validation of the fix.

rdar://135837611

Author: RalucaP

Sources/SwiftDocC/Infrastructure/Link Resolution/ExternalPathHierarchyResolver.swift

@@ -165,7 +165,7 @@ extension LinkDestinationSummary {
 
     /// Create a topic render render reference for this link summary and its content variants.
     func makeTopicRenderReference() -> TopicRenderReference {
-        let (kind, role) = DocumentationContentRenderer.renderKindAndRole(kind, semantic: nil)
+        let (kind, role) = DocumentationContentRenderer.renderKindAndRole(kind, semantic: nil, linkSummary: self)
 
         var titleVariants = VariantCollection(defaultValue: title)
         var abstractVariants = VariantCollection(defaultValue: abstract ?? [])

Sources/SwiftDocC/Model/Rendering/DocumentationContentRenderer.swift

@@ -247,7 +247,7 @@ public class DocumentationContentRenderer {
         return true
     }
 
-    static func renderKindAndRole(_ kind: DocumentationNode.Kind?, semantic: Semantic?) -> (RenderNode.Kind, String) {
+    static func renderKindAndRole(_ kind: DocumentationNode.Kind?, semantic: Semantic? = nil, linkSummary: LinkDestinationSummary? = nil) -> (RenderNode.Kind, String) {
         guard let kind else {
             return (.article, role(for: .article).rawValue)
         }
@@ -270,6 +270,9 @@ public class DocumentationContentRenderer {
         default:
             if let article = semantic as? Article {
                 return (.article, roleForArticle(article, nodeKind: kind).rawValue)
+            } else if kind == .article, let summary = linkSummary, summary.taskGroups != nil {
+                // For external references: Articles with task groups are API Collections and should have collectionGroup role
+                return (.article, Self.role(for: .collectionGroup).rawValue)
             } else {
                 return (.article, role)
             }

Tests/SwiftDocCTests/Rendering/DocumentationContentRendererTests.swift

@@ -133,8 +133,6 @@ class DocumentationContentRendererTests: XCTestCase {
     }
 
     func testRenderKindAndRoleForAPICollection() throws {
-        throw XCTSkip("TDD: Temporarily disabled while implementing API Collection icon fix")
-
         // Articles with task groups should get collectionGroup role for external references
         let apiCollectionSummary = LinkDestinationSummary(
             kind: .article,