Fix Calendar Typos in Foundation Essentials #1594
Open
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itingliu
reviewed
Nov 12, 2025
| var update = updatedDate | ||
| var prev: Date | ||
| repeat { | ||
| prev = udate |
Contributor
There was a problem hiding this comment.
I personally prefer not having a particular commit just to change internal variable names, even if they're not perfect. I'd only do so when there's a strong reason for changing them, or do it as part of a bug fix or feature work. This way we still have access to the commit history.
Contributor
Author
There was a problem hiding this comment.
I actually combined multiple commits into a single PR to address this concern. These are all typos in Calendar within FoundationEssentials that Xcode underlines. Please let me know if you’d like me to drop any of these comments from the PR or rebase the result.
Thanks!
P.S. There is a type named "UDate"Format, so this particular typo might cause some confusion for readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes are local and do not affect the public API.
Some changes are made to local scoped variables, while others are made to comments. Therefore, all of these changes appear to be backward compatible.
Please review.
Thanks