Skip to content

Commit 6b3f8c7

Browse files
committed
[cxx-interop] Rename CxxDeclExplicitSafetyDescriptor -> ClangDeclExplicitSafetyDescriptor
Keep the naming convention consistent; this isn't specific to Cxx
1 parent 2b9b507 commit 6b3f8c7

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

include/swift/ClangImporter/ClangImporterRequests.h

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -624,37 +624,37 @@ class CxxValueSemantics
624624
void simple_display(llvm::raw_ostream &out, CxxValueSemanticsDescriptor desc);
625625
SourceLoc extractNearestSourceLoc(CxxValueSemanticsDescriptor desc);
626626

627-
struct CxxDeclExplicitSafetyDescriptor final {
627+
struct ClangDeclExplicitSafetyDescriptor final {
628628
const clang::Decl *decl;
629629
bool isClass;
630630

631-
CxxDeclExplicitSafetyDescriptor(const clang::Decl *decl, bool isClass)
631+
ClangDeclExplicitSafetyDescriptor(const clang::Decl *decl, bool isClass)
632632
: decl(decl), isClass(isClass) {}
633633

634634
friend llvm::hash_code
635-
hash_value(const CxxDeclExplicitSafetyDescriptor &desc) {
635+
hash_value(const ClangDeclExplicitSafetyDescriptor &desc) {
636636
return llvm::hash_combine(desc.decl, desc.isClass);
637637
}
638638

639-
friend bool operator==(const CxxDeclExplicitSafetyDescriptor &lhs,
640-
const CxxDeclExplicitSafetyDescriptor &rhs) {
639+
friend bool operator==(const ClangDeclExplicitSafetyDescriptor &lhs,
640+
const ClangDeclExplicitSafetyDescriptor &rhs) {
641641
return lhs.decl == rhs.decl && lhs.isClass == rhs.isClass;
642642
}
643643

644-
friend bool operator!=(const CxxDeclExplicitSafetyDescriptor &lhs,
645-
const CxxDeclExplicitSafetyDescriptor &rhs) {
644+
friend bool operator!=(const ClangDeclExplicitSafetyDescriptor &lhs,
645+
const ClangDeclExplicitSafetyDescriptor &rhs) {
646646
return !(lhs == rhs);
647647
}
648648
};
649649

650650
void simple_display(llvm::raw_ostream &out,
651-
CxxDeclExplicitSafetyDescriptor desc);
652-
SourceLoc extractNearestSourceLoc(CxxDeclExplicitSafetyDescriptor desc);
651+
ClangDeclExplicitSafetyDescriptor desc);
652+
SourceLoc extractNearestSourceLoc(ClangDeclExplicitSafetyDescriptor desc);
653653

654654
/// Determine the safety of the given Clang declaration.
655655
class ClangDeclExplicitSafety
656656
: public SimpleRequest<ClangDeclExplicitSafety,
657-
ExplicitSafety(CxxDeclExplicitSafetyDescriptor),
657+
ExplicitSafety(ClangDeclExplicitSafetyDescriptor),
658658
RequestFlags::Cached> {
659659
public:
660660
using SimpleRequest::SimpleRequest;
@@ -668,7 +668,7 @@ class ClangDeclExplicitSafety
668668

669669
// Evaluation.
670670
ExplicitSafety evaluate(Evaluator &evaluator,
671-
CxxDeclExplicitSafetyDescriptor desc) const;
671+
ClangDeclExplicitSafetyDescriptor desc) const;
672672
};
673673

674674
#define SWIFT_TYPEID_ZONE ClangImporter

include/swift/ClangImporter/ClangImporterTypeIDZone.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,5 @@ SWIFT_REQUEST(ClangImporter, CxxValueSemantics,
4949
CxxValueSemanticsKind(CxxValueSemanticsDescriptor), Cached,
5050
NoLocationInfo)
5151
SWIFT_REQUEST(ClangImporter, ClangDeclExplicitSafety,
52-
ExplicitSafety(CxxDeclExplicitSafetyDescriptor), Cached,
52+
ExplicitSafety(ClangDeclExplicitSafetyDescriptor), Cached,
5353
NoLocationInfo)

lib/ClangImporter/ClangImporter.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8702,7 +8702,7 @@ SourceLoc swift::extractNearestSourceLoc(SafeUseOfCxxDeclDescriptor desc) {
87028702
}
87038703

87048704
void swift::simple_display(llvm::raw_ostream &out,
8705-
CxxDeclExplicitSafetyDescriptor desc) {
8705+
ClangDeclExplicitSafetyDescriptor desc) {
87068706
out << "Checking if '";
87078707
if (auto namedDecl = dyn_cast<clang::NamedDecl>(desc.decl))
87088708
out << namedDecl->getNameAsString();
@@ -8711,7 +8711,7 @@ void swift::simple_display(llvm::raw_ostream &out,
87118711
out << "' is explicitly safe.\n";
87128712
}
87138713

8714-
SourceLoc swift::extractNearestSourceLoc(CxxDeclExplicitSafetyDescriptor desc) {
8714+
SourceLoc swift::extractNearestSourceLoc(ClangDeclExplicitSafetyDescriptor desc) {
87158715
return SourceLoc();
87168716
}
87178717

@@ -8770,9 +8770,8 @@ CustomRefCountingOperationResult CustomRefCountingOperation::evaluate(
87708770
return {CustomRefCountingOperationResult::tooManyFound, nullptr, name};
87718771
}
87728772

8773-
ExplicitSafety
8774-
ClangDeclExplicitSafety::evaluate(Evaluator &evaluator,
8775-
CxxDeclExplicitSafetyDescriptor desc) const {
8773+
ExplicitSafety ClangDeclExplicitSafety::evaluate(
8774+
Evaluator &evaluator, ClangDeclExplicitSafetyDescriptor desc) const {
87768775
// FIXME: Also similar to hasPointerInSubobjects
87778776
// FIXME: should probably also subsume IsSafeUseOfCxxDecl
87788777

0 commit comments

Comments
 (0)