Merge pull request swiftlang#32823 from CodaFi/enhanced-spacial-reasoning

[5.3] Handle Boolean Patterns Matching Against Invalid Constructor Forms

Author: DougGregor

lib/Sema/TypeCheckSwitchStmt.cpp

@@ -418,6 +418,7 @@ namespace {
         PAIRCASE (SpaceKind::BooleanConstant, SpaceKind::BooleanConstant):
           return this->getBoolValue() == other.getBoolValue();
 
+        PAIRCASE (SpaceKind::BooleanConstant, SpaceKind::Constructor):
         PAIRCASE (SpaceKind::BooleanConstant, SpaceKind::UnknownCase):
           return false;
 

validation-test/compiler_crashers_2_fixed/rdar65229620.swift

@@ -0,0 +1,18 @@
+// RUN: not %target-swift-frontend -typecheck %s
+
+// N.B.: Requires a no-asserts build to reproduce, otherwise this hits an
+// assertion in type check pattern.
+// REQUIRES: no_asserts
+
+indirect enum BadOverload {
+case one(Bool, other: Void)
+case one(Bool?)
+}
+
+func crash(_ x: BadOverload) {
+  switch $0 {
+  case .one(false?):
+    break
+  }
+}
+