[installer] Do not follow an existing symbolic link when overwriting

kateinoigakukun · runner · commit a8fc4c9b4e7e · 2024-04-15T03:39:10.000Z
Without `-h` option, `ln` command makes a symbolic link under the existing
link destination like `Toolchains/swift-DEVELOPMENT-SNAPSHOT-XX.xctoolchain/`.

```
$ ln -fs swift-DEVELOPMENT-SNAPSHOT-XX.xctoolchain swift-latest.xctoolchain
$ ln -fs swift-DEVELOPMENT-SNAPSHOT-YY.xctoolchain swift-latest.xctoolchain
$ tree
|-- swift-DEVELOPMENT-SNAPSHOT-XX.xctoolchain
|   |-- swift-DEVELOPMENT-SNAPSHOT-YY.xctoolchain -&gt; swift-DEVELOPMENT-SNAPSHOT-YY.xctoolchain
|-- swift-DEVELOPMENT-SNAPSHOT-YY.xctoolchain
|-- swift-latest.xctoolchain -&gt; swift-DEVELOPMENT-SNAPSHOT-XX.xctoolchain
```

So we should not follow the existing symbolic link even if it already
exists.
diff --git a/utils/darwin-installer-scripts/postinstall b/utils/darwin-installer-scripts/postinstall
@@ -13,4 +13,4 @@
 
 INSTALLED_TOOLCHAIN=$2
 
-ln -fs "${INSTALLED_TOOLCHAIN}" "${INSTALLED_TOOLCHAIN%/*}/swift-latest.xctoolchain"
+ln -fhs "${INSTALLED_TOOLCHAIN}" "${INSTALLED_TOOLCHAIN%/*}/swift-latest.xctoolchain"

Original file line number	Diff line number	Diff line change
`@@ -13,4 +13,4 @@`
`13`	`13`
`14`	`14`	`INSTALLED_TOOLCHAIN=$2`
`15`	`15`
`16`		`-ln -fs "${INSTALLED_TOOLCHAIN}" "${INSTALLED_TOOLCHAIN%/*}/swift-latest.xctoolchain"`
	`16`	`+ln -fhs "${INSTALLED_TOOLCHAIN}" "${INSTALLED_TOOLCHAIN%/*}/swift-latest.xctoolchain"`