Skip to content

Commit 15dc27b

Browse files
committed
bug #1599 [Bootstrap v5] Fix the active links in the navigation (rosier)
This PR was merged into the main branch. Discussion ---------- [Bootstrap v5] Fix the active links in the navigation For the navbar the .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links. Commits ------- e130e54 [Bootstrap v5] Fix the active links in the navigation
2 parents d36ba89 + e130e54 commit 15dc27b

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

templates/admin/layout.html.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
{% endblock %}
1414

1515
{% block header_navigation_links %}
16-
<li class="nav-item{{ _route in ['admin_index', 'admin_post_index'] ? ' active' : '' }}">
17-
<a class="nav-link" href="{{ path('admin_post_index') }}">
16+
<li class="nav-item">
17+
<a class="nav-link {{- _route in ['admin_index', 'admin_post_index'] ? ' active' -}}" href="{{ path('admin_post_index') }}">
1818
<twig:ux:icon name="tabler:list"/> {{ 'menu.post_list'|trans }}
1919
</a>
2020
</li>

templates/base.html.twig

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
<div class="collapse navbar-collapse" id="appNavbar">
4040
<ul class="navbar-nav">
4141
{% block header_navigation_links %}
42-
<li class="nav-item{{ _route == 'blog_index' ? ' active' : '' }}">
43-
<a class="nav-link" href="{{ path('blog_index') }}">
42+
<li class="nav-item">
43+
<a class="nav-link {{- _route == 'blog_index' ? ' active' -}}" href="{{ path('blog_index') }}">
4444
<twig:ux:icon name="tabler:home"/> {{ 'menu.homepage'|trans }}
4545
</a>
4646
</li>
@@ -53,8 +53,10 @@
5353
{% endif %}
5454
{% endblock %}
5555

56-
<li class="nav-item{{ _route == 'blog_search' ? ' active' : '' }}">
57-
<a class="nav-link" href="{{ path('blog_search') }}"> <twig:ux:icon name="tabler:search"/> {{ 'menu.search'|trans }}</a>
56+
<li class="nav-item">
57+
<a class="nav-link {{- _route == 'blog_search' ? ' active' -}}" href="{{ path('blog_search') }}">
58+
<twig:ux:icon name="tabler:search"/> {{ 'menu.search'|trans }}
59+
</a>
5860
</li>
5961

6062
{% if app.user %}

0 commit comments

Comments
 (0)