minor #941 Added missing return types (Coderberg)

This PR was merged into the master branch.

Discussion
----------

Added missing return types

Commits
-------

386f504 Added missing return types

Author: javiereguiluz

src/Command/AddUserCommand.php

@@ -73,7 +73,7 @@ public function __construct(EntityManagerInterface $em, UserPasswordEncoderInter
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setDescription('Creates users and stores them in the database')
@@ -92,7 +92,7 @@ protected function configure()
      * This optional method is the first one executed for a command after configure()
      * and is useful to initialize properties based on the input arguments and options.
      */
-    protected function initialize(InputInterface $input, OutputInterface $output)
+    protected function initialize(InputInterface $input, OutputInterface $output): void
     {
         // SymfonyStyle is an optional feature that Symfony provides so you can
         // apply a consistent look to the commands of your application.
@@ -167,7 +167,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
      * This method is executed after interact() and initialize(). It usually
      * contains the logic to execute to complete this command task.
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): void
     {
         $stopwatch = new Stopwatch();
         $stopwatch->start('add-user-command');
@@ -203,7 +203,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
     }
 
-    private function validateUserData($username, $plainPassword, $email, $fullName)
+    private function validateUserData($username, $plainPassword, $email, $fullName): void
     {
         // first check if a user with the same username already exists.
         $existingUser = $this->users->findOneBy(['username' => $username]);

src/Command/DeleteUserCommand.php

@@ -61,7 +61,7 @@ public function __construct(EntityManagerInterface $em, Validator $validator, Us
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setDescription('Deletes users from the database')
@@ -79,7 +79,7 @@ protected function configure()
             );
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output)
+    protected function initialize(InputInterface $input, OutputInterface $output): void
     {
         // SymfonyStyle is an optional feature that Symfony provides so you can
         // apply a consistent look to the commands of your application.
@@ -108,7 +108,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
         $input->setArgument('username', $username);
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): void
     {
         $username = $this->validator->validateUsername($input->getArgument('username'));
 

src/Command/ListUsersCommand.php

@@ -55,7 +55,7 @@ public function __construct(\Swift_Mailer $mailer, $emailSender, UserRepository
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setDescription('Lists all the existing users')

src/DataFixtures/AppFixtures.php

@@ -29,14 +29,14 @@ public function __construct(UserPasswordEncoderInterface $passwordEncoder)
         $this->passwordEncoder = $passwordEncoder;
     }
 
-    public function load(ObjectManager $manager)
+    public function load(ObjectManager $manager): void
     {
         $this->loadUsers($manager);
         $this->loadTags($manager);
         $this->loadPosts($manager);
     }
 
-    private function loadUsers(ObjectManager $manager)
+    private function loadUsers(ObjectManager $manager): void
     {
         foreach ($this->getUserData() as [$fullname, $username, $password, $email, $roles]) {
             $user = new User();
@@ -53,7 +53,7 @@ private function loadUsers(ObjectManager $manager)
         $manager->flush();
     }
 
-    private function loadTags(ObjectManager $manager)
+    private function loadTags(ObjectManager $manager): void
     {
         foreach ($this->getTagData() as $index => $name) {
             $tag = new Tag();
@@ -66,7 +66,7 @@ private function loadTags(ObjectManager $manager)
         $manager->flush();
     }
 
-    private function loadPosts(ObjectManager $manager)
+    private function loadPosts(ObjectManager $manager): void
     {
         foreach ($this->getPostData() as [$title, $slug, $summary, $content, $publishedAt, $author, $tags]) {
             $post = new Post();

src/Form/CommentType.php

@@ -32,7 +32,7 @@ class CommentType extends AbstractType
     /**
      * {@inheritdoc}
      */
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         // By default, form fields include the 'required' attribute, which enables
         // the client-side form validation. This means that you can't test the
@@ -50,7 +50,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     /**
      * {@inheritdoc}
      */
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
             'data_class' => Comment::class,

src/Form/PostType.php

@@ -31,7 +31,7 @@ class PostType extends AbstractType
     /**
      * {@inheritdoc}
      */
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         // For the full reference of options defined by each form field type
         // see https://symfony.com/doc/current/reference/forms/types.html
@@ -70,7 +70,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     /**
      * {@inheritdoc}
      */
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
             'data_class' => Post::class,

src/Form/Type/DateTimePickerType.php

@@ -38,7 +38,7 @@ public function __construct(MomentFormatConverter $converter)
     /**
      * {@inheritdoc}
      */
-    public function buildView(FormView $view, FormInterface $form, array $options)
+    public function buildView(FormView $view, FormInterface $form, array $options): void
     {
         $view->vars['attr']['data-date-format'] = $this->formatConverter->convert($options['format']);
         $view->vars['attr']['data-date-locale'] = mb_strtolower(str_replace('_', '-', \Locale::getDefault()));
@@ -47,7 +47,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
     /**
      * {@inheritdoc}
      */
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
             'widget' => 'single_text',

src/Form/Type/TagsInputType.php

@@ -40,7 +40,7 @@ public function __construct(TagRepository $tags)
     /**
      * {@inheritdoc}
      */
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         $builder
             // The Tag collection must be transformed into a comma separated string.
@@ -55,7 +55,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     /**
      * {@inheritdoc}
      */
-    public function buildView(FormView $view, FormInterface $form, array $options)
+    public function buildView(FormView $view, FormInterface $form, array $options): void
     {
         $view->vars['tags'] = $this->tags->findAll();
     }