minor #1002 chore(phpunit): remove lines for SYMFONY_PHPUNIT_REMOVE (Kocal)

javiereguiluz · javiereguiluz · commit fed46b38478a · 2019-06-25T09:09:52.000+02:00
This PR was merged into the master branch. Discussion ---------- chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE` It's a following of #1000. The `phpunit` binary looks [like this](https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/4.3/bin/phpunit) for Symfony 4.3, we don't need `SYMFONY_PHPUNIT_REMOVE` lines too. I also think we don't need `SYMFONY_PHPUNIT_DIR` lines but I'm not really sure (it's working fine without those lines in one of our app). Commits ------- 9d7ea6c chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`
diff --git a/bin/phpunit b/bin/phpunit
@@ -5,9 +5,7 @@ if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-php
     echo "Unable to find the `simple-phpunit` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
     exit(1);
 }
-if (false === getenv('SYMFONY_PHPUNIT_REMOVE')) {
-    putenv('SYMFONY_PHPUNIT_REMOVE=');
-}
+
 if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
     putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
 }

Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,7 @@ if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-php`
`5`	`5`	echo "Unable to find the `simple-phpunit` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
`6`	`6`	`exit(1);`
`7`	`7`	`}`
`8`		`-if (false === getenv('SYMFONY_PHPUNIT_REMOVE')) {`
`9`		`- putenv('SYMFONY_PHPUNIT_REMOVE=');`
`10`		`-}`
	`8`	`+`
`11`	`9`	`if (false === getenv('SYMFONY_PHPUNIT_DIR')) {`
`12`	`10`	`putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');`
`13`	`11`	`}`