bug #523 Fix accessing PantherTestCaseTrait::$webServerDir before initialization (kbond)

chalasr · chalasr · commit dc572828ee81 · 2021-12-02T18:32:12.000+01:00
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Fix accessing `PantherTestCaseTrait::$webServerDir` before initialization `PantherTestCaseTrait::getWebServerDir()` can access `PantherTestCaseTrait::$webServerDir` before it's initialized. I believe this was just missed in #517. Commits ------- 39efc06 fix "webServerDir must not be accessed before initialization"
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+2.0.1
+-----
+
+* Fix accessing `PantherTestCaseTrait::$webServerDir` before initialization
+
 2.0.0
 -----
 
diff --git a/src/PantherTestCaseTrait.php b/src/PantherTestCaseTrait.php
@@ -31,7 +31,7 @@ trait PantherTestCaseTrait
 {
     public static bool $stopServerOnTeardown = true;
 
-    protected static ?string $webServerDir;
+    protected static ?string $webServerDir = null;
 
     protected static ?WebServerManager $webServerManager = null;
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ trait PantherTestCaseTrait`
`31`	`31`	`{`
`32`	`32`	`public static bool $stopServerOnTeardown = true;`
`33`	`33`
`34`		`- protected static ?string $webServerDir;`
	`34`	`+ protected static ?string $webServerDir = null;`
`35`	`35`
`36`	`36`	`protected static ?WebServerManager $webServerManager = null;`
`37`	`37`