Skip to content

Commit 4404e48

Browse files
committed
Adopt 2-entry direct-mapped page cache
Replace the previous 1-entry direct-mapped design with a 2-entry direct-mapped cache using hash-based indexing (same parity hash as cache_load). This allows two hot virtual pages to coexist without thrashing. Measurement shows that the number of virtual-to-physical translations during instruction fetch (mmu_translate() calls) decreased by ~10%.
1 parent a2c1bd0 commit 4404e48

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

riscv.c

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,8 @@ static inline void icache_invalidate_all(hart_t *vm)
190190

191191
void mmu_invalidate(hart_t *vm)
192192
{
193-
vm->cache_fetch.n_pages = 0xFFFFFFFF;
193+
vm->cache_fetch[0].n_pages = 0xFFFFFFFF;
194+
vm->cache_fetch[1].n_pages = 0xFFFFFFFF;
194195
/* Invalidate all 8 sets × 2 ways for load cache */
195196
for (int set = 0; set < 8; set++) {
196197
for (int way = 0; way < 2; way++)
@@ -234,9 +235,11 @@ void mmu_invalidate_range(hart_t *vm, uint32_t start_addr, uint32_t size)
234235
uint32_t end_vpn = (uint32_t) end_addr >> RV_PAGE_SHIFT;
235236

236237
/* Cache invalidation for fetch cache */
237-
if (vm->cache_fetch.n_pages >= start_vpn &&
238-
vm->cache_fetch.n_pages <= end_vpn)
239-
vm->cache_fetch.n_pages = 0xFFFFFFFF;
238+
for (int i = 0; i < 2; i++) {
239+
if (vm->cache_fetch[i].n_pages >= start_vpn &&
240+
vm->cache_fetch[i].n_pages <= end_vpn)
241+
vm->cache_fetch[i].n_pages = 0xFFFFFFFF;
242+
}
240243

241244
/* Invalidate load cache: 8 sets × 2 ways */
242245
for (int set = 0; set < 8; set++) {
@@ -388,7 +391,8 @@ static void mmu_fetch(hart_t *vm, uint32_t addr, uint32_t *value)
388391

389392
/* cache miss, Continue using the original va->pa*/
390393
uint32_t vpn = addr >> RV_PAGE_SHIFT;
391-
if (unlikely(vpn != vm->cache_fetch.n_pages)) {
394+
uint32_t index = __builtin_parity(vpn) & 0x1;
395+
if (unlikely(vpn != vm->cache_fetch[index].n_pages)) {
392396
mmu_translate(vm, &addr, (1 << 3), (1 << 6), false, RV_EXC_FETCH_FAULT,
393397
RV_EXC_FETCH_PFAULT);
394398
if (vm->error)
@@ -397,15 +401,16 @@ static void mmu_fetch(hart_t *vm, uint32_t addr, uint32_t *value)
397401
vm->mem_fetch(vm, addr >> RV_PAGE_SHIFT, &page_addr);
398402
if (vm->error)
399403
return;
400-
vm->cache_fetch.n_pages = vpn;
401-
vm->cache_fetch.page_addr = page_addr;
404+
vm->cache_fetch[index].n_pages = vpn;
405+
vm->cache_fetch[index].page_addr = page_addr;
402406
}
403407

404-
*value = vm->cache_fetch.page_addr[(addr >> 2) & MASK(RV_PAGE_SHIFT - 2)];
408+
*value =
409+
vm->cache_fetch[index].page_addr[(addr >> 2) & MASK(RV_PAGE_SHIFT - 2)];
405410

406411
/* fill into the cache */
407412
uint32_t block_off = (addr & RV_PAGE_MASK) & ~ICACHE_BLOCK_MASK;
408-
blk->base = (const uint8_t *) vm->cache_fetch.page_addr + block_off;
413+
blk->base = (const uint8_t *) vm->cache_fetch[index].page_addr + block_off;
409414
blk->tag = tag;
410415
blk->valid = true;
411416
}

riscv.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ struct __hart_internal {
140140
*/
141141
uint32_t exc_cause, exc_val;
142142

143-
mmu_fetch_cache_t cache_fetch;
143+
/* 2-entry direct-mapped with hash-based indexing */
144+
mmu_fetch_cache_t cache_fetch[2];
144145
/* 8-set × 2-way set-associative cache with 3-bit parity hash indexing */
145146
mmu_cache_set_t cache_load[8];
146147
/* 8-set × 2-way set-associative cache for store operations */

0 commit comments

Comments
 (0)