hotfixes

Author: ermyar

connection.go

@@ -376,7 +376,7 @@ func Connect(ctx context.Context, dialer Dialer, opts Opts) (conn *Connection, e
 	conn.cond = sync.NewCond(&conn.mutex)
 	conn.slicePool = &sync.Pool{
 		New: func() any {
-			buf := make([]byte, 0, 512)
+			buf := make([]byte, 0, 4096)
 			return &buf
 		},
 	}

future.go

@@ -101,7 +101,7 @@ func (fut *Future) GetResponse() (Response, error) {
 // "error" could be Error, if it is error returned by Tarantool,
 // or ClientError, if something bad happens in a client process.
 func (fut *Future) Get() ([]interface{}, error) {
-	defer fut.release()
+	defer fut.Release()
 	fut.wait()
 	if fut.err != nil {
 		return nil, fut.err
@@ -114,7 +114,7 @@ func (fut *Future) Get() ([]interface{}, error) {
 //
 // Note: Tarantool usually returns array of tuples (except for Eval and Call17 actions).
 func (fut *Future) GetTyped(result interface{}) error {
-	defer fut.release()
+	defer fut.Release()
 	fut.wait()
 	if fut.err != nil {
 		return fut.err
@@ -136,8 +136,9 @@ func (fut *Future) WaitChan() <-chan struct{} {
 	return fut.done
 }
 
-func (fut *Future) release() {
+func (fut *Future) Release() {
 	if fut.pool != nil && fut.resp != nil {
-		fut.pool.Put(fut.resp.Buffer())
+		ptr := fut.resp.Release()
+		fut.pool.Put(ptr)
 	}
 }

future_test.go

@@ -53,7 +53,8 @@ func (resp *futureMockResponse) Header() Header {
 	return resp.header
 }
 
-func (resp *futureMockResponse) Buffer() *[]byte {
+func (resp *futureMockResponse) Release() *[]byte {
+	// Releasing futureMockResponse data.
 	return &resp.data
 }
 

prepared.go

@@ -90,7 +90,7 @@ func (req *PrepareRequest) Response(header Header, body io.Reader) (Response, er
 	if err != nil {
 		return nil, err
 	}
-	return &PrepareResponse{baseResponse: baseResp}, nil
+	return &PrepareResponse{baseResponse: *baseResp}, nil
 }
 
 // UnprepareRequest helps you to create an unprepare request object for
@@ -204,5 +204,5 @@ func (req *ExecutePreparedRequest) Response(header Header, body io.Reader) (Resp
 	if err != nil {
 		return nil, err
 	}
-	return &ExecuteResponse{baseResponse: baseResp}, nil
+	return &ExecuteResponse{baseResponse: *baseResp}, nil
 }

request.go

@@ -1031,11 +1031,11 @@ func (req *SelectRequest) Context(ctx context.Context) *SelectRequest {
 
 // Response creates a response for the SelectRequest.
 func (req *SelectRequest) Response(header Header, body io.Reader) (Response, error) {
-	baseResp, err := createBaseResponse(header, body)
+	SelectResp, err := createSelectResponse(header, body)
 	if err != nil {
 		return nil, err
 	}
-	return &SelectResponse{baseResponse: baseResp}, nil
+	return SelectResp, nil
 }
 
 // InsertRequest helps you to create an insert request object for execution
@@ -1565,7 +1565,7 @@ func (req *ExecuteRequest) Response(header Header, body io.Reader) (Response, er
 	if err != nil {
 		return nil, err
 	}
-	return &ExecuteResponse{baseResponse: baseResp}, nil
+	return &ExecuteResponse{baseResponse: *baseResp}, nil
 }
 
 // WatchOnceRequest synchronously fetches the value currently associated with a

response.go

@@ -3,6 +3,7 @@ package tarantool
 import (
 	"fmt"
 	"io"
+	"sync"
 
 	"github.com/tarantool/go-iproto"
 	"github.com/vmihailenco/msgpack/v5"
@@ -12,8 +13,8 @@ import (
 type Response interface {
 	// Header returns a response header.
 	Header() Header
-	// Buffer returns a response buffer.
-	Buffer() *[]byte
+	// Release free responses data and returns buffer's data.
+	Release() *[]byte
 	// Decode decodes a response.
 	Decode() ([]interface{}, error)
 	// DecodeTyped decodes a response into a given container res.
@@ -33,24 +34,54 @@ type baseResponse struct {
 	err          error
 }
 
-func createBaseResponse(header Header, body io.Reader) (baseResponse, error) {
+var baseResponsePool *sync.Pool = &sync.Pool{
+	New: func() interface{} {
+		return &baseResponse{}
+	},
+}
+
+func createBaseResponse(header Header, body io.Reader) (*baseResponse, error) {
+	resp := baseResponsePool.Get().(*baseResponse)
 	if body == nil {
-		return baseResponse{header: header}, nil
+		resp.header = header
+		return resp, nil
 	}
 	if buf, ok := body.(*smallBuf); ok {
-		return baseResponse{header: header, buf: *buf}, nil
+		resp.header = header
+		resp.buf.b = buf.b
+		resp.buf.p = buf.p
+		return resp, nil
 	}
 	data, err := io.ReadAll(body)
 	if err != nil {
-		return baseResponse{}, err
+		return resp, err
 	}
-	return baseResponse{header: header, buf: smallBuf{b: data}}, nil
+	resp.header = header
+	resp.buf.b = data
+	return resp, nil
+}
+
+func (resp *baseResponse) clear() *[]byte {
+	resp.header.RequestId, resp.header.Error = 0, 0
+	resp.data = nil
+	resp.buf.b = resp.buf.b[:0]
+	resp.buf.p = 0
+	resp.decoded = false
+	resp.decodedTyped = false
+	resp.err = nil
+	return &resp.buf.b
+}
+
+func (resp *baseResponse) Release() *[]byte {
+	ptr := resp.clear()
+	baseResponsePool.Put(resp)
+	return ptr
 }
 
 // DecodeBaseResponse parse response header and body.
 func DecodeBaseResponse(header Header, body io.Reader) (Response, error) {
 	resp, err := createBaseResponse(header, body)
-	return &resp, err
+	return resp, err
 }
 
 // SelectResponse is used for the select requests.
@@ -659,8 +690,39 @@ func (resp *baseResponse) Header() Header {
 	return resp.header
 }
 
-func (resp *baseResponse) Buffer() *[]byte {
-	return &resp.buf.b
+var selectResponsePool *sync.Pool = &sync.Pool{
+	New: func() interface{} {
+		return &SelectResponse{}
+	},
+}
+
+func createSelectResponse(header Header, body io.Reader) (*SelectResponse, error) {
+	resp := selectResponsePool.Get().(*SelectResponse)
+	if body == nil {
+		resp.header = header
+		return resp, nil
+	}
+	if buf, ok := body.(*smallBuf); ok {
+		resp.header = header
+		resp.buf.b = buf.b
+		resp.buf.p = buf.p
+		return resp, nil
+	}
+	data, err := io.ReadAll(body)
+	if err != nil {
+		return resp, err
+	}
+	resp.header = header
+	resp.buf.b = data
+	return resp, nil
+}
+
+func (resp *SelectResponse) Release() *[]byte {
+	ptr := resp.baseResponse.clear()
+	resp.pos = resp.pos[:0]
+
+	selectResponsePool.Put(resp)
+	return ptr
 }
 
 // Pos returns a position descriptor of the last selected tuple for the SelectResponse.

test_helpers/response.go

@@ -54,7 +54,8 @@ func (resp *MockResponse) Header() tarantool.Header {
 	return resp.header
 }
 
-func (resp *MockResponse) Buffer() *[]byte {
+func (resp *MockResponse) Release() *[]byte {
+	// Releasing MockResponse data
 	return &resp.data
 }