crud: refactor optional types to use go-option

- Remove: OptUint, OptInt, OptFloat64, OptString, OptBool, OptTuple.
- Remove: MakeOptUint, MakeOptInt, MakeOptFloat64, MakeOptString, MakeOptBool, MakeOptTuple.
- Update: All option structs to use option.* types.
- Add type Any from go-option.
- Fix: Test type inconsistencies.

Closes #492

Author: New year

CHANGELOG.md

@@ -26,6 +26,7 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
   and Future.GetIterator() methods, ResponseIterator and TimeoutResponseIterator types,
   Future.pushes[] (#480).
 * `LogAppendPushFailed` replaced with `LogBoxSessionPushUnsupported` (#480)
+* Replaced the use of optional types in crud with go-option library (#492).
 
 ### Fixed
 
@@ -48,7 +49,6 @@ flag handling, and fixes watcher panic.
 - Implemented support for `IPROTO_IS_SYNC` flag in stream transactions,
   added `IsSync(bool)` method for `BeginRequest`/`CommitRequest` (#447).
 
-
 ### Fixed
 
 - Fixed panic when calling NewWatcher() during reconnection or after

crud/count.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/vmihailenco/msgpack/v5"
 
+	"github.com/tarantool/go-option"
 	"github.com/tarantool/go-tarantool/v3"
 )
 
@@ -15,30 +16,30 @@ type CountResult = NumberResult
 type CountOpts struct {
 	// Timeout is a `vshard.call` timeout and vshard
 	// master discovery timeout (in seconds).
-	Timeout OptFloat64
+	Timeout option.Float64
 	// VshardRouter is cartridge vshard group name or
 	// vshard router instance.
-	VshardRouter OptString
+	VshardRouter option.String
 	// Mode is a parameter with `write`/`read` possible values,
 	// if `write` is specified then operation is performed on master.
-	Mode OptString
+	Mode option.String
 	// PreferReplica is a parameter to specify preferred target
 	// as one of the replicas.
-	PreferReplica OptBool
+	PreferReplica option.Bool
 	// Balance is a parameter to use replica according to vshard
 	// load balancing policy.
-	Balance OptBool
+	Balance option.Bool
 	// YieldEvery describes number of tuples processed to yield after.
 	// Should be positive.
-	YieldEvery OptUint
+	YieldEvery option.Uint
 	// BucketId is a bucket ID.
-	BucketId OptUint
+	BucketId option.Uint
 	// ForceMapCall describes the map call is performed without any
 	// optimizations even if full primary key equal condition is specified.
-	ForceMapCall OptBool
+	ForceMapCall option.Bool
 	// Fullscan describes if a critical log entry will be skipped on
 	// potentially long count.
-	Fullscan OptBool
+	Fullscan option.Bool
 }
 
 // EncodeMsgpack provides custom msgpack encoder.

crud/example_test.go

@@ -6,6 +6,7 @@ import (
 	"reflect"
 	"time"
 
+	"github.com/tarantool/go-option"
 	"github.com/tarantool/go-tarantool/v3"
 	"github.com/tarantool/go-tarantool/v3/crud"
 )
@@ -288,7 +289,7 @@ func ExampleResult_noreturn() {
 			[]interface{}{uint(2011), nil, "bla"},
 		}).
 		Opts(crud.ReplaceManyOpts{
-			Noreturn: crud.MakeOptBool(true),
+			Noreturn: option.SomeBool(true),
 		})
 
 	ret := crud.Result{}
@@ -375,8 +376,8 @@ func ExampleSelectRequest_pagination() {
 
 	req := crud.MakeSelectRequest(exampleSpace).
 		Opts(crud.SelectOpts{
-			First: crud.MakeOptInt(2),
-			After: crud.MakeOptTuple(tuple),
+			First: option.SomeInt64(2),
+			After: option.SomeAny(tuple),
 		})
 	ret := crud.Result{}
 	if err := conn.Do(req).GetTyped(&ret); err != nil {

crud/get.go

@@ -5,35 +5,36 @@ import (
 
 	"github.com/vmihailenco/msgpack/v5"
 
+	"github.com/tarantool/go-option"
 	"github.com/tarantool/go-tarantool/v3"
 )
 
 // GetOpts describes options for `crud.get` method.
 type GetOpts struct {
 	// Timeout is a `vshard.call` timeout and vshard
 	// master discovery timeout (in seconds).
-	Timeout OptFloat64
+	Timeout option.Float64
 	// VshardRouter is cartridge vshard group name or
 	// vshard router instance.
-	VshardRouter OptString
+	VshardRouter option.String
 	// Fields is field names for getting only a subset of fields.
-	Fields OptTuple
+	Fields option.Any
 	// BucketId is a bucket ID.
-	BucketId OptUint
+	BucketId option.Uint
 	// Mode is a parameter with `write`/`read` possible values,
 	// if `write` is specified then operation is performed on master.
-	Mode OptString
+	Mode option.String
 	// PreferReplica is a parameter to specify preferred target
 	// as one of the replicas.
-	PreferReplica OptBool
+	PreferReplica option.Bool
 	// Balance is a parameter to use replica according to vshard
 	// load balancing policy.
-	Balance OptBool
+	Balance option.Bool
 	// FetchLatestMetadata guarantees the up-to-date metadata (space format)
 	// in first return value, otherwise it may not take into account
 	// the latest migration of the data format. Performance overhead is up to 15%.
 	// Disabled by default.
-	FetchLatestMetadata OptBool
+	FetchLatestMetadata option.Bool
 }
 
 // EncodeMsgpack provides custom msgpack encoder.

crud/insert.go

@@ -3,9 +3,8 @@ package crud
 import (
 	"context"
 
-	"github.com/vmihailenco/msgpack/v5"
-
 	"github.com/tarantool/go-tarantool/v3"
+	"github.com/vmihailenco/msgpack/v5"
 )
 
 // InsertOpts describes options for `crud.insert` method.