Remove Experimental annotations from Update APIs (#2347)

dandavison · web-flow · commit 53a8af7ec44b · 2024-12-12T10:32:49.000-05:00
diff --git a/temporal-sdk/src/main/java/io/temporal/client/WorkflowClient.java b/temporal-sdk/src/main/java/io/temporal/client/WorkflowClient.java
@@ -719,7 +719,6 @@ static <A1, A2, A3, A4, A5, A6> WorkflowUpdateHandle<Void> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func<R> updateMethod, @Nonnull UpdateOptions<R> options) {
     return WorkflowClientInternalImpl.startUpdate(updateMethod, options);
@@ -734,7 +733,6 @@ static <R> WorkflowUpdateHandle<R> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R, A1> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func1<A1, R> updateMethod, A1 arg1, @Nonnull UpdateOptions<R> options) {
     return WorkflowClientInternalImpl.startUpdate(updateMethod, arg1, options);
@@ -750,7 +748,6 @@ static <R, A1> WorkflowUpdateHandle<R> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R, A1, A2> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func2<A1, A2, R> updateMethod,
       A1 arg1,
@@ -770,7 +767,6 @@ static <R, A1, A2> WorkflowUpdateHandle<R> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R, A1, A2, A3> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func3<A1, A2, A3, R> updateMethod,
       A1 arg1,
@@ -792,7 +788,6 @@ static <R, A1, A2, A3> WorkflowUpdateHandle<R> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R, A1, A2, A3, A4> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func4<A1, A2, A3, A4, R> updateMethod,
       A1 arg1,
@@ -816,7 +811,6 @@ static <R, A1, A2, A3, A4> WorkflowUpdateHandle<R> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R, A1, A2, A3, A4, A5> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func5<A1, A2, A3, A4, A5, R> updateMethod,
       A1 arg1,
@@ -843,7 +837,6 @@ static <R, A1, A2, A3, A4, A5> WorkflowUpdateHandle<R> startUpdate(
    * @param options update options
    * @return WorkflowUpdateHandle that can be used to get the result of the update
    */
-  @Experimental
   static <R, A1, A2, A3, A4, A5, A6> WorkflowUpdateHandle<R> startUpdate(
       Functions.Func6<A1, A2, A3, A4, A5, A6, R> updateMethod,
       A1 arg1,
diff --git a/temporal-sdk/src/main/java/io/temporal/client/WorkflowStub.java b/temporal-sdk/src/main/java/io/temporal/client/WorkflowStub.java
@@ -90,7 +90,6 @@ static <T> WorkflowStub fromTyped(T typed) {
    * @throws WorkflowServiceException for all other failures including networking and service
    *     availability issues.
    */
-  @Experimental
   <R> R update(String updateName, Class<R> resultClass, Object... args);
 
   /**
@@ -109,7 +108,6 @@ static <T> WorkflowStub fromTyped(T typed) {
    * @throws WorkflowServiceException for all other failures including networking and service
    *     availability issues.
    */
-  @Experimental
   <R> WorkflowUpdateHandle<R> startUpdate(
       String updateName, WorkflowUpdateStage waitForStage, Class<R> resultClass, Object... args);
 
@@ -125,7 +123,6 @@ <R> WorkflowUpdateHandle<R> startUpdate(
    * @throws WorkflowServiceException for all other failures including networking and service
    *     availability issues.
    */
-  @Experimental
   <R> WorkflowUpdateHandle<R> startUpdate(UpdateOptions<R> options, Object... args);
 
   /**
@@ -137,7 +134,6 @@ <R> WorkflowUpdateHandle<R> startUpdate(
    * @param <R> type of the update return value.
    * @return update handle that can be used to get the result of the update.
    */
-  @Experimental
   <R> WorkflowUpdateHandle<R> getUpdateHandle(String updateId, Class<R> resultClass);
 
   /**
@@ -151,7 +147,6 @@ <R> WorkflowUpdateHandle<R> startUpdate(
    * @param resultType type of the update return value. Differs from resultClass for generic types.
    * @return update handle that can be used to get the result of the update.
    */
-  @Experimental
   <R> WorkflowUpdateHandle<R> getUpdateHandle(
       String updateId, Class<R> resultClass, Type resultType);
 
diff --git a/temporal-sdk/src/main/java/io/temporal/client/WorkflowUpdateException.java b/temporal-sdk/src/main/java/io/temporal/client/WorkflowUpdateException.java
@@ -21,13 +21,8 @@
 package io.temporal.client;
 
 import io.temporal.api.common.v1.WorkflowExecution;
-import io.temporal.common.Experimental;
 
-/**
- * Exception used to communicate failure of an update workflow execution request to an external
- * workflow.
- */
-@Experimental
+/** Exception used to communicate failure of an update workflow execution request. */
 public final class WorkflowUpdateException extends WorkflowException {
 
   private final String updateId;
diff --git a/temporal-sdk/src/main/java/io/temporal/client/WorkflowUpdateHandle.java b/temporal-sdk/src/main/java/io/temporal/client/WorkflowUpdateHandle.java
@@ -21,15 +21,13 @@
 package io.temporal.client;
 
 import io.temporal.api.common.v1.WorkflowExecution;
-import io.temporal.common.Experimental;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.TimeUnit;
 
 /**
  * WorkflowUpdateHandle is a handle to an update workflow execution request that can be used to get
  * the status of that update request.
  */
-@Experimental
 public interface WorkflowUpdateHandle<T> {
   /**
    * Gets the workflow execution this update request was sent to.
diff --git a/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowClientCallsInterceptor.java b/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowClientCallsInterceptor.java
@@ -85,10 +85,8 @@ public interface WorkflowClientCallsInterceptor {
 
   <R> QueryOutput<R> query(QueryInput<R> input);
 
-  @Experimental
   <R> WorkflowUpdateHandle<R> startUpdate(StartUpdateInput<R> input);
 
-  @Experimental
   <R> PollWorkflowUpdateOutput<R> pollWorkflowUpdate(PollWorkflowUpdateInput<R> input);
 
   CancelOutput cancel(CancelInput input);
@@ -428,7 +426,6 @@ public WorkflowExecution getWorkflowExecution() {
     }
   }
 
-  @Experimental
   final class StartUpdateInput<R> {
     private final WorkflowExecution workflowExecution;
     private final Optional<String> workflowType;
@@ -505,7 +502,6 @@ public WaitPolicy getWaitPolicy() {
     }
   }
 
-  @Experimental
   final class PollWorkflowUpdateInput<R> {
     private final WorkflowExecution workflowExecution;
     private long timeout;
@@ -561,7 +557,6 @@ public String getUpdateId() {
     }
   }
 
-  @Experimental
   final class PollWorkflowUpdateOutput<R> {
     private final CompletableFuture<R> result;
 
diff --git a/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowInboundCallsInterceptor.java b/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowInboundCallsInterceptor.java
@@ -143,7 +143,6 @@ public Object getResult() {
     }
   }
 
-  @Experimental
   final class UpdateInput {
     private final String updateName;
     private final Header header;
@@ -168,7 +167,6 @@ public Object[] getArguments() {
     }
   }
 
-  @Experimental
   final class UpdateOutput {
     private final Object result;
 
@@ -212,14 +210,12 @@ public Object getResult() {
    * Called when update workflow execution request is delivered to a workflow execution, before the
    * update is executed.
    */
-  @Experimental
   void validateUpdate(UpdateInput input);
 
   /**
    * Called when update workflow execution request is delivered to a workflow execution, after
    * passing the validator.
    */
-  @Experimental
   UpdateOutput executeUpdate(UpdateInput input);
 
   /**
diff --git a/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptor.java b/temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptor.java
@@ -552,7 +552,6 @@ public List<SignalRegistrationRequest> getRequests() {
     }
   }
 
-  @Experimental
   final class UpdateRegistrationRequest {
     private final String updateName;
     private final String description;
@@ -626,7 +625,6 @@ public Functions.Func1<Object[], Object> getExecuteCallback() {
     }
   }
 
-  @Experimental
   final class RegisterUpdateHandlersInput {
     private final List<UpdateRegistrationRequest> requests;
 
@@ -718,7 +716,6 @@ public DynamicSignalHandler getHandler() {
     }
   }
 
-  @Experimental
   final class RegisterDynamicUpdateHandlerInput {
     private final DynamicUpdateHandler handler;
 
@@ -769,14 +766,12 @@ <R> R mutableSideEffect(
 
   void registerSignalHandlers(RegisterSignalHandlersInput input);
 
-  @Experimental
   void registerUpdateHandlers(RegisterUpdateHandlersInput input);
 
   void registerDynamicSignalHandler(RegisterDynamicSignalHandlerInput handler);
 
   void registerDynamicQueryHandler(RegisterDynamicQueryHandlerInput input);
 
-  @Experimental
   void registerDynamicUpdateHandler(RegisterDynamicUpdateHandlerInput input);
 
   UUID randomUUID();
diff --git a/temporal-sdk/src/main/java/io/temporal/common/metadata/POJOWorkflowImplMetadata.java b/temporal-sdk/src/main/java/io/temporal/common/metadata/POJOWorkflowImplMetadata.java
@@ -222,13 +222,11 @@ public List<POJOWorkflowMethodMetadata> getQueryMethods() {
   }
 
   /** List of update methods an object implements across all the workflow interfaces. */
-  @Experimental
   public List<POJOWorkflowMethodMetadata> getUpdateMethods() {
     return updateMethods;
   }
 
   /** List of update validator methods an object implements across all the workflow interfaces. */
-  @Experimental
   public List<POJOWorkflowMethodMetadata> getUpdateValidatorMethods() {
     return updateValidatorMethods;
   }
diff --git a/temporal-sdk/src/main/java/io/temporal/internal/client/CompletedWorkflowUpdateHandleImpl.java b/temporal-sdk/src/main/java/io/temporal/internal/client/CompletedWorkflowUpdateHandleImpl.java
@@ -23,11 +23,9 @@
 import io.temporal.api.common.v1.WorkflowExecution;
 import io.temporal.client.WorkflowUpdateException;
 import io.temporal.client.WorkflowUpdateHandle;
-import io.temporal.common.Experimental;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.TimeUnit;
 
-@Experimental
 public final class CompletedWorkflowUpdateHandleImpl<T> implements WorkflowUpdateHandle<T> {
 
   private final String id;
diff --git a/temporal-sdk/src/main/java/io/temporal/internal/client/LazyWorkflowUpdateHandleImpl.java b/temporal-sdk/src/main/java/io/temporal/internal/client/LazyWorkflowUpdateHandleImpl.java
@@ -25,13 +25,11 @@
 import io.temporal.client.WorkflowException;
 import io.temporal.client.WorkflowServiceException;
 import io.temporal.client.WorkflowUpdateHandle;
-import io.temporal.common.Experimental;
 import io.temporal.common.interceptors.WorkflowClientCallsInterceptor;
 import io.temporal.serviceclient.CheckedExceptionWrapper;
 import java.lang.reflect.Type;
 import java.util.concurrent.*;
 
-@Experimental
 public final class LazyWorkflowUpdateHandleImpl<T> implements WorkflowUpdateHandle<T> {
 
   private final WorkflowClientCallsInterceptor workflowClientInvoker;
diff --git a/temporal-sdk/src/main/java/io/temporal/internal/client/external/GenericWorkflowClient.java b/temporal-sdk/src/main/java/io/temporal/internal/client/external/GenericWorkflowClient.java
@@ -39,11 +39,9 @@ SignalWithStartWorkflowExecutionResponse signalWithStart(
 
   QueryWorkflowResponse query(QueryWorkflowRequest queryParameters);
 
-  @Experimental
   UpdateWorkflowExecutionResponse update(
       @Nonnull UpdateWorkflowExecutionRequest updateParameters, @Nonnull Deadline deadline);
 
-  @Experimental
   CompletableFuture<PollWorkflowExecutionUpdateResponse> pollUpdateAsync(
       @Nonnull PollWorkflowExecutionUpdateRequest request, @Nonnull Deadline deadline);
 
diff --git a/temporal-sdk/src/main/java/io/temporal/workflow/UpdateMethod.java b/temporal-sdk/src/main/java/io/temporal/workflow/UpdateMethod.java
@@ -20,7 +20,6 @@
 
 package io.temporal.workflow;
 
-import io.temporal.common.Experimental;
 import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
@@ -34,7 +33,6 @@
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.METHOD)
-@Experimental
 public @interface UpdateMethod {
   /**
    * Name of the update handler. Default is method name.
diff --git a/temporal-sdk/src/main/java/io/temporal/workflow/UpdateValidatorMethod.java b/temporal-sdk/src/main/java/io/temporal/workflow/UpdateValidatorMethod.java
@@ -20,7 +20,6 @@
 
 package io.temporal.workflow;
 
-import io.temporal.common.Experimental;
 import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
@@ -36,7 +35,6 @@
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.METHOD)
-@Experimental
 public @interface UpdateValidatorMethod {
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,8 @@ public interface WorkflowClientCallsInterceptor {`
`85`	`85`
`86`	`86`	`<R> QueryOutput<R> query(QueryInput<R> input);`
`87`	`87`
`88`		`- @Experimental`
`89`	`88`	`<R> WorkflowUpdateHandle<R> startUpdate(StartUpdateInput<R> input);`
`90`	`89`
`91`		`- @Experimental`
`92`	`90`	`<R> PollWorkflowUpdateOutput<R> pollWorkflowUpdate(PollWorkflowUpdateInput<R> input);`
`93`	`91`
`94`	`92`	`CancelOutput cancel(CancelInput input);`
`@@ -428,7 +426,6 @@ public WorkflowExecution getWorkflowExecution() {`
`428`	`426`	`}`
`429`	`427`	`}`
`430`	`428`
`431`		`- @Experimental`
`432`	`429`	`final class StartUpdateInput<R> {`
`433`	`430`	`private final WorkflowExecution workflowExecution;`
`434`	`431`	`private final Optional<String> workflowType;`
`@@ -505,7 +502,6 @@ public WaitPolicy getWaitPolicy() {`
`505`	`502`	`}`
`506`	`503`	`}`
`507`	`504`
`508`		`- @Experimental`
`509`	`505`	`final class PollWorkflowUpdateInput<R> {`
`510`	`506`	`private final WorkflowExecution workflowExecution;`
`511`	`507`	`private long timeout;`
`@@ -561,7 +557,6 @@ public String getUpdateId() {`
`561`	`557`	`}`
`562`	`558`	`}`
`563`	`559`
`564`		`- @Experimental`
`565`	`560`	`final class PollWorkflowUpdateOutput<R> {`
`566`	`561`	`private final CompletableFuture<R> result;`
`567`	`562`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,6 @@ public Object getResult() {`
`143`	`143`	`}`
`144`	`144`	`}`
`145`	`145`
`146`		`- @Experimental`
`147`	`146`	`final class UpdateInput {`
`148`	`147`	`private final String updateName;`
`149`	`148`	`private final Header header;`
`@@ -168,7 +167,6 @@ public Object[] getArguments() {`
`168`	`167`	`}`
`169`	`168`	`}`
`170`	`169`
`171`		`- @Experimental`
`172`	`170`	`final class UpdateOutput {`
`173`	`171`	`private final Object result;`
`174`	`172`
`@@ -212,14 +210,12 @@ public Object getResult() {`
`212`	`210`	`* Called when update workflow execution request is delivered to a workflow execution, before the`
`213`	`211`	`* update is executed.`
`214`	`212`	`*/`
`215`		`- @Experimental`
`216`	`213`	`void validateUpdate(UpdateInput input);`
`217`	`214`
`218`	`215`	`/**`
`219`	`216`	`* Called when update workflow execution request is delivered to a workflow execution, after`
`220`	`217`	`* passing the validator.`
`221`	`218`	`*/`
`222`		`- @Experimental`
`223`	`219`	`UpdateOutput executeUpdate(UpdateInput input);`
`224`	`220`
`225`	`221`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -552,7 +552,6 @@ public List<SignalRegistrationRequest> getRequests() {`
`552`	`552`	`}`
`553`	`553`	`}`
`554`	`554`
`555`		`- @Experimental`
`556`	`555`	`final class UpdateRegistrationRequest {`
`557`	`556`	`private final String updateName;`
`558`	`557`	`private final String description;`
`@@ -626,7 +625,6 @@ public Functions.Func1<Object[], Object> getExecuteCallback() {`
`626`	`625`	`}`
`627`	`626`	`}`
`628`	`627`
`629`		`- @Experimental`
`630`	`628`	`final class RegisterUpdateHandlersInput {`
`631`	`629`	`private final List<UpdateRegistrationRequest> requests;`
`632`	`630`
`@@ -718,7 +716,6 @@ public DynamicSignalHandler getHandler() {`
`718`	`716`	`}`
`719`	`717`	`}`
`720`	`718`
`721`		`- @Experimental`
`722`	`719`	`final class RegisterDynamicUpdateHandlerInput {`
`723`	`720`	`private final DynamicUpdateHandler handler;`
`724`	`721`
`@@ -769,14 +766,12 @@ <R> R mutableSideEffect(`
`769`	`766`
`770`	`767`	`void registerSignalHandlers(RegisterSignalHandlersInput input);`
`771`	`768`
`772`		`- @Experimental`
`773`	`769`	`void registerUpdateHandlers(RegisterUpdateHandlersInput input);`
`774`	`770`
`775`	`771`	`void registerDynamicSignalHandler(RegisterDynamicSignalHandlerInput handler);`
`776`	`772`
`777`	`773`	`void registerDynamicQueryHandler(RegisterDynamicQueryHandlerInput input);`
`778`	`774`
`779`		`- @Experimental`
`780`	`775`	`void registerDynamicUpdateHandler(RegisterDynamicUpdateHandlerInput input);`
`781`	`776`
`782`	`777`	`UUID randomUUID();`
Original file line number	Diff line number	Diff line change
`@@ -222,13 +222,11 @@ public List<POJOWorkflowMethodMetadata> getQueryMethods() {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`/** List of update methods an object implements across all the workflow interfaces. */`
`225`		`- @Experimental`
`226`	`225`	`public List<POJOWorkflowMethodMetadata> getUpdateMethods() {`
`227`	`226`	`return updateMethods;`
`228`	`227`	`}`
`229`	`228`
`230`	`229`	`/** List of update validator methods an object implements across all the workflow interfaces. */`
`231`		`- @Experimental`
`232`	`230`	`public List<POJOWorkflowMethodMetadata> getUpdateValidatorMethods() {`
`233`	`231`	`return updateValidatorMethods;`
`234`	`232`	`}`