add test displaying NDE from 1.11.3 replay

chris-olszewski · chris-olszewski · commit 15b68badd5ba · 2025-10-17T09:27:44.000-04:00
diff --git a/packages/test/history_files/otel_1_11_3.json b/packages/test/history_files/otel_1_11_3.json
@@ -0,0 +1,215 @@
+{
+  "events": [
+    {
+      "eventId": "1",
+      "eventTime": "2025-10-17T12:56:44.200769Z",
+      "eventType": "EVENT_TYPE_WORKFLOW_EXECUTION_STARTED",
+      "taskId": "1049716",
+      "workflowExecutionStartedEventAttributes": {
+        "workflowType": {
+          "name": "signalStartOtel"
+        },
+        "taskQueue": {
+          "name": "test-otel-inbound",
+          "kind": "TASK_QUEUE_KIND_NORMAL"
+        },
+        "input": {},
+        "workflowTaskTimeout": "10s",
+        "originalExecutionRunId": "10b7e171-0ee7-4775-ad6d-f5df09aa4160",
+        "identity": "82936@mac.lan",
+        "firstExecutionRunId": "10b7e171-0ee7-4775-ad6d-f5df09aa4160",
+        "attempt": 1,
+        "firstWorkflowTaskBackoff": "0s",
+        "header": {
+          "fields": {}
+        },
+        "workflowId": "f61035b7-9fa3-4120-ac03-98763ccd469a"
+      }
+    },
+    {
+      "eventId": "2",
+      "eventTime": "2025-10-17T12:56:44.200815Z",
+      "eventType": "EVENT_TYPE_WORKFLOW_EXECUTION_SIGNALED",
+      "taskId": "1049717",
+      "workflowExecutionSignaledEventAttributes": {
+        "signalName": "startSignal",
+        "input": {},
+        "identity": "82936@mac.lan",
+        "header": {
+          "fields": {}
+        }
+      }
+    },
+    {
+      "eventId": "3",
+      "eventTime": "2025-10-17T12:56:44.200819Z",
+      "eventType": "EVENT_TYPE_WORKFLOW_TASK_SCHEDULED",
+      "taskId": "1049718",
+      "workflowTaskScheduledEventAttributes": {
+        "taskQueue": {
+          "name": "test-otel-inbound",
+          "kind": "TASK_QUEUE_KIND_NORMAL"
+        },
+        "startToCloseTimeout": "10s",
+        "attempt": 1
+      }
+    },
+    {
+      "eventId": "4",
+      "eventTime": "2025-10-17T12:56:44.201794Z",
+      "eventType": "EVENT_TYPE_WORKFLOW_TASK_STARTED",
+      "taskId": "1049722",
+      "workflowTaskStartedEventAttributes": {
+        "scheduledEventId": "3",
+        "identity": "82936@mac.lan",
+        "requestId": "488319d7-d425-44eb-b5ce-362f8462be1f",
+        "historySizeBytes": "327",
+        "workerVersion": {
+          "buildId": "@temporalio/worker@1.13.1+6b92c11c4f907379345c3513a5f749c90d752cfd0a3bf888bf0be04350bb0d2e"
+        }
+      }
+    },
+    {
+      "eventId": "5",
+      "eventTime": "2025-10-17T12:56:44.229959Z",
+      "eventType": "EVENT_TYPE_WORKFLOW_TASK_COMPLETED",
+      "taskId": "1049726",
+      "workflowTaskCompletedEventAttributes": {
+        "scheduledEventId": "3",
+        "startedEventId": "4",
+        "identity": "82936@mac.lan",
+        "workerVersion": {
+          "buildId": "@temporalio/worker@1.13.1+6b92c11c4f907379345c3513a5f749c90d752cfd0a3bf888bf0be04350bb0d2e"
+        },
+        "sdkMetadata": {
+          "coreUsedFlags": [
+            1,
+            3,
+            2
+          ],
+          "langUsedFlags": [
+            2
+          ],
+          "sdkName": "temporal-typescript",
+          "sdkVersion": "1.13.1"
+        },
+        "meteringMetadata": {}
+      }
+    },
+    {
+      "eventId": "6",
+      "eventTime": "2025-10-17T12:56:44.229985Z",
+      "eventType": "EVENT_TYPE_MARKER_RECORDED",
+      "taskId": "1049727",
+      "markerRecordedEventAttributes": {
+        "details": {
+          "data": {
+            "payloads": [
+              {
+                "metadata": {
+                  "encoding": "anNvbi9wbGFpbg=="
+                },
+                "data": "eyJzZXEiOjEsImF0dGVtcHQiOjEsImFjdGl2aXR5X2lkIjoiMSIsImFjdGl2aXR5X3R5cGUiOiJhIiwiY29tcGxldGVfdGltZSI6eyJzZWNvbmRzIjoxNzYwNzA1ODA0LCJuYW5vcyI6MjAyMzY4NjY3fSwiYmFja29mZiI6bnVsbCwib3JpZ2luYWxfc2NoZWR1bGVfdGltZSI6eyJzZWNvbmRzIjoxNzYwNzA1ODA0LCJuYW5vcyI6MjI0MTE2MDAwfX0="
+              }
+            ]
+          },
+          "result": {
+            "payloads": [
+              {
+                "metadata": {
+                  "encoding": "anNvbi9wbGFpbg=="
+                },
+                "data": "ImEi"
+              }
+            ]
+          }
+        },
+        "markerName": "core_local_activity",
+        "workflowTaskCompletedEventId": "5"
+      }
+    },
+    {
+      "eventId": "7",
+      "eventTime": "2025-10-17T12:56:44.229986Z",
+      "eventType": "EVENT_TYPE_MARKER_RECORDED",
+      "taskId": "1049728",
+      "markerRecordedEventAttributes": {
+        "details": {
+          "result": {
+            "payloads": [
+              {
+                "metadata": {
+                  "encoding": "anNvbi9wbGFpbg=="
+                },
+                "data": "ImIi"
+              }
+            ]
+          },
+          "data": {
+            "payloads": [
+              {
+                "metadata": {
+                  "encoding": "anNvbi9wbGFpbg=="
+                },
+                "data": "eyJzZXEiOjIsImF0dGVtcHQiOjEsImFjdGl2aXR5X2lkIjoiMiIsImFjdGl2aXR5X3R5cGUiOiJiIiwiY29tcGxldGVfdGltZSI6eyJzZWNvbmRzIjoxNzYwNzA1ODA0LCJuYW5vcyI6MjAyNjc1OTE3fSwiYmFja29mZiI6bnVsbCwib3JpZ2luYWxfc2NoZWR1bGVfdGltZSI6eyJzZWNvbmRzIjoxNzYwNzA1ODA0LCJuYW5vcyI6MjI3MzQ4MDAwfX0="
+              }
+            ]
+          }
+        },
+        "markerName": "core_local_activity",
+        "workflowTaskCompletedEventId": "5"
+      }
+    },
+    {
+      "eventId": "8",
+      "eventTime": "2025-10-17T12:56:44.230034Z",
+      "eventType": "EVENT_TYPE_MARKER_RECORDED",
+      "taskId": "1049729",
+      "markerRecordedEventAttributes": {
+        "details": {
+          "data": {
+            "payloads": [
+              {
+                "metadata": {
+                  "encoding": "anNvbi9wbGFpbg=="
+                },
+                "data": "eyJzZXEiOjMsImF0dGVtcHQiOjEsImFjdGl2aXR5X2lkIjoiMyIsImFjdGl2aXR5X3R5cGUiOiJjIiwiY29tcGxldGVfdGltZSI6eyJzZWNvbmRzIjoxNzYwNzA1ODA0LCJuYW5vcyI6MjAyNzI0ODM0fSwiYmFja29mZiI6bnVsbCwib3JpZ2luYWxfc2NoZWR1bGVfdGltZSI6eyJzZWNvbmRzIjoxNzYwNzA1ODA0LCJuYW5vcyI6MjI3MzU2MDAwfX0="
+              }
+            ]
+          },
+          "result": {
+            "payloads": [
+              {
+                "metadata": {
+                  "encoding": "anNvbi9wbGFpbg=="
+                },
+                "data": "ImMi"
+              }
+            ]
+          }
+        },
+        "markerName": "core_local_activity",
+        "workflowTaskCompletedEventId": "5"
+      }
+    },
+    {
+      "eventId": "9",
+      "eventTime": "2025-10-17T12:56:44.230036Z",
+      "eventType": "EVENT_TYPE_WORKFLOW_EXECUTION_COMPLETED",
+      "taskId": "1049730",
+      "workflowExecutionCompletedEventAttributes": {
+        "result": {
+          "payloads": [
+            {
+              "metadata": {
+                "encoding": "anNvbi9wbGFpbg=="
+              },
+              "data": "ImFiYyI="
+            }
+          ]
+        },
+        "workflowTaskCompletedEventId": "5"
+      }
+    }
+  ]
+}
diff --git a/packages/test/src/helpers-integration.ts b/packages/test/src/helpers-integration.ts
@@ -6,8 +6,10 @@ import {
   WorkflowFailedError,
   WorkflowHandle,
   WorkflowHandleWithFirstExecutionRunId,
+  WorkflowHandleWithSignaledRunId,
   WorkflowStartOptions,
   WorkflowUpdateFailedError,
+  WorkflowSignalWithStartOptionsWithArgs,
 } from '@temporalio/client';
 import {
   LocalTestWorkflowEnvironmentOptions,
@@ -195,6 +197,16 @@ export interface Helpers {
     fn: T,
     opts: Omit<WorkflowStartOptions, 'taskQueue' | 'workflowId'> & Partial<Pick<WorkflowStartOptions, 'workflowId'>>
   ): Promise<WorkflowHandleWithFirstExecutionRunId<T>>;
+  signalWithStart<T extends workflow.Workflow, U extends any[]>(
+    fn: T,
+    signal: workflow.SignalDefinition<U>
+  ): Promise<WorkflowHandleWithSignaledRunId<T>>;
+  signalWithStart<T extends workflow.Workflow, U extends any[]>(
+    fn: T,
+    signal: workflow.SignalDefinition<U>,
+    opts: Omit<WorkflowSignalWithStartOptionsWithArgs<U>, 'taskQueue' | 'workflowId'> &
+      Partial<Pick<WorkflowStartOptions, 'workflowId'>>
+  ): Promise<WorkflowHandleWithSignaledRunId<T>>;
   assertWorkflowUpdateFailed(p: Promise<any>, causeConstructor: ErrorConstructor, message?: string): Promise<void>;
   assertWorkflowFailedError(p: Promise<any>, causeConstructor: ErrorConstructor, message?: string): Promise<void>;
   updateHasBeenAdmitted(handle: WorkflowHandle<workflow.Workflow>, updateId: string): Promise<boolean>;
@@ -250,6 +262,21 @@ export function configurableHelpers<T>(
         ...opts,
       });
     },
+
+    async signalWithStart(
+      fn: workflow.Workflow,
+      signal: workflow.SignalDefinition<any[]>,
+      opts?: Omit<WorkflowSignalWithStartOptionsWithArgs<any[]>, 'taskQueue' | 'workflowId'> &
+        Partial<Pick<WorkflowStartOptions, 'workflowId'>>
+    ): Promise<WorkflowHandleWithSignaledRunId<workflow.Workflow>> {
+      return await testEnv.client.workflow.signalWithStart(fn, {
+        signal,
+        taskQueue,
+        workflowId: randomUUID(),
+        ...opts,
+      });
+    },
+
     async assertWorkflowUpdateFailed(
       p: Promise<any>,
       causeConstructor: ErrorConstructor,
diff --git a/packages/test/src/test-integration-workflows.ts b/packages/test/src/test-integration-workflows.ts
@@ -1,3 +1,6 @@
+import * as opentelemetry from '@opentelemetry/sdk-node';
+import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
+import { ConsoleSpanExporter } from '@opentelemetry/sdk-trace-node';
 import { setTimeout as setTimeoutPromise } from 'timers/promises';
 import { randomUUID } from 'crypto';
 import asyncRetry from 'async-retry';
@@ -49,7 +52,7 @@ import {
 } from './helpers-integration';
 import { overrideSdkInternalFlag } from './mock-internal-flags';
 import { heartbeatCancellationDetailsActivity } from './activities/heartbeat-cancellation-details';
-import { loadHistory, RUN_TIME_SKIPPING_TESTS, waitUntil } from './helpers';
+import { loadHistory, RUN_TIME_SKIPPING_TESTS, saveHistory, waitUntil } from './helpers';
 
 const test = makeTestFunction({
   workflowsPath: __filename,
@@ -513,6 +516,7 @@ test("Worker doesn't request Eager Activity Dispatch if no activities are regist
 
 const unblockSignal = defineSignal('unblock');
 const getBuildIdQuery = defineQuery<string>('getBuildId');
+const startSignal = defineSignal('startSignal');
 
 export async function buildIdTester(): Promise<void> {
   let blocked = true;
diff --git a/packages/test/src/test-otel.ts b/packages/test/src/test-otel.ts
@@ -8,7 +8,12 @@ import { SpanStatusCode } from '@opentelemetry/api';
 import { ExportResultCode } from '@opentelemetry/core';
 import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-grpc';
 import * as opentelemetry from '@opentelemetry/sdk-node';
-import { BasicTracerProvider, InMemorySpanExporter, SimpleSpanProcessor } from '@opentelemetry/sdk-trace-base';
+import {
+  BasicTracerProvider,
+  ConsoleSpanExporter,
+  InMemorySpanExporter,
+  SimpleSpanProcessor,
+} from '@opentelemetry/sdk-trace-base';
 import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
 import test from 'ava';
 import { v4 as uuid4 } from 'uuid';
@@ -24,8 +29,9 @@ import {
 import { OpenTelemetrySinks, SpanName, SPAN_DELIMITER } from '@temporalio/interceptors-opentelemetry/lib/workflow';
 import { DefaultLogger, InjectedSinks, Runtime } from '@temporalio/worker';
 import * as activities from './activities';
-import { RUN_INTEGRATION_TESTS, TestWorkflowEnvironment, Worker } from './helpers';
+import { loadHistory, RUN_INTEGRATION_TESTS, saveHistory, TestWorkflowEnvironment, Worker } from './helpers';
 import * as workflows from './workflows';
+import { createTestWorkflowBundle } from './helpers-integration';
 
 async function withFakeGrpcServer(
   fn: (port: number) => Promise<void>,
@@ -510,3 +516,65 @@ if (RUN_INTEGRATION_TESTS) {
     t.is(spans[2].status.code, SpanStatusCode.OK);
   });
 }
+
+test('Can replay otel history from 1.11.3', async (t) => {
+  const staticResource = new opentelemetry.resources.Resource({
+    [SemanticResourceAttributes.SERVICE_NAME]: 'ts-test-otel-worker',
+  });
+  const worker = await Worker.create({
+    workflowsPath: require.resolve('./workflows/signal-start-otel'),
+    activities: {
+      a: async () => 'a',
+      b: async () => 'b',
+      c: async () => 'c',
+    },
+    taskQueue: 'test-otel-inbound',
+    sinks: {
+      exporter: makeWorkflowExporter(new InMemorySpanExporter(), staticResource),
+    },
+    interceptors: {
+      workflowModules: [require.resolve('./workflows/signal-start-otel')],
+      activity: [
+        (ctx) => ({
+          inbound: new OpenTelemetryActivityInboundInterceptor(ctx),
+        }),
+      ],
+    },
+  });
+  const client = new WorkflowClient();
+
+  /*
+  const result = await worker.runUntil(async () => {
+    const handle = await client.signalWithStart(workflows.signalStartOtel, {
+      signal: workflows.startSignal,
+      taskQueue: 'test-otel-inbound',
+      workflowId: uuid4(),
+    });
+    const result = await handle.result();
+    const history = await handle.fetchHistory();
+    await saveHistory('otel_current.json', history);
+    return result;
+  });
+  */
+
+  const hist = await loadHistory('otel_1_11_3.json');
+  Worker.runReplayHistory(
+    {
+      workflowBundle: await createTestWorkflowBundle({
+        workflowsPath: require.resolve('./workflows/signal-start-otel'),
+        workflowInterceptorModules: [require.resolve('./workflows/signal-start-otel')],
+      }),
+      interceptors: {
+        workflowModules: [require.resolve('./workflows/otel-interceptors')],
+        activity: [
+          (ctx) => ({
+            inbound: new OpenTelemetryActivityInboundInterceptor(ctx),
+          }),
+        ],
+      },
+    },
+    hist
+  );
+  // t.is('abc', result);
+  t.pass();
+});
diff --git a/packages/test/src/workflows/inbound-signal.ts b/packages/test/src/workflows/inbound-signal.ts
diff --git a/packages/test/src/workflows/index.ts b/packages/test/src/workflows/index.ts
@@ -65,6 +65,7 @@ export * from './shared-cancellation-scopes';
 export * from './noncancellable-awaited-in-root-scope';
 export * from './noncancellable-in-noncancellable';
 export * from './signal-handlers-clear';
+export * from './signal-start-otel';
 export * from './signal-target';
 export * from './signals-are-always-processed';
 export * from './signals-ordering';
diff --git a/packages/test/src/workflows/signal-start-otel.ts b/packages/test/src/workflows/signal-start-otel.ts
