Skip to content

Commit de2add8

Browse files
pr feedback
1 parent 8cfa9a1 commit de2add8

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/interceptors-opentelemetry/src/workflow/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ function getTracer(): otel.Tracer {
5252
*/
5353
export class OpenTelemetryInboundInterceptor implements WorkflowInboundCallsInterceptor {
5454
protected readonly tracer = getTracer();
55-
protected readonly maybeInjectYield = true;
5655

5756
public constructor() {
5857
ensureWorkflowModuleLoaded();

packages/workflow/src/flags.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const SdkFlags = {
5252
*
5353
* This yield point was removed in 1.13.2, but in order to prevent workflows from the
5454
* affected versions resulting in NDE, we have to inject the yield point on replay.
55-
* This flag should be enabled for SDK versions newer than 1.11.3 or older than 1.13.2.
55+
* This flag should be enabled for SDK versions newer than 1.11.3 and older than 1.13.2.
5656
*
5757
* @since Introduced in 1.13.2.
5858
*/
@@ -68,7 +68,7 @@ export const SdkFlags = {
6868
*
6969
* @since Introduced in 1.13.2
7070
*/
71-
OpenTelemetryInterceptorInsertYield: defineFlag(3, false, [isBefore({ major: 1, minor: 13, patch: 2 }, true)]),
71+
OpenTelemetryInterceptorInsertYield: defineFlag(4, false, [isBefore({ major: 1, minor: 13, patch: 2 }, true)]),
7272
/**
7373
* In 1.11.6, the `scheduleLocalActivity` interceptor was added to
7474
* `@temporalio/interceptors-opentelemetry` which added a yield point to the
@@ -79,7 +79,7 @@ export const SdkFlags = {
7979
*
8080
* @since Introduced in 1.13.2
8181
*/
82-
OpenTelemetryScheduleLocalActivityInterceptorInsertYield: defineFlag(4, false, [
82+
OpenTelemetryScheduleLocalActivityInterceptorInsertYield: defineFlag(5, false, [
8383
isBetween({ major: 1, minor: 11, patch: 5 }, { major: 1, minor: 13, patch: 2 }),
8484
]),
8585
} as const;

0 commit comments

Comments
 (0)