Introduce envconfig package (#1795)

Author: THardy98

package-lock.json

@@ -42,6 +42,7 @@
     "@temporalio/cloud": "file:packages/cloud",
     "@temporalio/common": "file:packages/common",
     "@temporalio/create": "file:packages/create-project",
+    "@temporalio/envconfig": "file:packages/envconfig",
     "@temporalio/interceptors-opentelemetry": "file:packages/interceptors-opentelemetry",
     "@temporalio/nexus": "file:packages/nexus",
     "@temporalio/nyc-test-coverage": "file:packages/nyc-test-coverage",
@@ -87,6 +88,7 @@
     "packages/common",
     "packages/core-bridge",
     "packages/create-project",
+    "packages/envconfig",
     "packages/interceptors-opentelemetry",
     "packages/nexus",
     "packages/nyc-test-coverage",

package.json

@@ -204,10 +204,13 @@ function normalizeGRPCConfig(options?: ConnectionOptions): ConnectionOptions {
     if (credentials) {
       throw new TypeError('Both `tls` and `credentials` ConnectionOptions were provided');
     }
+    const serverRootCert = tls.serverRootCACertificate && Buffer.from(tls.serverRootCACertificate);
+    const clientCertKey = tls.clientCertPair?.key && Buffer.from(tls.clientCertPair?.key);
+    const clientCertCrt = tls.clientCertPair?.crt && Buffer.from(tls.clientCertPair?.crt);
     return {
       ...rest,
       credentials: grpc.credentials.combineChannelCredentials(
-        grpc.credentials.createSsl(tls.serverRootCACertificate, tls.clientCertPair?.key, tls.clientCertPair?.crt),
+        grpc.credentials.createSsl(serverRootCert, clientCertKey, clientCertCrt),
         ...(callCredentials ?? [])
       ),
       channelArgs: {

packages/client/src/connection.ts

@@ -12,13 +12,13 @@ export interface TLSConfig {
    * Root CA certificate used by the server. If not set, and the server's
    * cert is issued by someone the operating system trusts, verification will still work (ex: Cloud offering).
    */
-  serverRootCACertificate?: Buffer;
+  serverRootCACertificate?: Uint8Array;
   /** Sets the client certificate and key for connecting with mTLS */
   clientCertPair?: {
     /** The certificate for this client */
-    crt: Buffer;
+    crt: Uint8Array;
     /** The private key for this client */
-    key: Buffer;
+    key: Uint8Array;
   };
 }
 

packages/common/src/internal-non-workflow/tls-config.ts

@@ -0,0 +1,5 @@
+# `@temporalio/envconfig`
+
+[![NPM](https://img.shields.io/npm/v/@temporalio/envconfig?style=for-the-badge)](https://www.npmjs.com/package/@temporalio/envconfig)
+
+Part of [Temporal](https://temporal.io)'s [TypeScript SDK](https://docs.temporal.io/typescript/introduction/).

packages/envconfig/README.md

@@ -0,0 +1,42 @@
+{
+  "name": "@temporalio/envconfig",
+  "version": "0.0.1",
+  "description": "Temporal.io SDK Environment Configuration sub-package",
+  "main": "lib/index.js",
+  "types": "./lib/index.d.ts",
+  "scripts": {},
+  "keywords": [
+    "temporal",
+    "environment",
+    "configuration",
+    "client"
+  ],
+  "author": "Temporal Technologies Inc. <sdk@temporal.io>",
+  "license": "MIT",
+  "dependencies": {
+    "@temporalio/common": "file:../common",
+    "smol-toml": "1.4.2"
+  },
+  "devDependencies": {
+    "@temporalio/worker": "file:../worker"
+  },
+  "engines": {
+    "node": ">= 18.0.0"
+  },
+  "bugs": {
+    "url": "https://github.com/temporalio/sdk-typescript/issues"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/temporalio/sdk-typescript.git",
+    "directory": "packages/envconfig"
+  },
+  "homepage": "https://github.com/temporalio/sdk-typescript/tree/main/packages/envconfig",
+  "publishConfig": {
+    "access": "public"
+  },
+  "files": [
+    "src",
+    "lib"
+  ]
+}