feat: Make compatible_runtimes optional, added sam metadata control (#493)

ajschmidt8 · antonbabenko · semantic-release-bot · web-flow · commit 180da4cb0a72 · 2023-10-27T20:00:25.000+02:00
Co-authored-by: Anton Babenko &lt;anton@antonbabenko.com&gt;
Co-authored-by: semantic-release-bot &lt;semantic-release-bot@martynus.net&gt;
diff --git a/examples/alias/main.tf b/examples/alias/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 data "aws_organizations_organization" "this" {}
diff --git a/examples/async/main.tf b/examples/async/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 resource "random_pet" "this" {
diff --git a/examples/build-package/main.tf b/examples/build-package/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 resource "random_pet" "this" {
diff --git a/examples/code-signing/main.tf b/examples/code-signing/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 ################################################################################
diff --git a/examples/complete/main.tf b/examples/complete/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 data "aws_caller_identity" "current" {}
diff --git a/examples/container-image/main.tf b/examples/container-image/main.tf
@@ -11,7 +11,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 provider "docker" {
diff --git a/examples/deploy/main.tf b/examples/deploy/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 resource "random_pet" "this" {
diff --git a/examples/event-source-mapping/main.tf b/examples/event-source-mapping/main.tf
@@ -6,7 +6,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 data "aws_availability_zones" "available" {}
diff --git a/examples/multiple-regions/main.tf b/examples/multiple-regions/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 provider "aws" {
@@ -16,7 +15,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 ################################
diff --git a/examples/simple/main.tf b/examples/simple/main.tf
@@ -6,7 +6,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 resource "random_pet" "this" {
diff --git a/examples/triggers/main.tf b/examples/triggers/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 ##########################################
diff --git a/examples/with-efs/main.tf b/examples/with-efs/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 resource "random_pet" "this" {
diff --git a/examples/with-vpc-s3-endpoint/main.tf b/examples/with-vpc-s3-endpoint/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 data "aws_region" "current" {}
diff --git a/examples/with-vpc/main.tf b/examples/with-vpc/main.tf
@@ -5,7 +5,6 @@ provider "aws" {
   skip_metadata_api_check     = true
   skip_region_validation      = true
   skip_credentials_validation = true
-  skip_requesting_account_id  = true
 }
 
 resource "random_pet" "this" {
diff --git a/main.tf b/main.tf
@@ -151,7 +151,7 @@ resource "aws_lambda_layer_version" "this" {
   description  = var.description
   license_info = var.license_info
 
-  compatible_runtimes      = length(var.compatible_runtimes) > 0 ? var.compatible_runtimes : [var.runtime]
+  compatible_runtimes      = length(var.compatible_runtimes) > 0 ? var.compatible_runtimes : (var.runtime == "" ? null : [var.runtime])
   compatible_architectures = var.compatible_architectures
   skip_destroy             = var.layer_skip_destroy
 
diff --git a/modules/docker-build/README.md b/modules/docker-build/README.md
@@ -87,6 +87,7 @@ No modules.
 |------|-------------|------|---------|:--------:|
 | <a name="input_build_args"></a> [build\_args](#input\_build\_args) | A map of Docker build arguments. | `map(string)` | `{}` | no |
 | <a name="input_create_ecr_repo"></a> [create\_ecr\_repo](#input\_create\_ecr\_repo) | Controls whether ECR repository for Lambda image should be created | `bool` | `false` | no |
+| <a name="input_create_sam_metadata"></a> [create\_sam\_metadata](#input\_create\_sam\_metadata) | Controls whether the SAM metadata null resource should be created | `bool` | `false` | no |
 | <a name="input_docker_file_path"></a> [docker\_file\_path](#input\_docker\_file\_path) | Path to Dockerfile in source package | `string` | `"Dockerfile"` | no |
 | <a name="input_ecr_address"></a> [ecr\_address](#input\_ecr\_address) | Address of ECR repository for cross-account container image pulling (optional). Option `create_ecr_repo` must be `false` | `string` | `null` | no |
 | <a name="input_ecr_force_delete"></a> [ecr\_force\_delete](#input\_ecr\_force\_delete) | If true, will delete the repository even if it contains images. | `bool` | `true` | no |
diff --git a/modules/docker-build/main.tf b/modules/docker-build/main.tf
@@ -51,6 +51,8 @@ resource "aws_ecr_lifecycle_policy" "this" {
 # to the TF application. This resource will maintain the metadata information about the image type lambda
 # functions. It will contain the information required to build the docker image locally.
 resource "null_resource" "sam_metadata_docker_registry_image" {
+  count = var.create_sam_metadata ? 1 : 0
+
   triggers = {
     resource_type     = "IMAGE_LAMBDA_FUNCTION"
     docker_context    = var.source_path
diff --git a/modules/docker-build/variables.tf b/modules/docker-build/variables.tf
@@ -4,6 +4,12 @@ variable "create_ecr_repo" {
   default     = false
 }
 
+variable "create_sam_metadata" {
+  description = "Controls whether the SAM metadata null resource should be created"
+  type        = bool
+  default     = false
+}
+
 variable "ecr_address" {
   description = "Address of ECR repository for cross-account container image pulling (optional). Option `create_ecr_repo` must be `false`"
   type        = string
diff --git a/wrappers/docker-build/main.tf b/wrappers/docker-build/main.tf
@@ -4,6 +4,7 @@ module "wrapper" {
   for_each = var.items
 
   create_ecr_repo           = try(each.value.create_ecr_repo, var.defaults.create_ecr_repo, false)
+  create_sam_metadata       = try(each.value.create_sam_metadata, var.defaults.create_sam_metadata, false)
   ecr_address               = try(each.value.ecr_address, var.defaults.ecr_address, null)
   ecr_repo                  = try(each.value.ecr_repo, var.defaults.ecr_repo, null)
   image_tag                 = try(each.value.image_tag, var.defaults.image_tag, null)

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ provider "aws" {`
`5`	`5`	`skip_metadata_api_check = true`
`6`	`6`	`skip_region_validation = true`
`7`	`7`	`skip_credentials_validation = true`
`8`		`- skip_requesting_account_id = true`
`9`	`8`	`}`
`10`	`9`
`11`	`10`	`data "aws_organizations_organization" "this" {}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ provider "aws" {`
`11`	`11`	`skip_metadata_api_check = true`
`12`	`12`	`skip_region_validation = true`
`13`	`13`	`skip_credentials_validation = true`
`14`		`- skip_requesting_account_id = true`
`15`	`14`	`}`
`16`	`15`
`17`	`16`	`provider "docker" {`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ provider "aws" {`
`6`	`6`	`skip_metadata_api_check = true`
`7`	`7`	`skip_region_validation = true`
`8`	`8`	`skip_credentials_validation = true`
`9`		`- skip_requesting_account_id = true`
`10`	`9`	`}`
`11`	`10`
`12`	`11`	`data "aws_availability_zones" "available" {}`