Skip to content

Commit 0941335

Browse files
authored
feat: improve DA user experience<br> - updated DA name. New name is Cloud foundation for on-premises connectivity.<br> - updated reference architecture diagram<br> - updates in variables description<br> - modified catalog content<br> - updated the listed DA permissions (#38)
* improve da user experience * Updated permission * further update the permission * Small Fixes * Addressed feedback * Updated the permission * fixed a bug * Updated the feature desc and architecture * Addressed the feedback regarding the descriptions * Updated the permission notes * Updates the desc and architecture * Fixed a small bug in UI * Fixed a small bug in UI #2 * Updated the title * Updated the arch bug * small arch fix * Fixed the default value for logs routing reg * Addressed more feedback on the descriptions * more description changes * Updated the arch * Updated the arch and some minor catalog changes * submodule update
1 parent cedfd7e commit 0941335

File tree

7 files changed

+140
-44
lines changed

7 files changed

+140
-44
lines changed

cra-tf-validate-ignore-rules.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
{
1010
"scc_rule_id": "rule-d544f217-3723-4376-b3aa-037c5f201e8d",
1111
"description": "Check whether Application Load Balancer for VPC uses HTTPS (SSL & TLS) instead of HTTP",
12-
"ignore_reason": "This rule is not relevant since ALB will be a member of the Private path NLB.",
12+
"ignore_reason": "This rule is not relevant since ALB will be a member of the Private Path NLB.",
1313
"is_valid": false
1414
}
1515
]

ibm_catalog.json

Lines changed: 120 additions & 25 deletions
Large diffs are not rendered by default.

reference-architectures/deployable-architecture-private-path-external-connectivity.svg

Lines changed: 4 additions & 0 deletions
Loading

reference-architectures/private-path-external-connectivity.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

solutions/fully-configurable/outputs.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ output "nlb_listener_id" {
6565
}
6666

6767
output "private_path_crn" {
68-
description = "The CRN for this private path service gateway."
68+
description = "The CRN for this Private Path service gateway."
6969
value = module.private_path.private_path_crn
7070
}
7171

@@ -75,7 +75,7 @@ output "private_path_id" {
7575
}
7676

7777
output "private_path_vpc" {
78-
description = "The VPC this private path service gateway resides in."
78+
description = "The VPC this Private Path service gateway resides in."
7979
value = module.private_path.private_path_vpc
8080
}
8181

solutions/fully-configurable/variables.tf

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@ variable "ibmcloud_api_key" {
1010

1111
variable "existing_resource_group_name" {
1212
type = string
13-
description = "The name of an existing resource group to provision the resources. If not provided the default resource group will be used."
13+
description = "The name of an existing resource group to provision the resources."
1414
default = null
1515
}
1616

1717
variable "region" {
1818
type = string
19-
description = "The region in which the VPC resources are provisioned."
19+
description = "The region to provision all the resources in. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/region) about how to select different regions for different services."
20+
default = "us-south"
2021
}
2122

2223
variable "provider_visibility" {
@@ -59,13 +60,13 @@ variable "prefix" {
5960

6061
variable "private_path_tags" {
6162
type = list(string)
62-
description = "Optional list of tags to be added to the private path service."
63+
description = "Optional list of tags to be added to the Private Path service."
6364
default = []
6465
}
6566

6667
variable "private_path_access_tags" {
6768
type = list(string)
68-
description = "A list of access tags to apply to the private path service created by the module, see https://cloud.ibm.com/docs/account?topic=account-access-tags-tutorial for more details."
69+
description = "A list of access tags to apply to the Private Path service created by the module, see https://cloud.ibm.com/docs/account?topic=account-access-tags-tutorial for more details."
6970
default = []
7071
}
7172

@@ -74,7 +75,7 @@ variable "private_path_access_tags" {
7475
##############################################################################
7576

7677
variable "existing_vpc_id" {
77-
description = "The ID of an existing VPC. If the user provides only the `existing_vpc_id` the private path service will be provisioned in the first subnet."
78+
description = "The ID of an existing VPC. If the user provides only the `existing_vpc_id`, the Private Path service will be provisioned in the first subnet."
7879
type = string
7980
default = null
8081
validation {
@@ -107,7 +108,7 @@ variable "application_loadbalancer_type" {
107108

108109
variable "application_loadbalancer_pool_algorithm" {
109110
type = string
110-
description = "The load-balancing algorithm for private path netwrok load balancer pool members. Supported values are `round_robin` or `weighted_round_robin`."
111+
description = "The load-balancing algorithm for Private Path network load balancer pool members. Supported values are `round_robin` or `weighted_round_robin`."
111112
default = "round_robin"
112113
}
113114

@@ -149,7 +150,7 @@ variable "application_loadbalancer_pool_protocol" {
149150

150151
variable "application_loadbalancer_listener_port" {
151152
type = number
152-
description = "The listener port for the private path netwrok load balancer."
153+
description = "The listener port for the Private Path network load balancer."
153154
default = 80
154155
}
155156

@@ -183,13 +184,13 @@ variable "application_loadbalancer_listener_certificate_instance" {
183184

184185
variable "network_loadbalancer_name" {
185186
type = string
186-
description = "The name of the private path netwrok load balancer."
187+
description = "The name of the Private Path network load balancer."
187188
default = "pp-nlb"
188189
}
189190

190191
variable "network_loadbalancer_listener_port" {
191192
type = number
192-
description = "The listener port for the private path netwrok load balancer."
193+
description = "The listener port for the Private Path network load balancer."
193194
default = 80
194195
}
195196

@@ -201,7 +202,7 @@ variable "network_loadbalancer_listener_accept_proxy_protocol" {
201202

202203
variable "network_loadbalancer_pool_algorithm" {
203204
type = string
204-
description = "The load-balancing algorithm for private path netwrok load balancer pool members. Supported values are `round_robin` or `weighted_round_robin`."
205+
description = "The load-balancing algorithm for Private Path network load balancer pool members. Supported values are `round_robin` or `weighted_round_robin`."
205206
default = "round_robin"
206207
}
207208

@@ -276,7 +277,7 @@ variable "private_path_name" {
276277

277278
variable "private_path_publish" {
278279
type = bool
279-
description = "Set this variable to `true` to allows any account to request access to to the Private Path service. If need be, you can also unpublish where access is restricted to the account that created the Private Path service by setting this variable to `false`."
280+
description = "Set this variable to `true` to allow any account to request access to the Private Path service. If need be, you can also unpublish where access is restricted to the account that created the Private Path service by setting this variable to `false`."
280281
default = false
281282
}
282283

0 commit comments

Comments
 (0)