[pull] master from robotframework:master #145

pull · 2022-05-10T02:52:45Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

squash-labs · 2023-02-14T10:42:44Z

Manage this branch in Squash

Test this branch here: https://master-n02a3.squash.io

Don't capitalize "kind" if it is not all lower case to avoid e.g. "FOR loop variable" to be changed to "For loop variable". Related to FOR loop variable conversion that's a missing part of issue #3278.

There already was `type`, `type_` wasn't needed.

Missing part of #3278. Includes also enhancements to variable validation during parsing.

Also utest cleanup

- Explicitly test `TypeConverter.validate` - Don't use deprecated `codecs.open` - Avoid flakeyness

Fixes #5352.

Disable setup to avoid very short 10ms timeout occurring already during it. In that case test fails because the error has unexpected `Setup failed:` prefix. The timeout needs to be short to avoid recursive execution hitting recursion limit.

Explain that using `BuiltIn.register_run_keyword` to disable timeouts isn't relevant anymore now that #5417 is fixed.

Avoids a method call and an if/else with each listener v3 `start/end_keyword` usage so has a small performance benefit.

Newer setuptools versions complain about pyproject.toml not having name, version, etc. The reason is that we currently only use pyproject.toml for configuring tools like Black, but we still have packaging stuff in setup.py. We'll move from setup.py to pyproject.toml in the future, but now isn't a good time.

`_delayed_messages` shouldn't be `None` when this method is called, but to be safe.

Fixes #5083.

Fixes #4514

We currently use pyproject.toml only for configuring external tools, not for our own project metadata. Newer setuptools versions didn't like a [project] table with incomplete information and thus the version was lowered earlier.

Tested that pip handles these equally well than earlier. Fixes #5098.

It was removed in e3781ab because new `matches` and `parse_args` made it redundant. It was used at least by one project, so now it's back but deprecated.

Fixes #2946. Documentation missing, but it will be done as part of documenting variable conversion in general (#3278).

Part of #2946.

`datetime` conversion suppors a special value `now` and `date` conversoin supports `today`. Fixes #5440.

See #5083.

Issue #3278, PR #5436.

Plenty of enhancements to BuiltIn: - The absolute biggest change is the added typing (fixes #5544) - Plenty of documentation enhancements - Various enhancements to tests - `timedelta` support to `Repeat Keyword` (fixes #5546) - Few FIXMEs about features to be deprecated - Remove references to RF 4.1 and older

Using `NO VALUES` to disable the `values=False` is deprecated (#5550) and this commit removes such usages. Explict tests need to be still added for validating the deprecation.

Most importantly, remove useless `_verify_condition` helper. Code is simpler and shorter if keywords evaluate conditions themselves and only use a helper for reporting failures.

Fixes #5550.

Test was broken due to Python's error message being changed.

The value should be omitted altogether or '0' used instead. Part of of #5537.

Fixes #5553. This was implemented by reusing Normalizer that Collections already used. A big benefit is that BuiltIn keywords doing normalization are now a lot simpler. Another big benefit is that adding bytes normalization support (#5548) will be easy.

Fixes #5557.

- Support string normalization (case-insensitivity, stripping and collapsing spaces) also with bytes. This affects all keywords in BuiltIn and Collections that support normalization and accept bytes. - If the first argument to validation keywords in BuiltIn is bytes, convert the second argument to bytes as well. - Enhance documentation related to normalization. - Also enhance documentation related to overriding failure messages. - Some general cleanup. Fixes #5548.

Missing piece of #5548.

Should Be Equal is more powerful these days,

Fixes #5536.

We expect everyone to use Python 3, no need to specify the version.

Also enhance string representation of `Callable` in Libdoc outputs. Fixes #5562.

But it should pass Any and object types Fixes #5520

Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.0.0 to 6.1.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v6.0.0...v6.1.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Part of #5373. Fixes #5541.

Most importantly, add custom type docs for Source and Element. Related to #5541 and #5373.

Not needed anymore when XML has typing (#5541) that brings documentation for the `bool` type automatically.

Hopefully this doesn't make tests flakey...

- Disable current timeouts when running keyword teardown to avoid them stopping execution. - After teardown, check has any of timeouts exceeded during it. - Timeouts set inside teardown are used normally. Fixes #5474.

Also round time left in the "timeout active" debug message to three decimals.

pull bot added the ⤵️ pull label May 10, 2022

pekkaklarck and others added 28 commits May 15, 2025 22:17

Fine-tune type conversion error message

9022df0

Don't capitalize "kind" if it is not all lower case to avoid e.g. "FOR loop variable" to be changed to "For loop variable". Related to FOR loop variable conversion that's a missing part of issue #3278.

Remove duplicate argument

3e3f64e

There already was `type`, `type_` wasn't needed.

FOR loop variable conversion

448fb07

Missing part of #3278. Includes also enhancements to variable validation during parsing.

Enhance API docs and type hints

375cc08

Also utest cleanup

Test tuning

b2c1cd1

- Explicitly test `TypeConverter.validate` - Don't use deprecated `codecs.open` - Avoid flakeyness

Declare official Python 3.14 support

96c6ea5

Fixes #5352.

Avoid test flakeyness

0449463

Disable setup to avoid very short 10ms timeout occurring already during it. In that case test fails because the error has unexpected `Setup failed:` prefix. The timeout needs to be short to avoid recursive execution hitting recursion limit.

Enhance docs

2dc16cd

Explain that using `BuiltIn.register_run_keyword` to disable timeouts isn't relevant anymore now that #5417 is fixed.

Refactor

9ab62cb

Avoids a method call and an if/else with each listener v3 `start/end_keyword` usage so has a small performance benefit.

Release notes for 7.3rc2

77e1013

Updated version to 7.3rc2

0f5cf25

Back to dev version

22baede

Guard for None.

9728623

`_delayed_messages` shouldn't be `None` when this method is called, but to be safe.

Process: Document that trailing newline is removed from stdout/stderr

78df7be

Fixes #5083.

Reset signal monitor between runs

bfd2a03

Fixes #4514

Remove [project] table from pyproject.toml

153db09

We currently use pyproject.toml only for configuring external tools, not for our own project metadata. Newer setuptools versions didn't like a [project] table with incomplete information and thus the version was lowered earlier.

buildout compatible entry point configuration

b36bba4

Tested that pip handles these equally well than earlier. Fixes #5098.

Add EmbeddedArguments.match back

5b121be

It was removed in e3781ab because new `matches` and `parse_args` made it redundant. It was used at least by one project, so now it's back but deprecated.

Command line variable conversion

7781d8f

Fixes #2946. Documentation missing, but it will be done as part of documenting variable conversion in general (#3278).

Enhance command line variable conversion test

84cf17b

Part of #2946.

Support current time conversion with datetime and date

8b0dad4

`datetime` conversion suppors a special value `now` and `date` conversoin supports `today`. Fixes #5440.

cleanup

5af1f17

Process: Enhance docs and tests related to newline handling

bd92295

See #5083.

Release notes for 7.3rc3

f72db2a

Updated version to 7.3rc3

3f6cb6b

Back to dev version

1a0351e

Initial documentation for variable comversion

c26fea6

Issue #3278, PR #5436.

pekkaklarck and others added 30 commits November 18, 2025 00:11

Avoid deprecated NO VALUES with values argument

ea3c472

Using `NO VALUES` to disable the `values=False` is deprecated (#5550) and this commit removes such usages. Explict tests need to be still added for validating the deprecation.

Refactor

8aa0dab

Most importantly, remove useless `_verify_condition` helper. Code is simpler and shorter if keywords evaluate conditions themselves and only use a helper for reporting failures.

Deprecate 'NO VALUES' with some BuiltIn and Collections keywords

b20e98d

Fixes #5550.

Fix test on Python 3.14

2328262

Test was broken due to Python's error message being changed.

Deprecate using empty string as start index

ca6fe63

The value should be omitted altogether or '0' used instead. Part of of #5537.

Enhance bytes conversion to support int and list[int]

8ffacd2

Fixes #5557.

Mention that also bytes support ignore_case in RF 7.4

6ba86bb

Missing piece of #5548.

Remove resource file with useless keyword

9b995ab

Should Be Equal is more powerful these days,

Collections: Change mutating keywords to also return values

cc8af56

Fixes #5536.

Remove references to Python 3.

9dd7786

We expect everyone to use Python 3, no need to specify the version.

Fix using Callable[[], Any] in type hints.

92a9364

Also enhance string representation of `Callable` in Libdoc outputs. Fixes #5562.

Secret should fail on str and bool types (#5547)

ec41551

But it should pass Any and object types Fixes #5520

Add annotations to XML (#5542)

5474d2c

Part of #5373. Fixes #5541.

Enhance ETSource typing

d5ee06e

Enhance XML typing.

af6666a

Most importantly, add custom type docs for Source and Element. Related to #5541 and #5373.

Remove documentation about Boolean arguments

c02d1c7

Not needed anymore when XML has typing (#5541) that brings documentation for the `bool` type automatically.

libdoc: html escape type names

2e8b334

libdoc: regen template

cfd5a6d

libdoc: remove type links from std return types

4d7d8e4

libdoc: regen template

d2fd0a9

Make tests faster by using shorter timeouts

71bd11b

Hopefully this doesn't make tests flakey...

Run keyword teardown properly after timeout

dfa5580

- Disable current timeouts when running keyword teardown to avoid them stopping execution. - After teardown, check has any of timeouts exceeded during it. - Timeouts set inside teardown are used normally. Fixes #5474.

Increase timeouts to hopefully fix tests on CI

cab0881

Increase timeouts to hopefully fix tests on CI v2

957be4f

Adjust timeouts to hopefully fix tests on CI v3

4c012a0

Also round time left in the "timeout active" debug message to three decimals.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pull] master from robotframework:master #145

[pull] master from robotframework:master #145

pull bot commented May 10, 2022 •

edited

Loading

Uh oh!

squash-labs bot commented Feb 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

[pull] master from robotframework:master #145

Are you sure you want to change the base?

[pull] master from robotframework:master #145

Conversation

pull bot commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

squash-labs bot commented Feb 14, 2023

Manage this branch in Squash

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

pull bot commented May 10, 2022 •

edited

Loading