fix(prefer-checked): don't auto-fix when 2nd argument is a non literal. (#62)

* fix:(prefer-checked): don't fix when 2nd arg is non literal)

* turned off babel/quotes, that' sprettiers job

* added docs

Author: benmonro

README.md

@@ -151,6 +151,7 @@ Thanks goes to these people ([emoji key][emojis]):
 
 <!-- markdownlint-enable -->
 <!-- prettier-ignore-end -->
+
 <!-- ALL-CONTRIBUTORS-LIST:END -->
 
 This project follows the [all-contributors][all-contributors] specification.

docs/rules/prefer-checked.md

@@ -47,6 +47,7 @@ Examples of **incorrect** code for this rule:
 ```js
 expect(element).toHaveProperty("checked", true);
 expect(element).toHaveAttribute("checked", false);
+expect(element).toHaveProperty("checked", something);
 
 expect(element).toHaveAttribute("checked");
 expect(element).not.toHaveProperty("checked");

src/__tests__/__fixtures__/createBannedAttributeTestCases.js

@@ -57,10 +57,10 @@ export default ({ preferred, negatedPreferred, attribute }) => {
 
   return {
     valid: [
-      `expect(element).not.toHaveProperty('value', 'foo')`,
+      "expect(element).not.toHaveProperty('value', 'foo')",
       `expect(element).${preferred}`,
       `expect(element).${negatedPreferred}`,
-      `expect(element).toHaveProperty('value', 'bar')`,
+      "expect(element).toHaveProperty('value', 'bar')",
     ],
     invalid: [
       ...doubleNegativeCases,
@@ -173,6 +173,14 @@ export default ({ preferred, negatedPreferred, attribute }) => {
         ],
         output: `expect(getByText("foo")).${negatedPreferred}`,
       },
+      {
+        code: `expect(element).toHaveProperty('${attribute}', foo)`,
+        errors: [
+          {
+            message: `Use ${preferred} instead of toHaveProperty('${attribute}', foo)`,
+          },
+        ],
+      },
     ],
   };
 };

src/createBannedAttributeRule.js

@@ -2,6 +2,7 @@ export default ({ preferred, negatedPreferred, attributes }) => (context) => {
   const getCorrectFunctionFor = (node, negated = false) =>
     (node.arguments.length === 1 ||
       node.arguments[1].value === true ||
+      node.arguments[1].type !== "Literal" ||
       (typeof node.arguments[1].value === "string" &&
         node.arguments[1].value.toLowerCase() === "true") ||
       node.arguments[1].value === "") &&
@@ -34,7 +35,7 @@ export default ({ preferred, negatedPreferred, attributes }) => (context) => {
           ),
       });
     },
-    [`CallExpression[callee.property.name=/toBe(Truthy|Falsy)?|toEqual/][callee.object.callee.name='expect']`](
+    "CallExpression[callee.property.name=/toBe(Truthy|Falsy)?|toEqual/][callee.object.callee.name='expect']"(
       node
     ) {
       const {
@@ -65,7 +66,7 @@ export default ({ preferred, negatedPreferred, attributes }) => (context) => {
         ],
       });
     },
-    [`CallExpression[callee.property.name=/toHaveProperty|toHaveAttribute/][callee.object.property.name='not'][callee.object.object.callee.name='expect']`](
+    "CallExpression[callee.property.name=/toHaveProperty|toHaveAttribute/][callee.object.property.name='not'][callee.object.object.callee.name='expect']"(
       node
     ) {
       const arg = node.arguments[0].value;
@@ -86,7 +87,7 @@ export default ({ preferred, negatedPreferred, attributes }) => (context) => {
           ),
       });
     },
-    [`CallExpression[callee.object.callee.name='expect'][callee.property.name=/toHaveProperty|toHaveAttribute/]`](
+    "CallExpression[callee.object.callee.name='expect'][callee.property.name=/toHaveProperty|toHaveAttribute/]"(
       node
     ) {
       if (!isBannedArg(node)) {
@@ -98,17 +99,27 @@ export default ({ preferred, negatedPreferred, attributes }) => (context) => {
       const incorrectFunction = node.callee.property.name;
 
       const message = `Use ${correctFunction}() instead of ${incorrectFunction}(${node.arguments
-        .map(({ raw }) => raw)
+        .map(({ raw, name }) => raw || name)
         .join(", ")})`;
+
+      const secondArgIsLiteral =
+        node.arguments.length === 2 && node.arguments[1].type === "Literal";
+
       context.report({
         node: node.callee.property,
         message,
-        fix: (fixer) => [
-          fixer.replaceTextRange(
-            [node.callee.property.range[0], node.range[1]],
-            `${correctFunction}()`
-          ),
-        ],
+        fix: (fixer) => {
+          if (node.arguments.length === 1 || secondArgIsLiteral) {
+            return [
+              fixer.replaceTextRange(
+                [node.callee.property.range[0], node.range[1]],
+                `${correctFunction}()`
+              ),
+            ];
+          }
+
+          return null;
+        },
       });
     },
   };