Skip to content

Commit 0f95a19

Browse files
fix: optimize logging and fix cookie domain
1 parent e29c78d commit 0f95a19

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,4 +160,4 @@ cython_debug/
160160
# and can be added to the global gitignore or merged into this file. For a more nuclear
161161
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
162162
.idea/
163-
tls_requests/bin/*xgo*
163+
tls_requests/bin/*

tls_requests/client.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,15 @@ def _send(
343343
is_byte_response=config.isByteResponse,
344344
)
345345
response.request = request
346+
347+
# Fix missing domain in cookies
348+
if response.cookies:
349+
for cookie in response.cookies.cookiejar:
350+
if not cookie.domain:
351+
cookie.domain = request.url.host
352+
cookie.domain_specified = False
353+
cookie.domain_initial_dot = False
354+
346355
response.default_encoding = self.encoding
347356
response.elapsed = datetime.timedelta(seconds=time.perf_counter() - start)
348357
if response.is_redirect:

tls_requests/utils.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,15 @@ def import_module(name: Union[str, list[str]]):
3333
def get_logger(
3434
name: str = "TLSRequests", level: int | str = logging.INFO
3535
) -> logging.Logger:
36-
logging.basicConfig(format=FORMAT, datefmt=DATE_FORMAT, level=level)
3736
logger = logging.getLogger(name)
3837
logger.setLevel(level)
38+
39+
if not logger.handlers:
40+
handler = logging.StreamHandler()
41+
formatter = logging.Formatter(FORMAT, datefmt=DATE_FORMAT)
42+
handler.setFormatter(formatter)
43+
logger.addHandler(handler)
44+
3945
return logger
4046

4147

0 commit comments

Comments
 (0)