edits

Author: timgraham

django_mongodb_backend/fields/embedded_model_array.py

@@ -32,8 +32,8 @@ def get_db_prep_value(self, value, connection, prepared=False):
         return value
 
     def formfield(self, **kwargs):
-        # Skip ArrayField.formfield() which has some differeences, including
-        # unneeded "base_field" and "max_length" instead of "max_num".
+        # Skip ArrayField.formfield() which has some differences, including
+        # unneeded "base_field", and "max_length" instead of "max_num".
         return Field.formfield(
             self,
             **{

django_mongodb_backend/forms/fields/embedded_model_array.py

@@ -40,6 +40,8 @@ def has_changed(self, initial, data):
 
     def get_bound_field(self, form, field_name):
         # Nested embedded model form fields need a double prefix.
+        # HACK: Setting self.prefix_override makes it available in clean()
+        # which doesn't have access to the form.
         self.prefix_override = f"{form.prefix}-{self.prefix}" if form.prefix else None
         return EmbeddedModelArrayBoundField(form, self, field_name, self.prefix_override)
 
@@ -62,8 +64,8 @@ def __str__(self):
 
 class EmbeddedModelArrayWidget(forms.Widget):
     """
-    This widget extracts the data for EmbeddedModelArrayFormField's formset.
-    It is never rendered.
+    Extract the data for EmbeddedModelArrayFormField's formset.
+    This widget is never rendered.
     """
 
     def value_from_datadict(self, data, files, name):

docs/make.bat

@@ -256,8 +256,8 @@ These indexes use 0-based indexing.
             class Book(models.Model):
                 author = EmbeddedModelField(Author)
 
-    See :ref:`the embedded model topic guide <embeddedmodelfield-example>` for
-    more details and examples.
+    See :ref:`the embedded model topic guide <embedded-model-field-example>`
+    for more details and examples.
 
 .. admonition:: Migrations support is limited
 
@@ -288,11 +288,11 @@ These indexes use 0-based indexing.
 
         This is an optional argument.
 
-        If passed, the array will have a maximum size as specified, validated
+        If passed, the list will have a maximum size as specified, validated
         by forms and model validation, but not enforced by the database.
 
-    See :ref:`the embedded model topic guide <embeddedmodelarrayfield-example>`
-    for more details and examples.
+    See :ref:`the embedded model topic guide
+    <embedded-model-array-field-example>` for more details and examples.
 
 .. admonition:: Migrations support is limited
 

docs/source/ref/models/fields.rst

@@ -10,8 +10,8 @@ Django MongoDB Backend 5.2.x
 New features
 ------------
 
-- Added :class:`~.fields.EmbeddedModelArrayField` for storing data as an array
-  of model instances.
+- Added :class:`~.fields.EmbeddedModelArrayField` for storing a list of model
+  instances.
 
 Bug fixes
 ---------

docs/source/releases/5.2.x.rst

@@ -6,7 +6,7 @@ Use :class:`~django_mongodb_backend.fields.EmbeddedModelField` and
 your data using `embedded documents
 <https://www.mongodb.com/docs/manual/data-modeling/#embedded-data>`_.
 
-.. _embeddedmodelfield-example:
+.. _embedded-model-field-example:
 
 ``EmbeddedModelField``
 ----------------------
@@ -52,8 +52,6 @@ Represented in BSON, Bob's structure looks like this:
      ...
    }
 
-Unless explicitly set, embedded models don't have a primary key value.
-
 Querying ``EmbeddedModelField``
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -63,7 +61,7 @@ address with the city "New York"::
 
     >>> Customer.objects.filter(address__city="New York")
 
-.. _embeddedmodelarrayfield-example:
+.. _embedded-model-array-field-example:
 
 ``EmbeddedModelArrayField``
 ---------------------------
@@ -108,5 +106,3 @@ Represented in BSON, Bob's structure looks like this:
      }],
      ...
    }
-
-Unless explicitly set, embedded models don't have a primary key value.

docs/source/topics/embedded-models.rst

@@ -1,4 +1,3 @@
-from django.core.exceptions import FieldError
 from django.db import models
 from django.test import SimpleTestCase, TestCase
 from django.test.utils import isolate_apps
@@ -56,37 +55,6 @@ def test_save_load_null(self):
         self.assertIsNone(movie.reviews)
 
 
-class QueryingTests(TestCase):
-    @classmethod
-    def setUpTestData(cls):
-        reviews = [
-            Review(title="The best", rating=10),
-            Review(title="Mediocre", rating=5),
-            Review(title="Horrible", rating=1),
-        ]
-        cls.clouds = Movie.objects.create(title="Clouds", reviews=reviews)
-        reviews = [
-            Review(title="Super", rating=9),
-            Review(title="Meh", rating=5),
-            Review(title="Horrible", rating=2),
-        ]
-        cls.frozen = Movie.objects.create(title="Frozen", reviews=reviews)
-        reviews = [
-            Review(title="Excellent", rating=9),
-            Review(title="Wow", rating=8),
-            Review(title="Classic", rating=7),
-        ]
-        cls.bears = Movie.objects.create(title="Bears", reviews=reviews)
-
-    def test_filter_with_field(self):
-        msg = (
-            "Unsupported lookup 'title' for EmbeddedModelArrayField or join "
-            "on the field not permitted."
-        )
-        with self.assertRaisesMessage(FieldError, msg):
-            Movie.objects.filter(reviews__title="Horrible")
-
-
 @isolate_apps("model_fields_")
 class CheckTests(SimpleTestCase):
     def test_no_relational_fields(self):